From: Conor Dooley <conor.dooley@microchip.com>
To: Nylon Chen <nylon.chen@sifive.com>
Cc: <aou@eecs.berkeley.edu>, <conor@kernel.org>,
<emil.renner.berthing@canonical.com>, <geert+renesas@glider.be>,
<heiko@sntech.de>, <krzysztof.kozlowski+dt@linaro.org>,
<palmer@dabbelt.com>, <paul.walmsley@sifive.com>,
<robh+dt@kernel.org>, <thierry.reding@gmail.com>,
<u.kleine-koenig@pengutronix.de>, <devicetree@vger.kernel.org>,
<linux-pwm@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <nylon7717@gmail.com>,
<zong.li@sifive.com>, <greentime.hu@sifive.com>,
<vincent.chen@sifive.com>
Subject: Re: [PATCH v3 1/2] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties
Date: Thu, 20 Apr 2023 11:20:05 +0100 [thread overview]
Message-ID: <20230420-backshift-negotiate-1c3d508582d2@wendy> (raw)
In-Reply-To: <20230420093457.18936-2-nylon.chen@sifive.com>
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
On Thu, Apr 20, 2023 at 05:34:56PM +0800, Nylon Chen wrote:
> This removes the active-low properties of the PWM-controlled LEDs in
> the HiFive Unmatched device tree.
>
> The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1].
>
> Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf [0]
> Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf [1]
>
Just a minor nit here, there should not be a blank line between the
link:s and the rest of the trailers.
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-04-20 10:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 9:34 [PATCH v3 0/2] Change PWM-controlled LED pin active mode and algorithm Nylon Chen
2023-04-20 9:34 ` [PATCH v3 1/2] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties Nylon Chen
2023-04-20 10:20 ` Conor Dooley [this message]
2023-04-20 9:34 ` [PATCH v3 2/2] pwm: sifive: change the PWM controlled LED algorithm Nylon Chen
2023-04-20 10:04 ` Emil Renner Berthing
[not found] ` <CAHh=Yk86AV542Y7wG6rkHTc4va1Gof3uXtj84zzK5m+khL_Aiw@mail.gmail.com>
2023-04-20 10:46 ` Emil Renner Berthing
2023-04-21 6:16 ` Nylon Chen
2023-04-21 10:09 ` Emil Renner Berthing
2023-04-20 10:28 ` Conor Dooley
2023-04-20 14:13 ` kernel test robot
2023-04-22 13:22 ` kernel test robot
2023-05-08 9:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420-backshift-negotiate-1c3d508582d2@wendy \
--to=conor.dooley@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=geert+renesas@glider.be \
--cc=greentime.hu@sifive.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=nylon.chen@sifive.com \
--cc=nylon7717@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vincent.chen@sifive.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).