From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pwm: ab8500: Fix error code in probe()
Date: Wed, 14 Jun 2023 08:30:31 +0200 [thread overview]
Message-ID: <20230614063031.xnqubkav3ej4fipu@pengutronix.de> (raw)
In-Reply-To: <ffc1e98d-0db4-4b8a-9e49-eb87ef844cbd@kili.mountain>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
Hello Dan,
On Mon, May 22, 2023 at 02:07:42PM +0300, Dan Carpenter wrote:
> This code accidentally return positive EINVAL instead of negative
> -EINVAL.
>
> Fixes: eb41f334589d ("pwm: ab8500: Fix register offset calculation to not depend on probe order")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks!
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-06-14 6:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 11:07 [PATCH] pwm: ab8500: Fix error code in probe() Dan Carpenter
2023-05-22 13:35 ` Linus Walleij
2023-06-14 6:30 ` Uwe Kleine-König [this message]
2023-06-23 14:51 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614063031.xnqubkav3ej4fipu@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).