From: Nikita Shubin <nikita.shubin@maquefel.me>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Arnd Bergmann <arnd@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 36/43] pwm: ep93xx: drop legacy pinctrl
Date: Wed, 17 May 2023 12:29:21 +0300 [thread overview]
Message-ID: <424735804fa1cfabf3b1d76b4b3dd9162f4338a8.camel@maquefel.me> (raw)
In-Reply-To: <20230517061355.5o2ksfkpupsbpuha@pengutronix.de>
Hello Uwe!
On Wed, 2023-05-17 at 08:13 +0200, Uwe Kleine-König wrote:
> Hello Nikita,
>
> On Tue, May 16, 2023 at 01:43:27PM +0300, Nikita Shubin wrote:
> > On Mon, 2023-05-15 at 16:32 +0200, Uwe Kleine-König wrote:
> > > On Mon, Apr 24, 2023 at 03:34:52PM +0300, Nikita Shubin wrote:
> > > > diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-
> > > > ep93xx.c
> > > > index 8bfe6cfbb3db..657adb011aeb 100644
> > > > --- a/drivers/pwm/pwm-ep93xx.c
> > > > +++ b/drivers/pwm/pwm-ep93xx.c
> > > > @@ -45,20 +45,6 @@ static inline struct ep93xx_pwm
> > > > *to_ep93xx_pwm(struct pwm_chip *chip)
> > > > return container_of(chip, struct ep93xx_pwm, chip);
> > > > }
> > > >
> > > > -static int ep93xx_pwm_request(struct pwm_chip *chip, struct
> > > > pwm_device *pwm)
> > > > -{
> > > > - struct platform_device *pdev = to_platform_device(chip-
> > > > > dev);
> > > > -
> > > > - return ep93xx_pwm_acquire_gpio(pdev);
> > >
> > > I didn't get the whole series and didn't spot a relevant followup
> > > change
> >
> > https://lore.kernel.org/all/20230424123522.18302-1-nikita.shubin@maquefel.me/
>
> Yeah, I looked there, but didn't find it. Applied the whole series
> now
> and found "ARM: ep93xx: soc: drop defines". A few things I noticed
> while
> doing so:
>
> - git am warns about new blank lines at EOF in several patches.
>
> - b4 am 20230424123522.18302-1-nikita.shubin@maquefel.me
> warns about broken DKIM signatures. The copy I got directly via Cc
> is
> OK though. The relevant problem is that your To: header is empty
> but
> part of the signed payload + the copy I got via vger.kernel.org
> had
> the To header mangled to
>
> To: unlisted-recipients:; (no To-header on input)
>
> This results in:
>
> $ curl -s
> https://lore.kernel.org/lkml/20230424123522.18302-37-nikita.shubin@maquefel.me/raw
> | dkimverify
> signature verification failed
> $ curl -s
> https://lore.kernel.org/lkml/20230424123522.18302-37-nikita.shubin@maquefel.me/raw
> | sed 's/^To:.*/To:/' | dkimverify
> signature ok
>
> I don't know who is to blame here (i.e. is an empty To allowed?)
> but
> I'd recommend to put the people you want to merge the patches into
> the To header anyhow.
>
> > > on lore.k.o, so: I assume ep93xx_pwm_acquire_gpio() and
> > > ep93xx_pwm_release_gpio() will be unused in the end? Do you drop
> > > them?
> > >
> > > I assume this series target to be taken via arm-soc (once the
> > > review
> > > feedback is positive)?
>
> You didn't reply to that one. Still assuming this to be true, I'll
> mark
> this patch as handled-elsewhere in the PWM patchwork.
Oh sorry about that, yes the current plan is taking the whole series at
once, when acked by.
>
> > > I wonder if this change breaks non-dt machine support?
> >
> > The aim for the whole series is fully converting to dt, this means
> > platform files will be dropped.
> >
> > The v1 series tries not to break anything until platform removal
> > commit, before this commit non-dt version should be compilable and
> > fully functional.
>
> OK, the pwm patch looks fine to me,
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Best regards and thanks for your efforts,
> Uwe
>
next prev parent reply other threads:[~2023-05-17 6:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 12:34 [PATCH 00/43] ep93xx device tree conversion Nikita Shubin
2023-04-24 11:31 ` Arnd Bergmann
[not found] ` <20230424152933.48b2ede1@kernel.org>
2023-04-25 9:20 ` Krzysztof Kozlowski
2023-04-25 13:27 ` Arnd Bergmann
2023-04-24 12:34 ` [PATCH 14/43] dt-bindings: pwm: Add DT bindings ep93xx PWM Nikita Shubin
2023-04-24 16:02 ` Rob Herring
2023-04-24 12:34 ` [PATCH 15/43] pwm: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin
2023-04-24 12:34 ` [PATCH 36/43] pwm: ep93xx: drop legacy pinctrl Nikita Shubin
2023-05-15 14:32 ` Uwe Kleine-König
2023-05-16 10:43 ` Nikita Shubin
2023-05-17 6:13 ` Uwe Kleine-König
2023-05-17 9:29 ` Nikita Shubin [this message]
2023-04-26 20:56 ` [PATCH 00/43] ep93xx device tree conversion Linus Walleij
[not found] ` <b5396ef5-3fed-4e98-8f37-a9cd4473bddc@sirena.org.uk>
2023-04-26 21:06 ` Linus Walleij
2023-05-16 3:47 ` Florian Fainelli
2023-05-16 10:37 ` Nikita Shubin
2023-06-01 5:34 ` [PATCH v1 15/43] dt-bindings: pwm: Add Cirrus EP93xx Nikita Shubin
2023-06-01 5:34 ` [PATCH v1 16/43] pwm: ep93xx: add DT support for " Nikita Shubin
2023-06-01 7:01 ` Uwe Kleine-König
2023-06-01 10:12 ` Nikita Shubin
2023-06-03 20:12 ` andy.shevchenko
2023-06-01 5:45 ` [PATCH v1 37/43] pwm: ep93xx: drop legacy pinctrl Nikita Shubin
2023-06-07 8:05 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=424735804fa1cfabf3b1d76b4b3dd9162f4338a8.camel@maquefel.me \
--to=nikita.shubin@maquefel.me \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).