From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 906F1C4320E for ; Wed, 18 Aug 2021 04:29:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FFE261058 for ; Wed, 18 Aug 2021 04:29:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237316AbhHREaT (ORCPT ); Wed, 18 Aug 2021 00:30:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236690AbhHREaP (ORCPT ); Wed, 18 Aug 2021 00:30:15 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4307BC061764; Tue, 17 Aug 2021 21:29:41 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id n7so2722165ljq.0; Tue, 17 Aug 2021 21:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1oGPCZKuN7//6YRIhZx0/l4kulZ4IgOOJnUbYEMOH6I=; b=V5kVQiJtWOCCp57EmiLvG7lU7Eb4Pzk32zmECjGfUZe6WpjBhCOxyJxa3BJEPwWMQL YODIIG0AfBa0AUaKsgX9TTGS98k2By1GeZoFn38hvGsENacTswgcd9UWoRbXdcopoBne sb3uVBZSitgvH5I2PuygucyxoSig5hBa9YfcBzRQREAP0Q0aEozhok3Fzl9Jnhf7BYKe 8Szm/avAy2CyuGWJgmVVdv21+M3huLPr7UTBxs1Esv1JV71R127gQOsjyI3lC+8wggh2 1bdKBcLFz2RhSs2A6jFav8nPUJAxIitDUeBO7TFOJsdfbDPbbNOZfFUBrMVBZLlNqfnp ov8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1oGPCZKuN7//6YRIhZx0/l4kulZ4IgOOJnUbYEMOH6I=; b=p4aOWwZfHB4Uk7m+lyCSixwFETeYOUTYsWYjPsVaR4C5E7bg+VwYQaVQuM6bFjC6Nd HWe+TAzjgnORUSOf+fN4RI/cjNMNajCc80fkUlSFbQFRSQqDFSt+O6X7/xzyuLATqL2u FBbvLVZwoTugFs4dHj/XmklQPD1XwcmtsKcanDv/6Kjuo6/WG8uciZE1i7QtwLDBA8ui A+XbNDiUCY9C6hL4y0nEvfkehXqZ2wkQdP8w5bxanPvefcsUVfMFQTe+TxdELENC6Nmk 8Nce62ZZhjU7szxUuVPX5gKLuY4SBKIXFWrmhxnmgq102neSuygnPdur4lwx/PXJyVAr TzNg== X-Gm-Message-State: AOAM532MexhPucXexJcw1yEp9Dt/xHCTlKcWfloiHKFIhRpalVHrWHLM 0+PGFZ/jlJitLViJIi6L0Y9Nr8R/sjI= X-Google-Smtp-Source: ABdhPJxjWHu+1mhjN7xsUMJQm6f2OEtCQsnZGvTaLckFV9kcxoy2/qKkU641V0QwrRxZ9lvcjAC7rA== X-Received: by 2002:a05:651c:390:: with SMTP id e16mr6391418ljp.344.1629260979533; Tue, 17 Aug 2021 21:29:39 -0700 (PDT) Received: from [192.168.2.145] (46-138-85-91.dynamic.spd-mgts.ru. [46.138.85.91]) by smtp.googlemail.com with ESMTPSA id f1sm381628lfs.44.2021.08.17.21.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 21:29:39 -0700 (PDT) Subject: Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper From: Dmitry Osipenko To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Ulf Hansson , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Mark Brown , Lee Jones , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Nishanth Menon , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Adrian Hunter , Mauro Carvalho Chehab , Rob Herring , Michael Turquette , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-staging@lists.linux.dev, linux-spi@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mtd@lists.infradead.org, linux-mmc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org References: <20210817012754.8710-1-digetx@gmail.com> <20210817012754.8710-2-digetx@gmail.com> <20210817075515.vyyv7z37e6jcrhsl@vireshk-i7> <710261d9-7ae3-5155-c0a2-f8aed2408d0b@gmail.com> <20210818035533.ieqkexltfvvf2p4n@vireshk-i7> <5b2a80c1-9743-e633-6257-ede94c8a274c@gmail.com> Message-ID: <6df0ed60-e497-0af2-09b6-a9d82f502f17@gmail.com> Date: Wed, 18 Aug 2021 07:29:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <5b2a80c1-9743-e633-6257-ede94c8a274c@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org 18.08.2021 07:12, Dmitry Osipenko пишет: > 18.08.2021 06:55, Viresh Kumar пишет: >> On 17-08-21, 18:49, Dmitry Osipenko wrote: >>> 17.08.2021 10:55, Viresh Kumar пишет: >>> ... >>>>> +int dev_pm_opp_sync(struct device *dev) >>>>> +{ >>>>> + struct opp_table *opp_table; >>>>> + struct dev_pm_opp *opp; >>>>> + int ret = 0; >>>>> + >>>>> + /* Device may not have OPP table */ >>>>> + opp_table = _find_opp_table(dev); >>>>> + if (IS_ERR(opp_table)) >>>>> + return 0; >>>>> + >>>>> + if (!_get_opp_count(opp_table)) >>>>> + goto put_table; >>>>> + >>>>> + opp = _find_current_opp(dev, opp_table); >>>>> + ret = _set_opp(dev, opp_table, opp, opp->rate); >>>> >>>> And I am not sure how this will end up working, since new OPP will be >>>> equal to old one. Since I see you call this from resume() at many >>>> places. >>> >>> Initially OPP table is "uninitialized" and opp_table->enabled=false, >>> hence the first sync always works even if OPP is equal to old one. Once >>> OPP has been synced, all further syncs are NO-OPs, hence it doesn't >>> matter how many times syncing is called. >>> >>> https://elixir.bootlin.com/linux/v5.14-rc6/source/drivers/opp/core.c#L1012 >> >> Right, but how will this work from Resume ? Won't that be a no-op ? > > The first resume initializes the OPP state on sync, all further syncs on > resume are no-ops. > Notice that we use GENPD here. GENPD core takes care of storing PD's performance state (voltage in case of Tegra) and dropping it to 0 after rpm-suspend, GENPD core also restores the state before rpm-resume.