From: Simon South <simon@simonsouth.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, heiko@sntech.de,
bbrezillon@kernel.org, linux-rockchip@lists.infradead.org,
thierry.reding@gmail.com, tpiepho@gmail.com,
lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] pwm: rockchip: Do not start PWMs not already running
Date: Tue, 22 Dec 2020 11:32:29 -0500 [thread overview]
Message-ID: <871rfhreci.fsf@simonsouth.net> (raw)
In-Reply-To: <20201221090553.bopd2aaoheapww3r@pengutronix.de> ("Uwe =?utf-8?Q?Kleine-K=C3=B6nig=22's?= message of "Mon, 21 Dec 2020 10:05:53 +0100")
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
> "starting PWM" here means enabling their clocks, right? I wouldn't
> expect that this has any effect on the output, am I right?
Right, it does not; another misunderstanding on my part. I'll fix the
commit message.
> Just for my understanding: That you moved clk_prepare_enable(pc->pclk)
> further down is not strictly necessary for your change, right?
That's right. My thought was to keep the code that enables this clock
close to the code that relies on it, and to minimize the duration the
clock is enabled.
Would it be better to leave the code where it is?
> I'm not a big fan of this ?: construct...
Neither was I, actually, but I guessed the shorter version would be
preferred. I'm happy to change it back to match what you described.
--
Simon South
simon@simonsouth.net
next prev parent reply other threads:[~2020-12-22 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 20:44 [PATCH v2 0/3] pwm: rockchip: Eliminate potential race condition when probing Simon South
2020-12-19 20:44 ` [PATCH v2 1/3] pwm: rockchip: Enable APB clock during register access while probing Simon South
2020-12-21 8:22 ` Uwe Kleine-König
2020-12-19 20:44 ` [PATCH v2 2/3] pwm: rockchip: Eliminate potential race condition when probing Simon South
2020-12-21 8:50 ` Uwe Kleine-König
2020-12-22 16:26 ` Simon South
2020-12-19 20:44 ` [PATCH v2 3/3] pwm: rockchip: Do not start PWMs not already running Simon South
2020-12-21 9:05 ` Uwe Kleine-König
2020-12-22 16:32 ` Simon South [this message]
2020-12-22 17:23 ` Robin Murphy
2020-12-22 17:43 ` Simon South
2020-12-21 9:16 ` [PATCH v2 0/3] pwm: rockchip: Eliminate potential race condition when probing Uwe Kleine-König
2020-12-22 16:34 ` Simon South
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rfhreci.fsf@simonsouth.net \
--to=simon@simonsouth.net \
--cc=bbrezillon@kernel.org \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=thierry.reding@gmail.com \
--cc=tpiepho@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).