From: Baruch Siach <baruch@tkos.co.il>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
linux-pwm@vger.kernel.org,
"Gregory Clement" <gregory.clement@bootlin.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
"Chris Packham" <chris.packham@alliedtelesis.co.nz>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Ralph Sennhauser" <ralph.sennhauser@gmail.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v4 0/3] gpio: mvebu: Armada 8K/7K PWM support
Date: Mon, 04 Jan 2021 12:12:04 +0200 [thread overview]
Message-ID: <87mtxp9fkb.fsf@tarshish> (raw)
In-Reply-To: <20210104092449.GA1551@shell.armlinux.org.uk>
Hi Russell,
On Mon, Jan 04 2021, Russell King - ARM Linux admin wrote:
> On Thu, Dec 10, 2020 at 02:15:57PM +0200, Baruch Siach wrote:
>> This series makes two changes to v3:
>>
>> * Remove patches that are in LinusW linux-gpio for-next and fixes
>>
>> * Rename the 'pwm-offset' property to 'marvell,pwm-offset' as suggested by
>> Rob Herring
>>
>> The original cover letter follows (with DT property name updated).
>>
>> The gpio-mvebu driver supports the PWM functionality of the GPIO block for
>> earlier Armada variants like XP, 370 and 38x. This series extends support to
>> newer Armada variants that use CP11x and AP80x, like Armada 8K and 7K.
>>
>> This series adds adds the 'marvell,pwm-offset' property to DT binding.
>> 'marvell,pwm-offset' points to the base of A/B counter registers that
>> determine the PWM period and duty cycle.
>>
>> The existing PWM DT binding reflects an arbitrary decision to allocate the A
>> counter to the first GPIO block, and B counter to the other one. In attempt to
>> provide better future flexibility, the new 'marvell,pwm-offset' property
>> always points to the base address of both A/B counters. The driver code still
>> allocates the counters in the same way, but this might change in the future
>> with no change to the DT.
>>
>> Tested AP806 and CP110 (both) on Armada 8040 based system.
>
> Did you see the patches I sent during the last year doing this and
> adding support for the fan on the GT-8k?
You refer to the series linked below, right?
https://lore.kernel.org/linux-pwm/20200329104549.GX25745@shell.armlinux.org.uk/
(For some reason the LAKM archive is missing two years, including this
time frame)
I now remember that series. I even archived it locally. But then I
forgot about it, so I ended up recreating Armada 8K PWM support from
scratch. Sorry about that.
Any comment on this series?
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
prev parent reply other threads:[~2021-01-04 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 12:15 [PATCH v4 0/3] gpio: mvebu: Armada 8K/7K PWM support Baruch Siach
2020-12-10 12:15 ` [PATCH v4 1/3] gpio: mvebu: add pwm support for Armada 8K/7K Baruch Siach
2021-01-04 10:06 ` Russell King - ARM Linux admin
2020-12-10 12:15 ` [PATCH v4 2/3] arm64: dts: armada: add pwm offsets for ap/cp gpios Baruch Siach
2020-12-10 12:16 ` [PATCH v4 3/3] dt-bindings: ap806: document marvell,gpio pwm-offset property Baruch Siach
2020-12-11 3:47 ` [PATCH v4 3/3] dt-bindings: ap806: document marvell, gpio " Rob Herring
2021-01-04 8:59 ` [PATCH v4 0/3] gpio: mvebu: Armada 8K/7K PWM support Linus Walleij
2021-01-04 9:43 ` Baruch Siach
2021-01-04 9:52 ` Bartosz Golaszewski
2021-01-04 9:24 ` Russell King - ARM Linux admin
2021-01-04 10:12 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtxp9fkb.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ralph.sennhauser@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).