* Re: [PATCH 21/21] panel: startek-kd070fhfid015: add support of this display
[not found] ` <20230220-display-v1-21-45cbc68e188b@baylibre.com>
@ 2023-03-09 14:51 ` Neil Armstrong
2023-03-15 15:59 ` Alexandre Mergnat
0 siblings, 1 reply; 36+ messages in thread
From: Neil Armstrong @ 2023-03-09 14:51 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, linux-pwm, devicetree, linux-kernel
Hi,
On 09/03/2023 15:23, Alexandre Mergnat wrote:
> From: Guillaume La Roque <glaroque@baylibre.com>
>
> This driver support the Startek KD070FHFID015, which is a 7-inch TFT LCD
> display using MIPI DSI interface.
>
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> drivers/gpu/drm/panel/Kconfig | 12 +
> drivers/gpu/drm/panel/Makefile | 1 +
> .../gpu/drm/panel/panel-startek-kd070fhfid015.c | 483 +++++++++++++++++++++
> 3 files changed, 496 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 737edcdf9eef..3fccf025013b 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -666,6 +666,17 @@ config DRM_PANEL_SONY_TULIP_TRULY_NT35521
> NT35521 1280x720 video mode panel as found on Sony Xperia M4
> Aqua phone.
>
> +config DRM_PANEL_STARTEK_KD070FHFID015
> + tristate "STARTEK KD070FHFID015 panel"
> + depends on OF
> + depends on DRM_MIPI_DSI
> + depends on BACKLIGHT_CLASS_DEVICE
> + help
> + Say Y here if you want to enable support for STARTEK KD070FHFID015 DSI panel
> + based on RENESAS-R69429 controller. The pannel is a 7-inch TFT LCD display
> + with a resolution of 1024 x 600 pixels. It provides a MIPI DSI interface to
> + the host, a built-in LED backlight and touch controller.
> +
> config DRM_PANEL_TDO_TL070WSH30
> tristate "TDO TL070WSH30 DSI panel"
> depends on OF
> @@ -736,4 +747,5 @@ config DRM_PANEL_XINPENG_XPP055C272
> Say Y here if you want to enable support for the Xinpeng
> XPP055C272 controller for 720x1280 LCD panels with MIPI/RGB/SPI
> system interfaces.
> +
Spurious new line
> endmenu
> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
> index f8f9d9f6a307..35771fc51187 100644
> --- a/drivers/gpu/drm/panel/Makefile
> +++ b/drivers/gpu/drm/panel/Makefile
> @@ -67,6 +67,7 @@ obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o
> obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o
> obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o
> obj-$(CONFIG_DRM_PANEL_SONY_TULIP_TRULY_NT35521) += panel-sony-tulip-truly-nt35521.o
> +obj-$(CONFIG_DRM_PANEL_STARTEK_KD070FHFID015) += panel-startek-kd070fhfid015.o
> obj-$(CONFIG_DRM_PANEL_TDO_TL070WSH30) += panel-tdo-tl070wsh30.o
> obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o
> obj-$(CONFIG_DRM_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o
> diff --git a/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c b/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c
> new file mode 100644
> index 000000000000..88466bf6428d
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c
> @@ -0,0 +1,483 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2016 InforceComputing
> + * Copyright (C) 2016 Linaro Ltd
> + * Copyright (C) 2023 BayLibre, SAS
> + *
> + * Author:
NIT: Authors
> + * - Vinay Simha BN <simhavcs@gmail.com>
> + * - Sumit Semwal <sumit.semwal@linaro.org>
> + * - Guillaume La Roque <glaroque@baylibre.com>
> + *
> + */
> +
> +#include <linux/backlight.h>
> +#include <linux/delay.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/regulator/consumer.h>
> +
> +#include <video/mipi_display.h>
> +
> +#include <drm/drm_crtc.h>
Is this include needed ?
> +#include <drm/drm_mipi_dsi.h>
> +#include <drm/drm_modes.h>
> +#include <drm/drm_panel.h>
> +
> +#define DSI_REG_MCAP 0xB0
> +#define DSI_REG_IS 0xB3 /* Interface Setting */
> +#define DSI_REG_IIS 0xB4 /* Interface ID Setting */
> +#define DSI_REG_CTRL 0xB6
> +
> +struct stk_panel {
> + struct drm_panel base;
> + struct mipi_dsi_device *dsi;
> +
> + struct gpio_desc *enable_gpio;
> + struct gpio_desc *reset_gpio;
> + struct gpio_desc *dcdc_en_gpio;
Isn't this "DCDC" a regulator ???
> + struct backlight_device *backlight;
> + struct regulator *iovcc_supply;
> + struct regulator *power_supply;
> +
> + bool prepared;
> + bool enabled;
> +
> + const struct drm_display_mode *mode;
> +};
> +
> +static inline struct stk_panel *to_stk_panel(struct drm_panel *panel)
> +{
> + return container_of(panel, struct stk_panel, base);
> +}
> +
> +static int stk_panel_init(struct stk_panel *stk)
> +{
> + struct mipi_dsi_device *dsi = stk->dsi;
> + struct device *dev = &stk->dsi->dev;
> + int ret;
> +
> + ret = mipi_dsi_dcs_soft_reset(dsi);
> + if (ret < 0) {
> + dev_err(dev, "failed to mipi_dsi_dcs_soft_reset: %d\n", ret);
> + return ret;
> + }
> + mdelay(5);
> +
> + ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> + if (ret < 0) {
> + dev_err(dev, "failed to set exit sleep mode: %d\n", ret);
> + return ret;
> + }
> + msleep(120);
> +
> + ret = mipi_dsi_generic_write(dsi, (u8[]){DSI_REG_MCAP, 0x04}, 2);
> + if (ret < 0) {
> + dev_err(dev, "failed to set mcap: %d\n", ret);
> + return ret;
> + }
> + /* Interface setting, video mode */
> + ret = mipi_dsi_generic_write(dsi,
> + (u8[]){DSI_REG_IS, 0x14, 0x08, 0x00, 0x22, 0x00}, 6);
> + if (ret < 0) {
> + dev_err(dev, "failed to set display interface setting: %d\n",
> + ret);
> + return ret;
> + }
Use mipi_dsi_generic_write_seq(dsi, DSI_REG_IS, 0x14, 0x08, 0x00, 0x22, 0x00); instead,
it's simpler and doesn't need explicit return check.
> +
> + ret = mipi_dsi_generic_write(dsi, (u8[]){DSI_REG_IIS, 0x0C, 0x00}, 3);
> + if (ret < 0) {
> + dev_err(dev, "failed to set Interface ID setting: %d\n", ret);
> + return ret;
> + }
> +
> + ret = mipi_dsi_generic_write(dsi, (u8[]){ DSI_REG_CTRL, 0x3A, 0xD3}, 3);
> + if (ret < 0) {
> + dev_err(dev, "failed to set DSI control: %d\n", ret);
> + return ret;
> + }
> +
> + ret = mipi_dsi_dcs_set_display_brightness(dsi, 0x77);
> + if (ret < 0) {
> + dev_err(dev, "failed to write display brightness: %d\n", ret);
> + return ret;
> + }
> +
> + ret = mipi_dsi_dcs_write(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY,
> + (u8[]){ MIPI_DCS_WRITE_MEMORY_START }, 1);
> + if (ret < 0) {
> + dev_err(dev, "failed to write control display: %d\n", ret);
> + return ret;
> + }
> +
> + ret = mipi_dsi_dcs_set_pixel_format(dsi, 0x77);
> + if (ret < 0) {
> + dev_err(dev, "failed to set pixel format: %d\n", ret);
> + return ret;
> + }
> +
> + ret = mipi_dsi_dcs_set_column_address(dsi, 0, stk->mode->hdisplay - 1);
> + if (ret < 0) {
> + dev_err(dev, "failed to set column address: %d\n", ret);
> + return ret;
> + }
> +
> + ret = mipi_dsi_dcs_set_page_address(dsi, 0, stk->mode->vdisplay - 1);
> + if (ret < 0) {
> + dev_err(dev, "failed to set page address: %d\n", ret);
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int stk_panel_on(struct stk_panel *stk)
> +{
> + struct mipi_dsi_device *dsi = stk->dsi;
> + struct device *dev = &stk->dsi->dev;
> + int ret;
> +
> + ret = mipi_dsi_dcs_set_display_on(dsi);
> + if (ret < 0)
> + dev_err(dev, "failed to set display on: %d\n", ret);
> +
> + mdelay(20);
> +
> + return ret;
> +}
> +
> +static void stk_panel_off(struct stk_panel *stk)
> +{
> + struct mipi_dsi_device *dsi = stk->dsi;
> + struct device *dev = &stk->dsi->dev;
> + int ret;
> +
> + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
> +
> + ret = mipi_dsi_dcs_set_display_off(dsi);
> + if (ret < 0)
> + dev_err(dev, "failed to set display off: %d\n", ret);
> +
> + ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
> + if (ret < 0)
> + dev_err(dev, "failed to enter sleep mode: %d\n", ret);
> +
> + msleep(100);
> +}
> +
> +static int stk_panel_disable(struct drm_panel *panel)
> +{
> + struct stk_panel *stk = to_stk_panel(panel);
> +
> + if (!stk->enabled)
> + return 0;
> +
> + backlight_disable(stk->backlight);
> +
> + stk->enabled = false;
> +
> + return 0;
> +}
> +
> +static int stk_panel_unprepare(struct drm_panel *panel)
> +{
> + struct stk_panel *stk = to_stk_panel(panel);
> +
> + if (!stk->prepared)
> + return 0;
> +
> + stk_panel_off(stk);
> + regulator_disable(stk->iovcc_supply);
> + regulator_disable(stk->power_supply);
> + gpiod_set_value(stk->reset_gpio, 0);
> + gpiod_set_value(stk->dcdc_en_gpio, 1);
> +
> + stk->prepared = false;
> +
> + return 0;
> +}
> +
> +static int stk_panel_prepare(struct drm_panel *panel)
> +{
> + struct stk_panel *stk = to_stk_panel(panel);
> + struct device *dev = &stk->dsi->dev;
> + int ret;
> +
> + if (stk->prepared)
> + return 0;
> +
> + gpiod_set_value(stk->reset_gpio, 0);
> + gpiod_set_value(stk->dcdc_en_gpio, 0);
> + gpiod_set_value(stk->enable_gpio, 0);
> + ret = regulator_enable(stk->iovcc_supply);
> + if (ret < 0)
> + return ret;
> + mdelay(8);
> + ret = regulator_enable(stk->power_supply);
> + if (ret < 0)
> + goto iovccoff;
Add blank lines between code blocks for readability
> + mdelay(20);
> + gpiod_set_value(stk->dcdc_en_gpio, 1);
> + mdelay(20);
> + gpiod_set_value(stk->reset_gpio, 1);
> + mdelay(10);
> +
> + ret = stk_panel_init(stk);
> + if (ret < 0) {
> + dev_err(dev, "failed to init panel: %d\n", ret);
> + goto poweroff;
> + }
> +
> + ret = stk_panel_on(stk);
> + if (ret < 0) {
> + dev_err(dev, "failed to set panel on: %d\n", ret);
> + goto poweroff;
> + }
> +
> + stk->prepared = true;
> +
> + return 0;
> +
> +poweroff:
> + regulator_disable(stk->power_supply);
> +iovccoff:
> + regulator_disable(stk->iovcc_supply);
> + gpiod_set_value(stk->enable_gpio, 0);
> + gpiod_set_value(stk->reset_gpio, 0);
> + gpiod_set_value(stk->dcdc_en_gpio, 0);
> +
> + return ret;
> +}
> +
> +static int stk_panel_enable(struct drm_panel *panel)
> +{
> + struct stk_panel *stk = to_stk_panel(panel);
> +
> + if (stk->enabled)
> + return 0;
> +
> + backlight_enable(stk->backlight);
> +
> + stk->enabled = true;
> +
> + return 0;
> +}
Is this really needed ? the backlight core will enable it automatically.
> +
> +static const struct drm_display_mode default_mode = {
> + .clock = 163204,
> + .hdisplay = 1200,
> + .hsync_start = 1200 + 144,
> + .hsync_end = 1200 + 144 + 16,
> + .htotal = 1200 + 144 + 16 + 45, // 1405
No need for the comment
> + .vdisplay = 1920,
> + .vsync_start = 1920 + 8,
> + .vsync_end = 1920 + 8 + 4,
> + .vtotal = 1920 + 8 + 4 + 4, // 1936
You can also set .width_mm & .height_mm and copy them to connector->display_info later.
> +};
> +
> +static int stk_panel_get_modes(struct drm_panel *panel,
> + struct drm_connector *connector)
> +{
> + struct drm_display_mode *mode;
> +
> + mode = drm_mode_duplicate(connector->dev, &default_mode);
> + if (!mode) {
> + dev_err(panel->dev, "failed to add mode %ux%ux@%u\n",
> + default_mode.hdisplay, default_mode.vdisplay,
> + drm_mode_vrefresh(&default_mode));
> + return -ENOMEM;
> + }
> +
> + drm_mode_set_name(mode);
> +
> + drm_mode_probed_add(connector, mode);
> +
> + connector->display_info.width_mm = 95;
> + connector->display_info.height_mm = 151;
> +
> + return 1;
> +}
> +
> +static int dsi_dcs_bl_get_brightness(struct backlight_device *bl)
> +{
> + struct mipi_dsi_device *dsi = bl_get_data(bl);
> + int ret;
> + u16 brightness = bl->props.brightness;
> +
> + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
> +
> + ret = mipi_dsi_dcs_get_display_brightness(dsi, &brightness);
> + if (ret < 0)
> + return ret;
> + dsi->mode_flags |= MIPI_DSI_MODE_LPM;
> +
> + return brightness & 0xff;
> +}
> +
> +static int dsi_dcs_bl_update_status(struct backlight_device *bl)
> +{
> + struct mipi_dsi_device *dsi = bl_get_data(bl);
> + struct device *dev = &dsi->dev;
> + int ret;
> +
> + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
> +
> + ret = mipi_dsi_dcs_set_display_brightness(dsi, bl->props.brightness);
> + if (ret < 0) {
> + dev_err(dev, "failed to set DSI control: %d\n", ret);
> + return ret;
> + }
> +
> + dsi->mode_flags |= MIPI_DSI_MODE_LPM;
> +
> + return 0;
> +}
> +
> +static const struct backlight_ops dsi_bl_ops = {
> + .update_status = dsi_dcs_bl_update_status,
> + .get_brightness = dsi_dcs_bl_get_brightness,
> +};
> +
> +static struct backlight_device *
> +drm_panel_create_dsi_backlight(struct mipi_dsi_device *dsi)
> +{
> + struct device *dev = &dsi->dev;
> + struct backlight_properties props;
> +
> + memset(&props, 0, sizeof(props));
> + props.type = BACKLIGHT_RAW;
> + props.brightness = 255;
> + props.max_brightness = 255;
You could write :
struct backlight_properties props = {
.type = BACKLIGHT_RAW,
.brightness = 255,
.max_brightness = 255,
};
> +
> + return devm_backlight_device_register(dev, dev_name(dev), dev, dsi,
> + &dsi_bl_ops, &props);
> +}
> +
> +static const struct drm_panel_funcs stk_panel_funcs = {
> + .disable = stk_panel_disable,
> + .unprepare = stk_panel_unprepare,
> + .prepare = stk_panel_prepare,
> + .enable = stk_panel_enable,
> + .get_modes = stk_panel_get_modes,
> +};
> +
> +static const struct of_device_id stk_of_match[] = {
> + { .compatible = "startek,kd070fhfid015", },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, stk_of_match);
> +
> +static int stk_panel_add(struct stk_panel *stk)
> +{
> + struct device *dev = &stk->dsi->dev;
> + int ret;
> +
> + stk->mode = &default_mode;
> +
> + stk->iovcc_supply = devm_regulator_get(dev, "iovcc");
> + if (IS_ERR(stk->iovcc_supply))
> + return PTR_ERR(stk->iovcc_supply);
> +
> + stk->power_supply = devm_regulator_get(dev, "power");
> + if (IS_ERR(stk->power_supply))
> + return PTR_ERR(stk->power_supply);
You can switch to devm_regulator_bulk_get() to simplify code.
> +
> + stk->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> + if (IS_ERR(stk->reset_gpio)) {
> + ret = PTR_ERR(stk->reset_gpio);
> + dev_err(dev, "cannot get reset-gpios %d\n", ret);
> + return ret;
> + }
> +
> + stk->dcdc_en_gpio = devm_gpiod_get(dev, "dcdc", GPIOD_OUT_LOW);
> + if (IS_ERR(stk->dcdc_en_gpio)) {
> + ret = PTR_ERR(stk->dcdc_en_gpio);
> + dev_err(dev, "cannot get dcdc-en-gpio %d\n", ret);
> + return ret;
> + }
> +
> + stk->backlight = drm_panel_create_dsi_backlight(stk->dsi);
> + if (IS_ERR(stk->backlight)) {
> + ret = PTR_ERR(stk->backlight);
> + dev_err(dev, "failed to register backlight %d\n", ret);
> + return ret;
> + }
> +
> + drm_panel_init(&stk->base, &stk->dsi->dev, &stk_panel_funcs,
> + DRM_MODE_CONNECTOR_DSI);
> +
> + drm_panel_add(&stk->base);
> +
> + return 0;
> +}
> +
> +static void stk_panel_del(struct stk_panel *stk)
> +{
> + if (stk->base.dev)
> + drm_panel_remove(&stk->base);
Is the if() necessary ? Not sure, you can remove it and directly call drm_panel_remove(&stk->base);
> +}
> +
> +static int stk_panel_probe(struct mipi_dsi_device *dsi)
> +{
> + struct stk_panel *stk;
> + int ret;
> +
> + dsi->lanes = 4;
> + dsi->format = MIPI_DSI_FMT_RGB888;
> + dsi->mode_flags = (MIPI_DSI_MODE_VIDEO |
> + MIPI_DSI_MODE_LPM);
This could be on a single line
> +
> + stk = devm_kzalloc(&dsi->dev, sizeof(*stk), GFP_KERNEL);
> + if (!stk)
> + return -ENOMEM;
> +
> + mipi_dsi_set_drvdata(dsi, stk);
> +
> + stk->dsi = dsi;
> +
> + ret = stk_panel_add(stk);
> + if (ret < 0)
> + return ret;
> +
> + return mipi_dsi_attach(dsi);
You should call drm_panel_remove() if attach fails
> +}
> +
> +static void stk_panel_remove(struct mipi_dsi_device *dsi)
> +{
> + struct stk_panel *stk = mipi_dsi_get_drvdata(dsi);
> + int err;
> +
> + err = stk_panel_disable(&stk->base);
> + if (err < 0)
> + dev_err(&dsi->dev, "failed to disable panel: %d\n", err) > +
> + err = mipi_dsi_detach(dsi);
> + if (err < 0)
> + dev_err(&dsi->dev, "failed to detach from DSI host: %d\n",
> + err);
> +
> + stk_panel_del(stk);
Move the content of stk_panel_del() here, no need for a separate function.
> +}
> +
> +static void stk_panel_shutdown(struct mipi_dsi_device *dsi)
> +{
> + struct stk_panel *stk = mipi_dsi_get_drvdata(dsi);
> +
> + stk_panel_disable(&stk->base);
> +}
> +
> +static struct mipi_dsi_driver stk_panel_driver = {
> + .driver = {
> + .name = "panel-startek-kd070fhfid015",
> + .of_match_table = stk_of_match,
> + },
> + .probe = stk_panel_probe,
> + .remove = stk_panel_remove,
> + .shutdown = stk_panel_shutdown,
> +};
> +module_mipi_dsi_driver(stk_panel_driver);
> +
> +MODULE_AUTHOR("Guillaume La Roque <glaroque@baylibre.com>");
> +MODULE_DESCRIPTION("STARTEK KD070FHFID015");
> +MODULE_LICENSE("GPL");
>
Thanks,
Neil
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 02/21] dt-bindings: display: mediatek: ccorr: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-2-45cbc68e188b@baylibre.com>
@ 2023-03-10 8:29 ` Krzysztof Kozlowski
2023-03-13 14:54 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 8:29 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:22, Alexandre Mergnat wrote:
> Display Color Correction for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 03/21] dt-bindings: display: mediatek: color: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-3-45cbc68e188b@baylibre.com>
@ 2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-13 14:58 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 8:35 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:22, Alexandre Mergnat wrote:
> Display Color for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 04/21] dt-bindings: display: mediatek: dither: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-4-45cbc68e188b@baylibre.com>
@ 2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-13 14:59 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 8:35 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:22, Alexandre Mergnat wrote:
> Display Dither for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 05/21] dt-bindings: display: mediatek: dsi: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-5-45cbc68e188b@baylibre.com>
@ 2023-03-10 8:35 ` Krzysztof Kozlowski
2023-03-13 15:00 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 8:35 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:22, Alexandre Mergnat wrote:
> Display Serial Interface for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> .../bindings/display/mediatek/mediatek,dsi.yaml | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365
[not found] ` <20230220-display-v1-7-45cbc68e188b@baylibre.com>
@ 2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-13 15:17 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 8:38 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:22, Alexandre Mergnat wrote:
> From: Fabien Parent <fparent@baylibre.com>
>
> DPI for MT8365 is compatible with MT8192 but requires an additional
> clock. Modify the documentation to requires this clock only on MT8365 SoCs.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> .../bindings/display/mediatek/mediatek,dpi.yaml | 48 ++++++++++++++++++----
> 1 file changed, 39 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> index 56511c4d4b9b..3f6cca81340c 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> @@ -17,15 +17,20 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - mediatek,mt2701-dpi
> - - mediatek,mt7623-dpi
> - - mediatek,mt8173-dpi
> - - mediatek,mt8183-dpi
> - - mediatek,mt8186-dpi
> - - mediatek,mt8188-dp-intf
> - - mediatek,mt8192-dpi
> - - mediatek,mt8195-dp-intf
> + oneOf:
> + - enum:
> + - mediatek,mt2701-dpi
> + - mediatek,mt7623-dpi
> + - mediatek,mt8173-dpi
> + - mediatek,mt8183-dpi
> + - mediatek,mt8186-dpi
> + - mediatek,mt8188-dp-intf
> + - mediatek,mt8192-dpi
> + - mediatek,mt8195-dp-intf
> + - items:
> + - enum:
> + - mediatek,mt8365-dpi
> + - const: mediatek,mt8192-dpi
>
> reg:
> maxItems: 1
> @@ -34,16 +39,20 @@ properties:
> maxItems: 1
>
> clocks:
> + minItems: 3
> items:
> - description: Pixel Clock
> - description: Engine Clock
> - description: DPI PLL
> + - description: DPI Clock
>
> clock-names:
> + minItems: 3
> items:
> - const: pixel
> - const: engine
> - const: pll
> + - const: dpi
>
> pinctrl-0: true
> pinctrl-1: true
> @@ -72,6 +81,27 @@ required:
>
> additionalProperties: false
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8365-dpi
> +
> + then:
> + properties:
> + clocks:
> + maxItems: 4
We usually set minItems, so it is clear readable that you raise the
lower bracket. Code should be equivalent, but I would say this is less
readable (maxItems: 4 was actually implied by top-level list).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 08/21] dt-bindings: display: mediatek: gamma: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-8-45cbc68e188b@baylibre.com>
@ 2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-13 15:07 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 8:38 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:22, Alexandre Mergnat wrote:
> Display GAMMA for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 09/21] dt-bindings: display: mediatek: ovl: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-9-45cbc68e188b@baylibre.com>
@ 2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-13 15:08 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 8:38 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:22, Alexandre Mergnat wrote:
> Display Overlay for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8192 SoC.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 10/21] dt-bindings: display: mediatek: rdma: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-10-45cbc68e188b@baylibre.com>
@ 2023-03-10 8:38 ` Krzysztof Kozlowski
2023-03-13 15:09 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 8:38 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:22, Alexandre Mergnat wrote:
> Display Data Path Read DMA for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 13/21] dt-bindings: pwm: add binding for mt8365 SoC
[not found] ` <20230220-display-v1-13-45cbc68e188b@baylibre.com>
@ 2023-03-10 8:38 ` Krzysztof Kozlowski
0 siblings, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 8:38 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:23, Alexandre Mergnat wrote:
> Display PWM for MT8365 is compatible with MT8183. Then, add MT8365 binding
> along with MT8183 SoC.
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC
[not found] ` <20230220-display-v1-15-45cbc68e188b@baylibre.com>
@ 2023-03-10 8:39 ` Krzysztof Kozlowski
2023-03-15 8:01 ` Alexandre Mergnat
2023-03-15 13:22 ` Krzysztof Kozlowski
2023-03-31 17:51 ` Matthias Brugger
2 siblings, 1 reply; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 8:39 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:23, Alexandre Mergnat wrote:
> Add compatible for the MT8365 SoC.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> index ca0ca549257d..931d66893dff 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> @@ -34,6 +34,7 @@ properties:
> - mediatek,mt8186-mdp3-mutex
> - mediatek,mt8192-disp-mutex
> - mediatek,mt8195-disp-mutex
> + - mediatek,mt8365-disp-mutex
All these look compatible. Either make mt8635 compatible with something
or even rework entire list and make everything compatible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 01/21] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-1-45cbc68e188b@baylibre.com>
@ 2023-03-10 8:41 ` Krzysztof Kozlowski
2023-03-13 15:02 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-10 8:41 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:22, Alexandre Mergnat wrote:
> Display Adaptive Ambient Light for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 02/21] dt-bindings: display: mediatek: ccorr: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-2-45cbc68e188b@baylibre.com>
2023-03-10 8:29 ` [PATCH 02/21] dt-bindings: display: mediatek: ccorr: add binding for MT8365 SoC Krzysztof Kozlowski
@ 2023-03-13 14:54 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-13 14:54 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi, Alexandre:
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>
> Display Color Correction for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> index 63fb02014a56..fc999e614718 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> @@ -32,6 +32,7 @@ properties:
> - items:
> - enum:
> - mediatek,mt8186-disp-ccorr
> + - mediatek,mt8365-disp-ccorr
> - const: mediatek,mt8183-disp-ccorr
>
> reg:
>
> --
> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 03/21] dt-bindings: display: mediatek: color: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-3-45cbc68e188b@baylibre.com>
2023-03-10 8:35 ` [PATCH 03/21] dt-bindings: display: mediatek: color: " Krzysztof Kozlowski
@ 2023-03-13 14:58 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-13 14:58 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi, Alexandre:
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>
> Display Color for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> index d2f89ee7996f..9d081da433e8 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml
> @@ -39,6 +39,7 @@ properties:
> - mediatek,mt8186-disp-color
> - mediatek,mt8192-disp-color
> - mediatek,mt8195-disp-color
> + - mediatek,mt8365-disp-color
> - const: mediatek,mt8173-disp-color
> reg:
> maxItems: 1
>
> --
> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 04/21] dt-bindings: display: mediatek: dither: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-4-45cbc68e188b@baylibre.com>
2023-03-10 8:35 ` [PATCH 04/21] dt-bindings: display: mediatek: dither: add binding " Krzysztof Kozlowski
@ 2023-03-13 14:59 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-13 14:59 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi, Alexandre:
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>
> Display Dither for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml
> index 8ad8187c02d1..a7706cd65675 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml
> @@ -29,6 +29,7 @@ properties:
> - mediatek,mt8186-disp-dither
> - mediatek,mt8192-disp-dither
> - mediatek,mt8195-disp-dither
> + - mediatek,mt8365-disp-dither
> - const: mediatek,mt8183-disp-dither
>
> reg:
>
> --
> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 05/21] dt-bindings: display: mediatek: dsi: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-5-45cbc68e188b@baylibre.com>
2023-03-10 8:35 ` [PATCH 05/21] dt-bindings: display: mediatek: dsi: " Krzysztof Kozlowski
@ 2023-03-13 15:00 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-13 15:00 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi, Alexandre:
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>
> Display Serial Interface for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> .../bindings/display/mediatek/mediatek,dsi.yaml | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml
> index 4707b60238b0..b6579d3effc5 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml
> @@ -22,13 +22,18 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - mediatek,mt2701-dsi
> - - mediatek,mt7623-dsi
> - - mediatek,mt8167-dsi
> - - mediatek,mt8173-dsi
> - - mediatek,mt8183-dsi
> - - mediatek,mt8186-dsi
> + oneOf:
> + - enum:
> + - mediatek,mt2701-dsi
> + - mediatek,mt7623-dsi
> + - mediatek,mt8167-dsi
> + - mediatek,mt8173-dsi
> + - mediatek,mt8183-dsi
> + - mediatek,mt8186-dsi
> + - items:
> + - enum:
> + - mediatek,mt8365-dsi
> + - const: mediatek,mt8183-dsi
>
> reg:
> maxItems: 1
>
> --
> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 01/21] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-1-45cbc68e188b@baylibre.com>
2023-03-10 8:41 ` [PATCH 01/21] dt-bindings: display: mediatek: aal: " Krzysztof Kozlowski
@ 2023-03-13 15:02 ` Chun-Kuang Hu
2023-03-31 14:55 ` Matthias Brugger
1 sibling, 1 reply; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-13 15:02 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi, Alexandre:
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>
> Display Adaptive Ambient Light for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> index d4d585485e7b..d47bc72f09c0 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> @@ -33,6 +33,7 @@ properties:
> - mediatek,mt8186-disp-aal
> - mediatek,mt8192-disp-aal
> - mediatek,mt8195-disp-aal
> + - mediatek,mt8365-disp-aal
> - const: mediatek,mt8183-disp-aal
>
> reg:
>
> --
> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 08/21] dt-bindings: display: mediatek: gamma: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-8-45cbc68e188b@baylibre.com>
2023-03-10 8:38 ` [PATCH 08/21] dt-bindings: display: mediatek: gamma: " Krzysztof Kozlowski
@ 2023-03-13 15:07 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-13 15:07 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi, Alexandre:
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>
> Display GAMMA for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> index a89ea0ea7542..f54859cfc97b 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> @@ -30,6 +30,7 @@ properties:
> - mediatek,mt8186-disp-gamma
> - mediatek,mt8192-disp-gamma
> - mediatek,mt8195-disp-gamma
> + - mediatek,mt8365-disp-gamma
> - const: mediatek,mt8183-disp-gamma
>
> reg:
>
> --
> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 09/21] dt-bindings: display: mediatek: ovl: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-9-45cbc68e188b@baylibre.com>
2023-03-10 8:38 ` [PATCH 09/21] dt-bindings: display: mediatek: ovl: add binding for MT8365 SoC Krzysztof Kozlowski
@ 2023-03-13 15:08 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-13 15:08 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Neil Armstrong, linux-kernel, dri-devel, linux-pwm,
Fabien Parent, devicetree, linux-mediatek, Guillaume La Roque,
linux-arm-kernel
Hi, Alexandre:
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>
> Display Overlay for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8192 SoC.
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> index a2a27d0ca038..20e4ca4fc915 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> @@ -41,6 +41,7 @@ properties:
> - items:
> - enum:
> - mediatek,mt8186-disp-ovl
> + - mediatek,mt8365-disp-ovl
> - const: mediatek,mt8192-disp-ovl
>
> reg:
>
> --
> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 10/21] dt-bindings: display: mediatek: rdma: add binding for MT8365 SoC
[not found] ` <20230220-display-v1-10-45cbc68e188b@baylibre.com>
2023-03-10 8:38 ` [PATCH 10/21] dt-bindings: display: mediatek: rdma: " Krzysztof Kozlowski
@ 2023-03-13 15:09 ` Chun-Kuang Hu
1 sibling, 0 replies; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-13 15:09 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi, Alexandre:
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>
> Display Data Path Read DMA for MT8365 is compatible with another SoC.
> Then, add MT8365 binding along with MT8183 SoC.
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml
> index 0882ae86e6c4..3bc914785976 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml
> @@ -40,6 +40,7 @@ properties:
> - enum:
> - mediatek,mt8186-disp-rdma
> - mediatek,mt8192-disp-rdma
> + - mediatek,mt8365-disp-rdma
> - const: mediatek,mt8183-disp-rdma
>
> reg:
>
> --
> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365
[not found] ` <20230220-display-v1-7-45cbc68e188b@baylibre.com>
2023-03-10 8:38 ` [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365 Krzysztof Kozlowski
@ 2023-03-13 15:17 ` Chun-Kuang Hu
2023-03-15 9:26 ` Alexandre Mergnat
1 sibling, 1 reply; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-13 15:17 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi, Alexandre:
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>
> From: Fabien Parent <fparent@baylibre.com>
>
> DPI for MT8365 is compatible with MT8192 but requires an additional
> clock. Modify the documentation to requires this clock only on MT8365 SoCs.
If MT8365 DPI has additional clock, why it is compatible with MT8192 DPI?
I think some part of MT8165 DPI works under the speed control by the
DPI clock and this is different with MT8192 DPI, how could these two
are compatible?
Regards,
Chun-Kuang.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> .../bindings/display/mediatek/mediatek,dpi.yaml | 48 ++++++++++++++++++----
> 1 file changed, 39 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> index 56511c4d4b9b..3f6cca81340c 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> @@ -17,15 +17,20 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - mediatek,mt2701-dpi
> - - mediatek,mt7623-dpi
> - - mediatek,mt8173-dpi
> - - mediatek,mt8183-dpi
> - - mediatek,mt8186-dpi
> - - mediatek,mt8188-dp-intf
> - - mediatek,mt8192-dpi
> - - mediatek,mt8195-dp-intf
> + oneOf:
> + - enum:
> + - mediatek,mt2701-dpi
> + - mediatek,mt7623-dpi
> + - mediatek,mt8173-dpi
> + - mediatek,mt8183-dpi
> + - mediatek,mt8186-dpi
> + - mediatek,mt8188-dp-intf
> + - mediatek,mt8192-dpi
> + - mediatek,mt8195-dp-intf
> + - items:
> + - enum:
> + - mediatek,mt8365-dpi
> + - const: mediatek,mt8192-dpi
>
> reg:
> maxItems: 1
> @@ -34,16 +39,20 @@ properties:
> maxItems: 1
>
> clocks:
> + minItems: 3
> items:
> - description: Pixel Clock
> - description: Engine Clock
> - description: DPI PLL
> + - description: DPI Clock
>
> clock-names:
> + minItems: 3
> items:
> - const: pixel
> - const: engine
> - const: pll
> + - const: dpi
>
> pinctrl-0: true
> pinctrl-1: true
> @@ -72,6 +81,27 @@ required:
>
> additionalProperties: false
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8365-dpi
> +
> + then:
> + properties:
> + clocks:
> + maxItems: 4
> + clock-names:
> + maxItems: 4
> +
> + else:
> + properties:
> + clocks:
> + maxItems: 3
> + clock-names:
> + maxItems: 3
> +
> examples:
> - |
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> --
> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock
[not found] ` <20230220-display-v1-19-45cbc68e188b@baylibre.com>
@ 2023-03-13 15:21 ` Chun-Kuang Hu
2023-03-15 9:35 ` Alexandre Mergnat
0 siblings, 1 reply; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-13 15:21 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi, Alexandre:
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>
> From: Fabien Parent <fparent@baylibre.com>
>
> MT8365 requires an additional clock for DPI. Add support for that
> additional clock.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4317595a15d1..474c6e5bbf04 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -68,6 +68,7 @@ struct mtk_dpi {
> struct device *dev;
> struct clk *engine_clk;
> struct clk *pixel_clk;
> + struct clk *dpi_clk;
> struct clk *tvd_clk;
> int irq;
> struct drm_display_mode mode;
> @@ -464,6 +465,7 @@ static void mtk_dpi_power_off(struct mtk_dpi *dpi)
> mtk_dpi_disable(dpi);
> clk_disable_unprepare(dpi->pixel_clk);
> clk_disable_unprepare(dpi->engine_clk);
> + clk_disable_unprepare(dpi->dpi_clk);
> }
>
> static int mtk_dpi_power_on(struct mtk_dpi *dpi)
> @@ -473,10 +475,16 @@ static int mtk_dpi_power_on(struct mtk_dpi *dpi)
> if (++dpi->refcount != 1)
> return 0;
>
> + ret = clk_prepare_enable(dpi->dpi_clk);
> + if (ret) {
> + dev_err(dpi->dev, "failed to enable dpi clock: %d\n", ret);
> + goto err_refcount;
> + }
> +
> ret = clk_prepare_enable(dpi->engine_clk);
> if (ret) {
> dev_err(dpi->dev, "Failed to enable engine clock: %d\n", ret);
> - goto err_refcount;
> + goto err_engine;
> }
>
> ret = clk_prepare_enable(dpi->pixel_clk);
> @@ -489,6 +497,8 @@ static int mtk_dpi_power_on(struct mtk_dpi *dpi)
>
> err_pixel:
> clk_disable_unprepare(dpi->engine_clk);
> +err_engine:
> + clk_disable_unprepare(dpi->dpi_clk);
> err_refcount:
> dpi->refcount--;
> return ret;
> @@ -1044,6 +1054,12 @@ static int mtk_dpi_probe(struct platform_device *pdev)
> return ret;
> }
>
> + dpi->dpi_clk = devm_clk_get_optional(dev, "dpi");
For MT8365, DPI clock is not optional, so make sure that MT8365 DPI
should have this clock.
Regards,
Chun-Kuang.
> + if (IS_ERR(dpi->dpi_clk)) {
> + return dev_err_probe(dev, ret, "Failed to get dpi clock: %p\n",
> + dpi->dpi_clk);
> + }
> +
> dpi->irq = platform_get_irq(pdev, 0);
> if (dpi->irq <= 0)
> return -EINVAL;
>
> --
> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC
2023-03-10 8:39 ` [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC Krzysztof Kozlowski
@ 2023-03-15 8:01 ` Alexandre Mergnat
2023-03-15 8:17 ` Alexandre Mergnat
2023-03-15 13:17 ` Krzysztof Kozlowski
0 siblings, 2 replies; 36+ messages in thread
From: Alexandre Mergnat @ 2023-03-15 8:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Le ven. 10 mars 2023 à 09:39, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> a écrit :
>
> On 09/03/2023 15:23, Alexandre Mergnat wrote:
> > Add compatible for the MT8365 SoC.
> >
> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> > ---
> > Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> > index ca0ca549257d..931d66893dff 100644
> > --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> > +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> > @@ -34,6 +34,7 @@ properties:
> > - mediatek,mt8186-mdp3-mutex
> > - mediatek,mt8192-disp-mutex
> > - mediatek,mt8195-disp-mutex
> > + - mediatek,mt8365-disp-mutex
>
> All these look compatible. Either make mt8635 compatible with something
> or even rework entire list and make everything compatible.
All of them use "mtk_mutec.c" but have specific data.
.data = &mt8173_mutex_driver_data},
{ .compatible = "mediatek,mt8183-disp-mutex",
.data = &mt8183_mutex_driver_data},
{ .compatible = "mediatek,mt8186-disp-mutex",
.data = &mt8186_mutex_driver_data},
{ .compatible = "mediatek,mt8186-mdp3-mutex",
.data = &mt8186_mdp_mutex_driver_data},
{ .compatible = "mediatek,mt8192-disp-mutex",
.data = &mt8192_mutex_driver_data},
{ .compatible = "mediatek,mt8195-disp-mutex",
.data = &mt8195_mutex_driver_data},
{ .compatible = "mediatek,mt8365-disp-mutex",
.data = &mt8365_mutex_driver_data},
I don't see any SoC compatible with mt8635, and I have no idea which
rework you have in mind. Can you please point me an example ?
Thanks
Alex
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC
2023-03-15 8:01 ` Alexandre Mergnat
@ 2023-03-15 8:17 ` Alexandre Mergnat
2023-03-15 13:17 ` Krzysztof Kozlowski
1 sibling, 0 replies; 36+ messages in thread
From: Alexandre Mergnat @ 2023-03-15 8:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Maybe "oneOf" should be added at least ?
compatible:
oneOf:
- enum:
Regards,
Alex
Le mer. 15 mars 2023 à 09:01, Alexandre Mergnat
<amergnat@baylibre.com> a écrit :
>
> Le ven. 10 mars 2023 à 09:39, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> a écrit :
> >
> > On 09/03/2023 15:23, Alexandre Mergnat wrote:
> > > Add compatible for the MT8365 SoC.
> > >
> > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> > > ---
> > > Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> > > index ca0ca549257d..931d66893dff 100644
> > > --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> > > +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> > > @@ -34,6 +34,7 @@ properties:
> > > - mediatek,mt8186-mdp3-mutex
> > > - mediatek,mt8192-disp-mutex
> > > - mediatek,mt8195-disp-mutex
> > > + - mediatek,mt8365-disp-mutex
> >
> > All these look compatible. Either make mt8635 compatible with something
> > or even rework entire list and make everything compatible.
>
> All of them use "mtk_mutec.c" but have specific data.
>
> .data = &mt8173_mutex_driver_data},
> { .compatible = "mediatek,mt8183-disp-mutex",
> .data = &mt8183_mutex_driver_data},
> { .compatible = "mediatek,mt8186-disp-mutex",
> .data = &mt8186_mutex_driver_data},
> { .compatible = "mediatek,mt8186-mdp3-mutex",
> .data = &mt8186_mdp_mutex_driver_data},
> { .compatible = "mediatek,mt8192-disp-mutex",
> .data = &mt8192_mutex_driver_data},
> { .compatible = "mediatek,mt8195-disp-mutex",
> .data = &mt8195_mutex_driver_data},
> { .compatible = "mediatek,mt8365-disp-mutex",
> .data = &mt8365_mutex_driver_data},
>
> I don't see any SoC compatible with mt8635, and I have no idea which
> rework you have in mind. Can you please point me an example ?
>
> Thanks
> Alex
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365
2023-03-13 15:17 ` Chun-Kuang Hu
@ 2023-03-15 9:26 ` Alexandre Mergnat
0 siblings, 0 replies; 36+ messages in thread
From: Alexandre Mergnat @ 2023-03-15 9:26 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi Chun-Kuang,
Le lun. 13 mars 2023 à 16:17, Chun-Kuang Hu <chunkuang.hu@kernel.org> a écrit :
>
> Hi, Alexandre:
>
> Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
> >
> > From: Fabien Parent <fparent@baylibre.com>
> >
> > DPI for MT8365 is compatible with MT8192 but requires an additional
> > clock. Modify the documentation to requires this clock only on MT8365 SoCs.
>
> If MT8365 DPI has additional clock, why it is compatible with MT8192 DPI?
> I think some part of MT8165 DPI works under the speed control by the
> DPI clock and this is different with MT8192 DPI, how could these two
> are compatible?
AFAII, The mtk_dpi driver manage the 4th clock as optional
dpi->dpi_clk = devm_clk_get_optional(dev, "dpi");
And all configuration variables for mt8192 are the same for mt8365.
These configuration clock variables (like cal_factor) aren't
correlated with the 4th clock.
The clock number doesn't impact the configuration variable because the
4th clock is simply retrieved from DTS, saved in the driver structure
and prepare/unprepare/enable/disable, like other clocks.
Regards,
Alex
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock
2023-03-13 15:21 ` [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock Chun-Kuang Hu
@ 2023-03-15 9:35 ` Alexandre Mergnat
2023-03-15 14:17 ` Chun-Kuang Hu
0 siblings, 1 reply; 36+ messages in thread
From: Alexandre Mergnat @ 2023-03-15 9:35 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Le lun. 13 mars 2023 à 16:21, Chun-Kuang Hu <chunkuang.hu@kernel.org> a écrit :
>
> >
> > + dpi->dpi_clk = devm_clk_get_optional(dev, "dpi");
>
> For MT8365, DPI clock is not optional, so make sure that MT8365 DPI
> should have this clock.
This should be check and notified at build time thanks to the
device-tree binding. Do you prefer this?:
#IF MT8365_SOC
dpi->dpi_clk = devm_clk_get(dev, "dpi");
Regards,
Alex
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC
2023-03-15 8:01 ` Alexandre Mergnat
2023-03-15 8:17 ` Alexandre Mergnat
@ 2023-03-15 13:17 ` Krzysztof Kozlowski
1 sibling, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-15 13:17 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 15/03/2023 09:01, Alexandre Mergnat wrote:
> Le ven. 10 mars 2023 à 09:39, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> a écrit :
>>
>> On 09/03/2023 15:23, Alexandre Mergnat wrote:
>>> Add compatible for the MT8365 SoC.
>>>
>>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
>>> ---
>>> Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
>>> index ca0ca549257d..931d66893dff 100644
>>> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
>>> @@ -34,6 +34,7 @@ properties:
>>> - mediatek,mt8186-mdp3-mutex
>>> - mediatek,mt8192-disp-mutex
>>> - mediatek,mt8195-disp-mutex
>>> + - mediatek,mt8365-disp-mutex
>>
>> All these look compatible. Either make mt8635 compatible with something
>> or even rework entire list and make everything compatible.
>
> All of them use "mtk_mutec.c" but have specific data.
>
> .data = &mt8173_mutex_driver_data},
> { .compatible = "mediatek,mt8183-disp-mutex",
> .data = &mt8183_mutex_driver_data},
> { .compatible = "mediatek,mt8186-disp-mutex",
> .data = &mt8186_mutex_driver_data},
> { .compatible = "mediatek,mt8186-mdp3-mutex",
> .data = &mt8186_mdp_mutex_driver_data},
> { .compatible = "mediatek,mt8192-disp-mutex",
> .data = &mt8192_mutex_driver_data},
> { .compatible = "mediatek,mt8195-disp-mutex",
> .data = &mt8195_mutex_driver_data},
> { .compatible = "mediatek,mt8365-disp-mutex",
> .data = &mt8365_mutex_driver_data},
>
> I don't see any SoC compatible with mt8635, and I have no idea which
> rework you have in mind. Can you please point me an example ?
You are right, I looked at wrong of_device_id.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC
[not found] ` <20230220-display-v1-15-45cbc68e188b@baylibre.com>
2023-03-10 8:39 ` [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC Krzysztof Kozlowski
@ 2023-03-15 13:22 ` Krzysztof Kozlowski
2023-03-31 17:51 ` Matthias Brugger
2 siblings, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-15 13:22 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, Matthias Brugger,
David Airlie, Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:23, Alexandre Mergnat wrote:
> Add compatible for the MT8365 SoC.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock
2023-03-15 9:35 ` Alexandre Mergnat
@ 2023-03-15 14:17 ` Chun-Kuang Hu
0 siblings, 0 replies; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-15 14:17 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Chun-Kuang Hu, Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding,
Philipp Zabel, Sam Ravnborg, Rob Herring, Uwe Kleine-König,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi, Alexandre:
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月15日 週三 下午5:36寫道:
>
> Le lun. 13 mars 2023 à 16:21, Chun-Kuang Hu <chunkuang.hu@kernel.org> a écrit :
> >
> > >
> > > + dpi->dpi_clk = devm_clk_get_optional(dev, "dpi");
> >
> > For MT8365, DPI clock is not optional, so make sure that MT8365 DPI
> > should have this clock.
>
> This should be check and notified at build time thanks to the
> device-tree binding. Do you prefer this?:
> #IF MT8365_SOC
> dpi->dpi_clk = devm_clk_get(dev, "dpi");
Add one member in struct mtk_dpi_conf for dpi_clk. In
mtk_dpi_of_ids[], add one item for mt8365
{ .compatible = "mediatek,mt8365-dpi",
.data = &mt8365_conf,
},
Regards,
Chun-Kuang.
>
> Regards,
> Alex
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 21/21] panel: startek-kd070fhfid015: add support of this display
2023-03-09 14:51 ` [PATCH 21/21] panel: startek-kd070fhfid015: add support of this display Neil Armstrong
@ 2023-03-15 15:59 ` Alexandre Mergnat
2023-03-15 17:12 ` neil.armstrong
0 siblings, 1 reply; 36+ messages in thread
From: Alexandre Mergnat @ 2023-03-15 15:59 UTC (permalink / raw)
To: neil.armstrong
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, linux-pwm, devicetree, linux-kernel
Hi Neil,
Le jeu. 9 mars 2023 à 15:51, Neil Armstrong
<neil.armstrong@linaro.org> a écrit :
> > +
> > +#include <drm/drm_crtc.h>
>
> Is this include needed ?
Seems not, I remove it.
> > + struct gpio_desc *enable_gpio;
> > + struct gpio_desc *reset_gpio;
> > + struct gpio_desc *dcdc_en_gpio;
>
> Isn't this "DCDC" a regulator ???
According to the panel datasheet, this is an input signal needed
passing through TFT connector (PIN30):
"Power IC supply enable, High active"
> > + /* Interface setting, video mode */
> > + ret = mipi_dsi_generic_write(dsi,
> > + (u8[]){DSI_REG_IS, 0x14, 0x08, 0x00, 0x22, 0x00}, 6);
> > + if (ret < 0) {
> > + dev_err(dev, "failed to set display interface setting: %d\n",
> > + ret);
> > + return ret;
> > + }
>
> Use mipi_dsi_generic_write_seq(dsi, DSI_REG_IS, 0x14, 0x08, 0x00, 0x22, 0x00); instead,
> it's simpler and doesn't need explicit return check.
"mipi_dsi_generic_write_seq" doesn't exist but I will add it below
"mipi_dsi_dcs_write_seq" in drm_mipi_dsi.h
I must keep the return check to jump out of "stk_panel_init" if
something goes wrong, but I can drop the error print.
> > +static int stk_panel_enable(struct drm_panel *panel)
> > +{
> > + struct stk_panel *stk = to_stk_panel(panel);
> > +
> > + if (stk->enabled)
> > + return 0;
> > +
> > + backlight_enable(stk->backlight);
> > +
> > + stk->enabled = true;
> > +
> > + return 0;
> > +}
>
> Is this really needed ? the backlight core will enable it automatically.
Ok, it's managed by drm_panel.c driver.
Then I can also remove stuff from stk_panel_disable.
Regards,
Alex
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 21/21] panel: startek-kd070fhfid015: add support of this display
2023-03-15 15:59 ` Alexandre Mergnat
@ 2023-03-15 17:12 ` neil.armstrong
0 siblings, 0 replies; 36+ messages in thread
From: neil.armstrong @ 2023-03-15 17:12 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, linux-pwm, devicetree, linux-kernel
Hi,
On 15/03/2023 16:59, Alexandre Mergnat wrote:
> Hi Neil,
>
> Le jeu. 9 mars 2023 à 15:51, Neil Armstrong
> <neil.armstrong@linaro.org> a écrit :
>>> +
>>> +#include <drm/drm_crtc.h>
>>
>> Is this include needed ?
>
> Seems not, I remove it.
>
>>> + struct gpio_desc *enable_gpio;
>>> + struct gpio_desc *reset_gpio;
>>> + struct gpio_desc *dcdc_en_gpio;
>>
>> Isn't this "DCDC" a regulator ???
>
> According to the panel datasheet, this is an input signal needed
> passing through TFT connector (PIN30):
> "Power IC supply enable, High active"
Ack, perhaps the name isn't the right one, or specify something like panel-dcdc.
>
>>> + /* Interface setting, video mode */
>>> + ret = mipi_dsi_generic_write(dsi,
>>> + (u8[]){DSI_REG_IS, 0x14, 0x08, 0x00, 0x22, 0x00}, 6);
>>> + if (ret < 0) {
>>> + dev_err(dev, "failed to set display interface setting: %d\n",
>>> + ret);
>>> + return ret;
>>> + }
>>
>> Use mipi_dsi_generic_write_seq(dsi, DSI_REG_IS, 0x14, 0x08, 0x00, 0x22, 0x00); instead,
>> it's simpler and doesn't need explicit return check.
>
> "mipi_dsi_generic_write_seq" doesn't exist but I will add it below
> "mipi_dsi_dcs_write_seq" in drm_mipi_dsi.h
It is now https://github.com/torvalds/linux/blob/master/include/drm/drm_mipi_dsi.h#L302 since a9015ce59320
> I must keep the return check to jump out of "stk_panel_init" if
> something goes wrong, but I can drop the error print.
The mipi_dsi_generic_write_seq & mipi_dsi_dcs_write_seq macros does the return check for free.
>
>>> +static int stk_panel_enable(struct drm_panel *panel)
>>> +{
>>> + struct stk_panel *stk = to_stk_panel(panel);
>>> +
>>> + if (stk->enabled)
>>> + return 0;
>>> +
>>> + backlight_enable(stk->backlight);
>>> +
>>> + stk->enabled = true;
>>> +
>>> + return 0;
>>> +}
>>
>> Is this really needed ? the backlight core will enable it automatically.
>
> Ok, it's managed by drm_panel.c driver.
> Then I can also remove stuff from stk_panel_disable.
>
>
> Regards,
> Alex
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 18/21] drm/mediatek: dsi: Improves the DSI lane setup robustness
[not found] ` <20230220-display-v1-18-45cbc68e188b@baylibre.com>
@ 2023-03-27 15:37 ` Chun-Kuang Hu
0 siblings, 0 replies; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-03-27 15:37 UTC (permalink / raw)
To: Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, Chun-Kuang Hu,
Matthias Brugger, David Airlie, Krzysztof Kozlowski, Xinlei Lee,
Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
Hi, Xinlei:
Could you help to review this patch?
Regards,
Chun-Kuang.
Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>
> Currently, mtk_dsi_lane_ready (which setup the DSI lane) is triggered
> before mtk_dsi_poweron. lanes_ready flag toggle to true during
> mtk_dsi_lane_ready function, and the DSI module is set up during
> mtk_dsi_poweron.
>
> Later, during panel driver init, mtk_dsi_lane_ready is triggered but does
> nothing because lanes are considered ready. Unfortunately, when the panel
> driver try to communicate, the DSI returns a timeout.
>
> The solution found here is to put lanes_ready flag to false after the DSI
> module setup into mtk_dsi_poweron to init the DSI lanes after the power /
> setup of the DSI module.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 3b7d13028fb6..35c36cc05c04 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -667,6 +667,8 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi)
> mtk_dsi_config_vdo_timing(dsi);
> mtk_dsi_set_interrupt_enable(dsi);
>
> + dsi->lanes_ready = false;
> +
> return 0;
> err_disable_engine_clk:
> clk_disable_unprepare(dsi->engine_clk);
>
> --
> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 14/21] dt-bindings: soc: mediatek: specify which compatible requires clocks property
[not found] ` <20230220-display-v1-14-45cbc68e188b@baylibre.com>
@ 2023-03-31 14:42 ` Matthias Brugger
0 siblings, 0 replies; 36+ messages in thread
From: Matthias Brugger @ 2023-03-31 14:42 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, David Airlie,
Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:23, Alexandre Mergnat wrote:
> According to the mtk-mutex.c driver and the SoC DTS, the clock isn't
> required to work properly for some of MTK SoC. Improve the clock
> requirement by adding a condition which is function to the compatible.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
Applied, thanks.
Now I think we can get rid of the no_clk variable in struct mtk_mutex_data, as
this should be mandated by the device-tree.
Regards,
Matthias
> ---
> .../bindings/soc/mediatek/mediatek,mutex.yaml | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> index 9241e5fc7cff..ca0ca549257d 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> @@ -69,12 +69,30 @@ properties:
> 4 arguments defined in this property. Each GCE subsys id is mapping to
> a client defined in the header include/dt-bindings/gce/<chip>-gce.h.
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mediatek,mt2701-disp-mutex
> + - mediatek,mt2712-disp-mutex
> + - mediatek,mt6795-disp-mutex
> + - mediatek,mt8173-disp-mutex
> + - mediatek,mt8186-disp-mutex
> + - mediatek,mt8186-mdp3-mutex
> + - mediatek,mt8192-disp-mutex
> + - mediatek,mt8195-disp-mutex
> + then:
> + required:
> + - clocks
> +
> +
> required:
> - compatible
> - reg
> - interrupts
> - power-domains
> - - clocks
>
> additionalProperties: false
>
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 01/21] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC
2023-03-13 15:02 ` Chun-Kuang Hu
@ 2023-03-31 14:55 ` Matthias Brugger
2023-04-03 3:25 ` Chun-Kuang Hu
0 siblings, 1 reply; 36+ messages in thread
From: Matthias Brugger @ 2023-03-31 14:55 UTC (permalink / raw)
To: Chun-Kuang Hu, Alexandre Mergnat
Cc: Daniel Vetter, CK Hu, Jitao Shi, Thierry Reding, Philipp Zabel,
Sam Ravnborg, Rob Herring, Uwe Kleine-König, David Airlie,
Krzysztof Kozlowski, Xinlei Lee, Guillaume La Roque,
linux-arm-kernel, linux-mediatek, dri-devel, Fabien Parent,
Neil Armstrong, linux-pwm, devicetree, linux-kernel
Hi Chun-Kuang Hu,
On 13/03/2023 16:02, Chun-Kuang Hu wrote:
> Hi, Alexandre:
>
> Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
>>
>> Display Adaptive Ambient Light for MT8365 is compatible with another SoC.
>> Then, add MT8365 binding along with MT8183 SoC.
>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
I'm a bit puzzled that you give your reviewed by while I would have expected
that you will take the display binding patches. Will you take these or do you
want someone else to take them?
Regards,
Matthias
>>
>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
>> ---
>> Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
>> index d4d585485e7b..d47bc72f09c0 100644
>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
>> @@ -33,6 +33,7 @@ properties:
>> - mediatek,mt8186-disp-aal
>> - mediatek,mt8192-disp-aal
>> - mediatek,mt8195-disp-aal
>> + - mediatek,mt8365-disp-aal
>> - const: mediatek,mt8183-disp-aal
>>
>> reg:
>>
>> --
>> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC
[not found] ` <20230220-display-v1-15-45cbc68e188b@baylibre.com>
2023-03-10 8:39 ` [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC Krzysztof Kozlowski
2023-03-15 13:22 ` Krzysztof Kozlowski
@ 2023-03-31 17:51 ` Matthias Brugger
2 siblings, 0 replies; 36+ messages in thread
From: Matthias Brugger @ 2023-03-31 17:51 UTC (permalink / raw)
To: Alexandre Mergnat, Daniel Vetter, CK Hu, Jitao Shi,
Thierry Reding, Philipp Zabel, Sam Ravnborg, Rob Herring,
Uwe Kleine-König, Chun-Kuang Hu, David Airlie,
Krzysztof Kozlowski, Xinlei Lee
Cc: Guillaume La Roque, linux-arm-kernel, linux-mediatek, dri-devel,
Fabien Parent, Neil Armstrong, linux-pwm, devicetree,
linux-kernel
On 09/03/2023 15:23, Alexandre Mergnat wrote:
> Add compatible for the MT8365 SoC.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
Applied, thanks!
> ---
> Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> index ca0ca549257d..931d66893dff 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
> @@ -34,6 +34,7 @@ properties:
> - mediatek,mt8186-mdp3-mutex
> - mediatek,mt8192-disp-mutex
> - mediatek,mt8195-disp-mutex
> + - mediatek,mt8365-disp-mutex
>
> reg:
> maxItems: 1
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 01/21] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC
2023-03-31 14:55 ` Matthias Brugger
@ 2023-04-03 3:25 ` Chun-Kuang Hu
0 siblings, 0 replies; 36+ messages in thread
From: Chun-Kuang Hu @ 2023-04-03 3:25 UTC (permalink / raw)
To: Matthias Brugger
Cc: Chun-Kuang Hu, Alexandre Mergnat, Daniel Vetter, CK Hu,
Jitao Shi, Thierry Reding, Philipp Zabel, Sam Ravnborg,
Rob Herring, Uwe Kleine-König, David Airlie,
Krzysztof Kozlowski, Xinlei Lee, Guillaume La Roque,
linux-arm-kernel, linux-mediatek, dri-devel, Fabien Parent,
Neil Armstrong, linux-pwm, devicetree, linux-kernel
Hi, Matthias:
Matthias Brugger <matthias.bgg@gmail.com> 於 2023年3月31日 週五 下午10:55寫道:
>
> Hi Chun-Kuang Hu,
>
> On 13/03/2023 16:02, Chun-Kuang Hu wrote:
> > Hi, Alexandre:
> >
> > Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月9日 週四 下午10:23寫道:
> >>
> >> Display Adaptive Ambient Light for MT8365 is compatible with another SoC.
> >> Then, add MT8365 binding along with MT8183 SoC.
> >
> > Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> >
>
> I'm a bit puzzled that you give your reviewed by while I would have expected
> that you will take the display binding patches. Will you take these or do you
> want someone else to take them?
I usually apply whole series together, and I've question about
"[07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365"
in this series. This is just the first version, so maybe I would apply
partial patches in later version.
Regards,
Chun-Kuang.
>
> Regards,
> Matthias
>
> >>
> >> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> >> ---
> >> Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> >> index d4d585485e7b..d47bc72f09c0 100644
> >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> >> @@ -33,6 +33,7 @@ properties:
> >> - mediatek,mt8186-disp-aal
> >> - mediatek,mt8192-disp-aal
> >> - mediatek,mt8195-disp-aal
> >> + - mediatek,mt8365-disp-aal
> >> - const: mediatek,mt8183-disp-aal
> >>
> >> reg:
> >>
> >> --
> >> b4 0.10.1
^ permalink raw reply [flat|nested] 36+ messages in thread
end of thread, other threads:[~2023-04-03 3:26 UTC | newest]
Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230220-display-v1-0-45cbc68e188b@baylibre.com>
[not found] ` <20230220-display-v1-21-45cbc68e188b@baylibre.com>
2023-03-09 14:51 ` [PATCH 21/21] panel: startek-kd070fhfid015: add support of this display Neil Armstrong
2023-03-15 15:59 ` Alexandre Mergnat
2023-03-15 17:12 ` neil.armstrong
[not found] ` <20230220-display-v1-2-45cbc68e188b@baylibre.com>
2023-03-10 8:29 ` [PATCH 02/21] dt-bindings: display: mediatek: ccorr: add binding for MT8365 SoC Krzysztof Kozlowski
2023-03-13 14:54 ` Chun-Kuang Hu
[not found] ` <20230220-display-v1-3-45cbc68e188b@baylibre.com>
2023-03-10 8:35 ` [PATCH 03/21] dt-bindings: display: mediatek: color: " Krzysztof Kozlowski
2023-03-13 14:58 ` Chun-Kuang Hu
[not found] ` <20230220-display-v1-7-45cbc68e188b@baylibre.com>
2023-03-10 8:38 ` [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365 Krzysztof Kozlowski
2023-03-13 15:17 ` Chun-Kuang Hu
2023-03-15 9:26 ` Alexandre Mergnat
[not found] ` <20230220-display-v1-9-45cbc68e188b@baylibre.com>
2023-03-10 8:38 ` [PATCH 09/21] dt-bindings: display: mediatek: ovl: add binding for MT8365 SoC Krzysztof Kozlowski
2023-03-13 15:08 ` Chun-Kuang Hu
[not found] ` <20230220-display-v1-10-45cbc68e188b@baylibre.com>
2023-03-10 8:38 ` [PATCH 10/21] dt-bindings: display: mediatek: rdma: " Krzysztof Kozlowski
2023-03-13 15:09 ` Chun-Kuang Hu
[not found] ` <20230220-display-v1-13-45cbc68e188b@baylibre.com>
2023-03-10 8:38 ` [PATCH 13/21] dt-bindings: pwm: add binding for mt8365 SoC Krzysztof Kozlowski
[not found] ` <20230220-display-v1-15-45cbc68e188b@baylibre.com>
2023-03-10 8:39 ` [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC Krzysztof Kozlowski
2023-03-15 8:01 ` Alexandre Mergnat
2023-03-15 8:17 ` Alexandre Mergnat
2023-03-15 13:17 ` Krzysztof Kozlowski
2023-03-15 13:22 ` Krzysztof Kozlowski
2023-03-31 17:51 ` Matthias Brugger
[not found] ` <20230220-display-v1-4-45cbc68e188b@baylibre.com>
2023-03-10 8:35 ` [PATCH 04/21] dt-bindings: display: mediatek: dither: add binding " Krzysztof Kozlowski
2023-03-13 14:59 ` Chun-Kuang Hu
[not found] ` <20230220-display-v1-5-45cbc68e188b@baylibre.com>
2023-03-10 8:35 ` [PATCH 05/21] dt-bindings: display: mediatek: dsi: " Krzysztof Kozlowski
2023-03-13 15:00 ` Chun-Kuang Hu
[not found] ` <20230220-display-v1-1-45cbc68e188b@baylibre.com>
2023-03-10 8:41 ` [PATCH 01/21] dt-bindings: display: mediatek: aal: " Krzysztof Kozlowski
2023-03-13 15:02 ` Chun-Kuang Hu
2023-03-31 14:55 ` Matthias Brugger
2023-04-03 3:25 ` Chun-Kuang Hu
[not found] ` <20230220-display-v1-8-45cbc68e188b@baylibre.com>
2023-03-10 8:38 ` [PATCH 08/21] dt-bindings: display: mediatek: gamma: " Krzysztof Kozlowski
2023-03-13 15:07 ` Chun-Kuang Hu
[not found] ` <20230220-display-v1-19-45cbc68e188b@baylibre.com>
2023-03-13 15:21 ` [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock Chun-Kuang Hu
2023-03-15 9:35 ` Alexandre Mergnat
2023-03-15 14:17 ` Chun-Kuang Hu
[not found] ` <20230220-display-v1-18-45cbc68e188b@baylibre.com>
2023-03-27 15:37 ` [PATCH 18/21] drm/mediatek: dsi: Improves the DSI lane setup robustness Chun-Kuang Hu
[not found] ` <20230220-display-v1-14-45cbc68e188b@baylibre.com>
2023-03-31 14:42 ` [PATCH 14/21] dt-bindings: soc: mediatek: specify which compatible requires clocks property Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).