From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lizhe <sensor1010@163.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, geert+renesas@glider.be,
info@metux.net, rjui@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com,
sbranden@broadcom.com, shc_work@mail.ru, j-keerthy@ti.com,
hoan@os.amperecomputing.com, fancer.lancer@gmail.com,
orsonzhai@gmail.com, baolin.wang@linux.alibaba.com,
zhang.lyra@gmail.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, kaloz@openwrt.org,
khalasa@piap.pl, keguang.zhang@gmail.com, daniel@thingy.jp,
romain.perier@gmail.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
grygorii.strashko@ti.com, ssantosh@kernel.org,
khilman@kernel.org, mani@kernel.org,
ludovic.desroches@microchip.com, andy@kernel.org,
palmer@dabbelt.com, paul.walmsley@sifive.com,
jonathanh@nvidia.com, sathyanarayanan.kuppuswamy@linux.intel.com,
michal.simek@xilinx.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-pwm@vger.kernel.org,
linux-omap@vger.kernel.org, linux-unisoc@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2] drivers/gpio : Remove redundant platform_set_drvdata().
Date: Mon, 20 Mar 2023 12:11:19 +0200 [thread overview]
Message-ID: <CAHp75VeLoMPtTU8TCuPjXD_YTY-_V-TmVJYeZiBB_BPqh8EVrQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vf9kwhbZaGjZeN5Jq0Wr_yJtDdj9N48-3o79AMORqmS3w@mail.gmail.com>
On Mon, Mar 20, 2023 at 12:10 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sun, Mar 19, 2023 at 2:01 PM Lizhe <sensor1010@163.com> wrote:
> >
> > platform_set_drvdata() is redundant in these functions.
> > the purpose of calling this function is to place data
> > in *driver_data. but the data is not retrieved in these
> > functions
>
> You need to:
> 1) split the series on per driver basis (not all of the drivers are
> going thru the same subsystem);
s/subsystem/tree/
> 2) improve English grammar and style in your commit message;
> 3) carefully explain in the cover letter your methods of finding the
> places you think need to be improved.
>
> Before that it's a waste of time to look at your contributions.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-03-20 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 11:59 [PATCH v2] drivers/gpio : Remove redundant platform_set_drvdata() Lizhe
2023-03-19 12:21 ` Christophe JAILLET
[not found] ` <3d85bea8.19f3.186f9d80b0c.Coremail.sensor1010@163.com>
2023-03-19 17:42 ` Christophe JAILLET
2023-03-19 17:59 ` Serge Semin
2023-03-19 21:20 ` Linus Walleij
2023-03-20 10:10 ` Andy Shevchenko
2023-03-20 10:11 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeLoMPtTU8TCuPjXD_YTY-_V-TmVJYeZiBB_BPqh8EVrQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=daniel@thingy.jp \
--cc=f.fainelli@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=grygorii.strashko@ti.com \
--cc=hoan@os.amperecomputing.com \
--cc=info@metux.net \
--cc=j-keerthy@ti.com \
--cc=jonathanh@nvidia.com \
--cc=kaloz@openwrt.org \
--cc=keguang.zhang@gmail.com \
--cc=kernel@pengutronix.de \
--cc=khalasa@piap.pl \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-unisoc@lists.infradead.org \
--cc=ludovic.desroches@microchip.com \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=orsonzhai@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rjui@broadcom.com \
--cc=romain.perier@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sbranden@broadcom.com \
--cc=sensor1010@163.com \
--cc=shawnguo@kernel.org \
--cc=shc_work@mail.ru \
--cc=ssantosh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).