From: Rob Herring <robh+dt@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Baruch Siach <baruch@tkos.co.il>,
Thierry Reding <thierry.reding@gmail.com>,
"Uwe Kleine-K?nig" <u.kleine-koenig@pengutronix.de>,
Lee Jones <lee.jones@linaro.org>, Andy Gross <agross@kernel.org>,
Balaji Prakash J <bjagadee@codeaurora.org>,
Robert Marko <robert.marko@sartura.hr>,
Kathiravan T <kathirav@codeaurora.org>,
Linux PWM List <linux-pwm@vger.kernel.org>,
devicetree@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 3/4] dt-bindings: pwm: add IPQ6018 binding
Date: Mon, 26 Jul 2021 14:38:58 -0600 [thread overview]
Message-ID: <CAL_Jsq+a__sQoKLahH3zu9hd2f4fCqaOQ6S82yua38om0D8raA@mail.gmail.com> (raw)
In-Reply-To: <YP2tAR+zZgJZQOgG@yoga>
On Sun, Jul 25, 2021 at 12:27 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Thu 22 Jul 05:01 CDT 2021, Baruch Siach wrote:
>
> > DT binding for the PWM block in Qualcomm IPQ6018 SoC.
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > v6:
> >
> > Device node is child of TCSR; remove phandle (Rob Herring)
> >
> > Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König)
> >
> > v5: Use qcom,pwm-regs for phandle instead of direct regs (Bjorn
> > Andersson, Kathiravan T)
> >
> > v4: Update the binding example node as well (Rob Herring's bot)
> >
> > v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring)
> >
> > v2: Make #pwm-cells const (Rob Herring)
> > ---
> > .../devicetree/bindings/pwm/ipq-pwm.yaml | 69 +++++++++++++++++++
> > 1 file changed, 69 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pwm/ipq-pwm.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml
> > new file mode 100644
> > index 000000000000..ee2bb03a1223
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pwm/ipq-pwm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm IPQ6018 PWM controller
> > +
> > +maintainers:
> > + - Baruch Siach <baruch@tkos.co.il>
> > +
> > +properties:
> > + "#pwm-cells":
> > + const: 2
> > +
> > + compatible:
> > + const: qcom,ipq6018-pwm
> > +
> > + offset:
> > + description: |
>
> '|' maintains the formatting of the text, you don't need that.
>
> > + Offset of PWM register in the TCSR block.
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + clock-names:
> > + const: core
>
> With a single clock, it's nice to skip the -names.
>
> > +
> > + assigned-clocks:
> > + maxItems: 1
> > +
> > + assigned-clock-rates:
> > + maxItems: 1
>
> These (assigned-*) are generic properties that may be used on a lot of
> nodes, should they really be part of the individual binding, Rob?
They are allowed on any node with 'clocks', so you don't need them.
However, if you know there's 1 entry only, then I'd keep that. Or was
'maxItems: 1' just copied because I see that alot.
Rob
next prev parent reply other threads:[~2021-07-26 20:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 10:01 [PATCH v6 1/4] arm64: dts: ipq6018: correct TCSR block area Baruch Siach
2021-07-22 10:01 ` [PATCH v6 2/4] pwm: driver for qualcomm ipq6018 pwm block Baruch Siach
2021-07-25 18:35 ` Bjorn Andersson
2021-07-26 4:31 ` Baruch Siach
2021-07-22 10:01 ` [PATCH v6 3/4] dt-bindings: pwm: add IPQ6018 binding Baruch Siach
2021-07-23 23:03 ` Rob Herring
2021-07-25 18:27 ` Bjorn Andersson
2021-07-26 4:08 ` Baruch Siach
2021-07-26 17:48 ` Bjorn Andersson
2021-07-26 20:38 ` Rob Herring [this message]
2021-07-22 10:01 ` [PATCH v6 4/4] arm64: dts: ipq6018: add pwm node Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+a__sQoKLahH3zu9hd2f4fCqaOQ6S82yua38om0D8raA@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=agross@kernel.org \
--cc=baruch@tkos.co.il \
--cc=bjagadee@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kathirav@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).