From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Lizhe <sensor1010@163.com>
Cc: andrew@lunn.ch, sebastian.hesselbarth@gmail.com,
gregory.clement@bootlin.com, linux@armlinux.org.uk,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] drivers/gpio : Remove redundant clearing of IRQ_TYPE_SENSE_MASK
Date: Tue, 30 May 2023 18:30:39 +0200 [thread overview]
Message-ID: <CAMRc=MctKb=LUu+um=9ZTH-51keBczdpY_EiPVYN+kbWJzdrTQ@mail.gmail.com> (raw)
In-Reply-To: <20230530162034.4004-1-sensor1010@163.com>
On Tue, May 30, 2023 at 6:21 PM Lizhe <sensor1010@163.com> wrote:
>
> Before executing microchip_sgpio_irq_set_type(),
> type has already been cleared IRQ_TYPE_SENSE_MASK, see __irq_set_trigger().
>
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
> arch/arm/plat-orion/gpio.c | 1 -
> drivers/gpio/gpio-mvebu.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c
> index 595e9cb33c1d..863fa497b1a2 100644
> --- a/arch/arm/plat-orion/gpio.c
> +++ b/arch/arm/plat-orion/gpio.c
> @@ -364,7 +364,6 @@ static int gpio_irq_set_type(struct irq_data *d, u32 type)
> return -EINVAL;
> }
>
> - type &= IRQ_TYPE_SENSE_MASK;
> if (type == IRQ_TYPE_NONE)
> return -EINVAL;
>
What have you not understood about splitting this into two patches?
Bart
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index a68f682aec01..34fd007b0308 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -505,7 +505,6 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
> if ((u & BIT(pin)) == 0)
> return -EINVAL;
>
> - type &= IRQ_TYPE_SENSE_MASK;
> if (type == IRQ_TYPE_NONE)
> return -EINVAL;
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-05-30 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 16:20 [PATCH] drivers/gpio : Remove redundant clearing of IRQ_TYPE_SENSE_MASK Lizhe
2023-05-30 16:30 ` Bartosz Golaszewski [this message]
2023-05-30 16:43 ` Russell King (Oracle)
-- strict thread matches above, loose matches on Subject: below --
2023-05-19 17:16 Lizhe
2023-05-23 8:29 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MctKb=LUu+um=9ZTH-51keBczdpY_EiPVYN+kbWJzdrTQ@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sensor1010@163.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).