From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69465C77B75 for ; Tue, 23 May 2023 08:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236168AbjEWIeC (ORCPT ); Tue, 23 May 2023 04:34:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235515AbjEWIdU (ORCPT ); Tue, 23 May 2023 04:33:20 -0400 Received: from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com [IPv6:2607:f8b0:4864:20::a31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59B80268F for ; Tue, 23 May 2023 01:29:40 -0700 (PDT) Received: by mail-vk1-xa31.google.com with SMTP id 71dfb90a1353d-456f19307f6so1963686e0c.2 for ; Tue, 23 May 2023 01:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1684830579; x=1687422579; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ILn21p3iZ6SH9K+Q+SIaeY3G2Mcp4yvUaAoc5C5tStU=; b=2J0fHnbfrRcsZzK2npGTKcC947Oxi0EKxXXqTryFytqM/KdAH7mmQzjXziTWKE4XL/ /p4CsRETrbQTzVDW+xYCs0pYOOAE15B2b49/gJuYWis29SxGD049DasfOre7uY8j8AWb MJKJ3jv26G1zdwv0qpvt4lXcUIm9HKhDnp0di6CXCAoiJqbyawcrOneRatg4Ycz2RQCI Fsy+fKZuP4SOJKRVYpTOEjrD5mGHZYB6dgJmXp9uw3dNJTc6aiSHkv1PfGLeQrYVLfyp I0HtUI7J1vnTxOisHOF1vFO4ESa/pafBf8hqu0MaBw9tjoA4uqSMxGiw8xgcMRVcndz7 m3JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684830579; x=1687422579; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ILn21p3iZ6SH9K+Q+SIaeY3G2Mcp4yvUaAoc5C5tStU=; b=bo+M/TN0b/H1klmgJgf9h3TKtdZRNTxL25B8MV42BPAXOdazXMosaeCD8bZDdfCN/E 2sgzO5ijhudJ1B2WSXSinFeKtAZ9APMRyF+NbSFIDNPgbPiy0z0T6ygFTehAjj1pXY/F iBW2XjshCR2H/MFCWk0CsApf670ZIH3KMNoGuyqZtgXcfR56VvaAgy0fxP5wsm+W4bSQ Nco1Np0zApIHnObkMNZuX/janWfRyFCKh/f8CMGmh9QrnywP873BpNVDcwl0sVeHVGih KW49byvHdnuwACnvq8YJNatLUoOO5bgLPLlrnV06f5FHeevrpTaSbmE9ckHM8abRmTgw bUSg== X-Gm-Message-State: AC+VfDxgB1RkPG92BE0kO0hTO43czFqs6rcJmxQ6p7hi8B40pLFybPqx drvSeYDwzoG5fu5fqsr8QMG/BfwRrISgw9yo+0vgwQ== X-Google-Smtp-Source: ACHHUZ7YKuSwrv0dWkaxm1I+dNkm97+KbpOtnb5BMYhmZ1vmG+hGVaj/tYJPg9kc1sbMWLiBy43AICYO3yKBeV6NVnM= X-Received: by 2002:a1f:3f03:0:b0:453:8f1c:eb31 with SMTP id m3-20020a1f3f03000000b004538f1ceb31mr4017125vka.14.1684830579480; Tue, 23 May 2023 01:29:39 -0700 (PDT) MIME-Version: 1.0 References: <20230519171611.6810-1-sensor1010@163.com> In-Reply-To: <20230519171611.6810-1-sensor1010@163.com> From: Bartosz Golaszewski Date: Tue, 23 May 2023 10:29:28 +0200 Message-ID: Subject: Re: [PATCH] drivers/gpio : Remove redundant clearing of IRQ_TYPE_SENSE_MASK To: Lizhe Cc: andrew@lunn.ch, sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux@armlinux.org.uk, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Fri, May 19, 2023 at 7:17=E2=80=AFPM Lizhe wrote: > > Before executing microchip_sgpio_irq_set_type(), > type has already been cleared IRQ_TYPE_SENSE_MASK, see __irq_set_trigger(= ). > > Signed-off-by: Lizhe > --- > arch/arm/plat-orion/gpio.c | 1 - > drivers/gpio/gpio-mvebu.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c > index 595e9cb33c1d..863fa497b1a2 100644 > --- a/arch/arm/plat-orion/gpio.c > +++ b/arch/arm/plat-orion/gpio.c > @@ -364,7 +364,6 @@ static int gpio_irq_set_type(struct irq_data *d, u32 = type) > return -EINVAL; > } > > - type &=3D IRQ_TYPE_SENSE_MASK; > if (type =3D=3D IRQ_TYPE_NONE) > return -EINVAL; > > diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c > index a68f682aec01..34fd007b0308 100644 > --- a/drivers/gpio/gpio-mvebu.c > +++ b/drivers/gpio/gpio-mvebu.c > @@ -505,7 +505,6 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d= , unsigned int type) > if ((u & BIT(pin)) =3D=3D 0) > return -EINVAL; > > - type &=3D IRQ_TYPE_SENSE_MASK; > if (type =3D=3D IRQ_TYPE_NONE) > return -EINVAL; > > -- > 2.34.1 > Please split it into two patches. I can apply the second part but arch/arm is beyond my jurisdiction. While at it: is this platform even used at all? If so, then maybe we could migrate this driver to drivers/gpio/? Bart