From: Biju Das <biju.das.jz@bp.renesas.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v17] pwm: Add Renesas RZ/G2L MTU3a PWM driver
Date: Fri, 2 Jun 2023 09:04:28 +0000 [thread overview]
Message-ID: <OS0PR01MB5922F29548AA079EEB2EA800864EA@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20230602082622.vs3boxqgek4jmb7b@pengutronix.de>
Hi Uwe,
Thanks for the feedback.
> Subject: Re: [PATCH v17] pwm: Add Renesas RZ/G2L MTU3a PWM driver
>
> Hello,
>
> On Mon, May 22, 2023 at 06:14:49PM +0100, Biju Das wrote:
> > base-commit: 9f258af06b6268be8e960f63c3f66e88bdbbbdb0
> > prerequisite-patch-id: 7d5c55db908971d16a58eb46b25d42dfb0f680ec
> > prerequisite-patch-id: 6c15d33bb612750523d14af87a5cf9e6ff142540
> > prerequisite-patch-id: e5e4d86a0a012a59f585b84ce7ae0d3f047787dc
> > prerequisite-patch-id: d62b4e1326f1518fd30eb98a37bfb4998573979a
> > prerequisite-patch-id: 15bf63b610cab275387a2bbee7ab2a0a48414f75
>
> My working copy doesn't contain
> 9f258af06b6268be8e960f63c3f66e88bdbbbdb0, so I wonder what is the base
> you used here. Also the other prerequisite patches are unclear to me and
> I didn't find them[1]. I assume it's stuff around
>
> 654c293e1687 mfd: Add Renesas RZ/G2L MTU3a core driver
Yes,
base-commit: 9f258af06b62 is based on Linux-next as PWM git [2], does not have the commit
654c293e1687 'mfd: Add Renesas RZ/G2L MTU3a core driver'
Other patches are not in mainline( config, device tree and CI related).
0001-CI-Add-CI-build.patch
0002-renesas-defconfig.patch
0003-Enable-MTU3.patch
0004-defconfig-Enable-MTU3.patch
0005-renesas_defconfig-Enable-MTU3.patch
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git/log/?qt=grep&q=biju.das&h=for-next
>
> (which is in v6.4-rc1)? I recommend duplicating this information in
> human readable form in the cover letter (or below the --- if it's only a
> single patch).
>
> So this patch was probably not tested by the build bots.
OK, Will resend with base-commit for mainline 6.4-rc1.
Will drop other prerequisite patches.
Cheers,
Biju
> Otherwise I think this is good enough to go in now, so:
>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Thanks
> Uwe
>
prev parent reply other threads:[~2023-06-02 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 17:14 [PATCH v17] pwm: Add Renesas RZ/G2L MTU3a PWM driver Biju Das
2023-06-01 14:08 ` Biju Das
2023-06-02 8:26 ` Uwe Kleine-König
2023-06-02 9:04 ` Biju Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB5922F29548AA079EEB2EA800864EA@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).