From: "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
To: Rob Herring <robh@kernel.org>
Cc: u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org,
lee.jones@linaro.org, thierry.reding@gmail.com,
p.zabel@pengutronix.de, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, andriy.shevchenko@intel.com,
songjun.Wu@intel.com, cheol.yong.kim@intel.com,
qi-ming.wu@intel.com, rahul.tanwar.linux@gmail.com
Subject: Re: [PATCH v6 1/2] Add DT bindings YAML schema for PWM fan controller of LGM SoC
Date: Wed, 12 Aug 2020 11:49:14 +0800 [thread overview]
Message-ID: <e50f198d-42d4-28b1-d32c-32f4b1bbcb0b@linux.intel.com> (raw)
In-Reply-To: <20200731181944.GB516550@bogus>
Hi Rob,
On 1/8/2020 2:19 am, Rob Herring wrote:
> On Tue, Jul 28, 2020 at 04:52:12PM +0800, Rahul Tanwar wrote:
>> Intel's LGM(Lightning Mountain) SoC contains a PWM fan controller
>> which is only used to control the fan attached to the system. This
>> PWM controller does not have any other consumer other than fan.
>> Add DT bindings documentation for this PWM fan controller.
>>
>> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
>> ---
>> .../devicetree/bindings/pwm/intel,lgm-pwm.yaml | 54 ++++++++++++++++++++++
>> 1 file changed, 54 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml b/Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml
>> new file mode 100644
>> index 000000000000..9879972470dc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml
>> @@ -0,0 +1,54 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pwm/intel,lgm-pwm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: LGM SoC PWM fan controller
>> +
>> +maintainers:
>> + - Rahul Tanwar <rahul.tanwar@intel.com>
>> +
>> +properties:
>> + compatible:
>> + const: intel,lgm-pwm
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + "#pwm-cells":
>> + const: 2
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + resets:
>> + maxItems: 1
>> +
>> + intel,fan-wire:
>> + $ref: '/schemas/types.yaml#/definitions/uint32'
>> + description: Specifies fan mode. Default when unspecified is 2.
>> +
>> + intel,max-rpm:
>> + $ref: '/schemas/types.yaml#/definitions/uint32'
>> + description:
>> + Specifies maximum RPM of fan attached to the system.
>> + Default when unspecified is 4000.
> Again, these are properties of a fan, not the pwm controller. They
> belong in a fan node.
Our PWM controller is actually a PWM fan controller dedicated for
controlling fan. I am looking for some suggestions from you on how
to handle fan related optional properties in such a scenario.
Should i create a separate child node for fan with PWM node being
the parent? Is that what you are suggesting? Thanks.
Regards,
Rahul
next prev parent reply other threads:[~2020-08-12 3:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 8:52 [PATCH v6 0/2] pwm: intel: Add PWM driver for a new SoC Rahul Tanwar
2020-07-28 8:52 ` [PATCH v6 1/2] Add DT bindings YAML schema for PWM fan controller of LGM SoC Rahul Tanwar
2020-07-31 18:18 ` Rob Herring
2020-07-31 18:19 ` Rob Herring
2020-08-12 3:49 ` Tanwar, Rahul [this message]
2020-08-12 6:40 ` Uwe Kleine-König
2020-07-28 8:52 ` [PATCH v6 2/2] Add PWM fan controller driver for " Rahul Tanwar
2020-07-31 19:47 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e50f198d-42d4-28b1-d32c-32f4b1bbcb0b@linux.intel.com \
--to=rahul.tanwar@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=qi-ming.wu@intel.com \
--cc=rahul.tanwar.linux@gmail.com \
--cc=robh@kernel.org \
--cc=songjun.Wu@intel.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).