From: Ray Jui <ray.jui@broadcom.com>
To: Scott Branden <scott.branden@broadcom.com>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"BCM Kernel Feedback" <bcm-kernel-feedback-list@broadcom.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rayagonda Kokatanur" <rayagonda.kokatanur@broadcom.com>
Subject: Re: [PATCH v3] pwm: bcm-iproc: handle clk_get_rate() return
Date: Fri, 17 Jul 2020 16:57:44 -0700 [thread overview]
Message-ID: <ebf62731-29bd-078b-e815-55751c9c7ccf@broadcom.com> (raw)
In-Reply-To: <20200717231954.11695-1-scott.branden@broadcom.com>
On 7/17/2020 4:19 PM, Scott Branden wrote:
> From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>
> Handle clk_get_rate() returning 0 to avoid possible division by zero.
>
> Fixes: daa5abc41c80 ("pwm: Add support for Broadcom iProc PWM controller")
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> Reviewed-off-by: Ray Jui <ray.jui@broadcom.com>
Typo. Should be 'Reviewed-by: Ray Jui <ray.jui@broadcom.com>', :)
>
> ---
> Changes from v2: update commit message to remove <= condition
> as clk_get_rate only returns value >= 0
> ---
> drivers/pwm/pwm-bcm-iproc.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c
> index 1f829edd8ee7..d392a828fc49 100644
> --- a/drivers/pwm/pwm-bcm-iproc.c
> +++ b/drivers/pwm/pwm-bcm-iproc.c
> @@ -85,8 +85,6 @@ static void iproc_pwmc_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
> u64 tmp, multi, rate;
> u32 value, prescale;
>
> - rate = clk_get_rate(ip->clk);
> -
> value = readl(ip->base + IPROC_PWM_CTRL_OFFSET);
>
> if (value & BIT(IPROC_PWM_CTRL_EN_SHIFT(pwm->hwpwm)))
> @@ -99,6 +97,13 @@ static void iproc_pwmc_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
> else
> state->polarity = PWM_POLARITY_INVERSED;
>
> + rate = clk_get_rate(ip->clk);
> + if (rate == 0) {
> + state->period = 0;
> + state->duty_cycle = 0;
> + return;
> + }
> +
> value = readl(ip->base + IPROC_PWM_PRESCALE_OFFSET);
> prescale = value >> IPROC_PWM_PRESCALE_SHIFT(pwm->hwpwm);
> prescale &= IPROC_PWM_PRESCALE_MAX;
>
prev parent reply other threads:[~2020-07-17 23:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 23:19 [PATCH v3] pwm: bcm-iproc: handle clk_get_rate() return Scott Branden
2020-07-17 23:57 ` Ray Jui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebf62731-29bd-078b-e815-55751c9c7ccf@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).