linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Ni <xni@redhat.com>
To: linux-raid@vger.kernel.org, song@kernel.org
Cc: heinzm@redhat.com, ncroxon@redhat.com,
	guoqing.jiang@cloud.ionos.com, colyli@suse.de
Subject: [PATCH V6 0/3] md/raid10: Improve handling raid10 discard request
Date: Wed,  2 Sep 2020 20:00:20 +0800	[thread overview]
Message-ID: <1599048023-9957-1-git-send-email-xni@redhat.com> (raw)

Hi all

Now mkfs on raid10 which is combined with ssd/nvme disks takes a long time.
This patch set tries to resolve this problem.

v1:
Coly helps to review these patches and give some suggestions:
One bug is found. If discard bio is across one stripe but bio size is
bigger than one stripe size. After spliting, the bio will be NULL.
In this version, it checks whether discard bio size is bigger than
(2*stripe_size). 
In raid10_end_discard_request, it's better to check R10BIO_Uptodate
is set or not. It can avoid write memory to improve performance. 
Add more comments for calculating addresses.

v2:
Fix error by checkpatch.pl
Fix one bug for offset layout. v1 calculates wrongly split size
Add more comments to explain how the discard range of each component disk
is decided.

v3:
add support for far layout
Change the patch name

v4:
Pull codes that wait for blocked device into a seprate function
It can't use (stripe_size-1) as a mask to calculate. (stripe_size-1) may
not be power of 2.
It doesn't need to use a full copy of geo.
Fix warning by checkpatch.pl

v5:
In 32bit platform, it doesn't support 64bit devide by 32bit value.
Reported-by: kernel test robot <lkp@intel.com>

v6:
Move the codes that calculate discard start/size into specific raid type.
Remove discard support for reshape

Xiao Ni (3):
  md: calculate discard start address and size in specific raid type
  md/raid10: improve raid10 discard request
  md/raid10: improve discard request for far layout

 drivers/md/md.c     |   9 +-
 drivers/md/md.h     |   3 +-
 drivers/md/raid0.c  |   5 +-
 drivers/md/raid10.c | 296 +++++++++++++++++++++++++++++++++++++++++++++++++++-
 drivers/md/raid10.h |   1 +
 5 files changed, 303 insertions(+), 11 deletions(-)

-- 
2.7.5


             reply	other threads:[~2020-09-02 12:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02 12:00 Xiao Ni [this message]
2020-09-02 12:00 ` [PATCH V6 1/3] md: calculate discard start address and size in specific raid type Xiao Ni
2020-09-02 12:00 ` [PATCH V6 2/3] md/raid10: improve raid10 discard request Xiao Ni
2020-09-02 12:00 ` [PATCH V6 3/3] md/raid10: improve discard request for far layout Xiao Ni
2020-09-02 12:04 ` [PATCH V6 0/3] md/raid10: Improve handling raid10 discard request Xiao Ni
2020-09-15  6:29 ` Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1599048023-9957-1-git-send-email-xni@redhat.com \
    --to=xni@redhat.com \
    --cc=colyli@suse.de \
    --cc=guoqing.jiang@cloud.ionos.com \
    --cc=heinzm@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=ncroxon@redhat.com \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).