From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9063AC2BBD1 for ; Thu, 17 Sep 2020 09:41:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 677932076D for ; Thu, 17 Sep 2020 09:41:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726493AbgIQJlV (ORCPT ); Thu, 17 Sep 2020 05:41:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:49702 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbgIQJlU (ORCPT ); Thu, 17 Sep 2020 05:41:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B6C92AFE5; Thu, 17 Sep 2020 09:41:47 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id B26A41E12E1; Thu, 17 Sep 2020 11:41:13 +0200 (CEST) Date: Thu, 17 Sep 2020 11:41:13 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Song Liu , Hans de Goede , Richard Weinberger , Minchan Kim , linux-mtd@lists.infradead.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Johannes Thumshirn Subject: Re: [PATCH 01/12] fs: remove the unused SB_I_MULTIROOT flag Message-ID: <20200917094113.GH7347@quack2.suse.cz> References: <20200910144833.742260-1-hch@lst.de> <20200910144833.742260-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910144833.742260-2-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On Thu 10-09-20 16:48:21, Christoph Hellwig wrote: > The last user of SB_I_MULTIROOT is disappeared with commit f2aedb713c28 > ("NFS: Add fs_context support.") > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn Nice. You can add: Reviewed-by: Jan Kara Honza > --- > fs/namei.c | 4 ++-- > include/linux/fs.h | 1 - > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/namei.c b/fs/namei.c > index e99e2a9da0f7de..f1eb8ccd2be958 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -568,8 +568,8 @@ static bool path_connected(struct vfsmount *mnt, struct dentry *dentry) > { > struct super_block *sb = mnt->mnt_sb; > > - /* Bind mounts and multi-root filesystems can have disconnected paths */ > - if (!(sb->s_iflags & SB_I_MULTIROOT) && (mnt->mnt_root == sb->s_root)) > + /* Bind mounts can have disconnected paths */ > + if (mnt->mnt_root == sb->s_root) > return true; > > return is_subdir(dentry, mnt->mnt_root); > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 7519ae003a082c..fbd74df5ce5f34 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1385,7 +1385,6 @@ extern int send_sigurg(struct fown_struct *fown); > #define SB_I_CGROUPWB 0x00000001 /* cgroup-aware writeback enabled */ > #define SB_I_NOEXEC 0x00000002 /* Ignore executables on this fs */ > #define SB_I_NODEV 0x00000004 /* Ignore devices on this fs */ > -#define SB_I_MULTIROOT 0x00000008 /* Multiple roots to the dentry tree */ > > /* sb->s_iflags to limit user namespace mounts */ > #define SB_I_USERNS_VISIBLE 0x00000010 /* fstype already mounted */ > -- > 2.28.0 > -- Jan Kara SUSE Labs, CR