From: Jakub Radtke <jakub.radtke@linux.intel.com>
To: jes@trained-monkey.org
Cc: linux-raid@vger.kernel.org
Subject: [PATCH 1/8] Modify mdstat parsing for volumes with the bitmap
Date: Thu, 24 Sep 2020 20:02:57 -0400 [thread overview]
Message-ID: <20200925000304.169728-2-jakub.radtke@linux.intel.com> (raw)
In-Reply-To: <20200925000304.169728-1-jakub.radtke@linux.intel.com>
From: Jakub Radtke <jakub.radtke@intel.com>
Current mdstat read functionality is not working correctly
for the volumes with the write-intent bitmap.
It affects rebuild and reshape use cases.
Signed-off-by: Jakub Radtke <jakub.radtke@intel.com>
Change-Id: I5288fbfb7d6a85b2aa8452675a6e3559bf4fe934
---
mdstat.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/mdstat.c b/mdstat.c
index dd96cca7..2fd792c5 100644
--- a/mdstat.c
+++ b/mdstat.c
@@ -191,6 +191,12 @@ struct mdstat_ent *mdstat_read(int hold, int start)
else if (strcmp(w, "inactive") == 0) {
ent->active = 0;
in_devs = 1;
+ } else if (strcmp(w, "bitmap:") == 0) {
+ /* We need to stop parsing here;
+ * otherwise, ent->raid_disks will be
+ * overwritten by the wrong value.
+ */
+ break;
} else if (ent->active > 0 &&
ent->level == NULL &&
w[0] != '(' /*readonly*/) {
--
2.26.2
next prev parent reply other threads:[~2021-03-05 12:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 0:02 [PATCH 0/8] Write-intent bitmap support for IMSM metadata Jakub Radtke
2020-09-25 0:02 ` Jakub Radtke [this message]
2020-09-25 0:02 ` [PATCH 2/8] Enable bitmap support for external metadata Jakub Radtke
2020-09-25 0:02 ` [PATCH 3/8] imsm: Write-intent bitmap support Jakub Radtke
2020-09-25 0:03 ` [PATCH 4/8] imsm: Adding a spare to an existing array with bitmap Jakub Radtke
2020-09-25 0:03 ` [PATCH 5/8] Add "bitmap" to allowed command-line values Jakub Radtke
2020-09-25 0:03 ` [PATCH 6/8] imsm: Update-subarray for write-intent bitmap Jakub Radtke
2020-09-25 0:03 ` [PATCH 7/8] Create: Block automatic enabling bitmap for external metadata Jakub Radtke
2020-09-25 0:03 ` [PATCH 8/8] Grow: Block reshape when external metadata and write-intent bitmap Jakub Radtke
2021-01-15 5:46 [PATCH 0/8] Write-intent bitmap support for IMSM metadata Jakub Radtke
2021-01-15 5:46 ` [PATCH 1/8] Modify mdstat parsing for volumes with the bitmap Jakub Radtke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925000304.169728-2-jakub.radtke@linux.intel.com \
--to=jakub.radtke@linux.intel.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).