Linux-Raid Archives on lore.kernel.org
 help / color / Atom feed
* [PATCH] Make target to install binaries only
@ 2020-10-16  8:49 Kinga Tanska
  2020-10-21  0:44 ` Nix
  0 siblings, 1 reply; 4+ messages in thread
From: Kinga Tanska @ 2020-10-16  8:49 UTC (permalink / raw)
  To: linux-raid; +Cc: jes.sorensen

Make install causes installation of binaries, udev and man.
This commit contains new target make install-bin, which
results in installation of binaries only.

Signed-off-by: Kinga Tanska <kinga.tanska@intel.com>
---
 Makefile | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 15d05d14..92150dbf 100644
--- a/Makefile
+++ b/Makefile
@@ -245,9 +245,7 @@ $(MON_OBJS) : $(INCL) mdmon.h
 sha1.o : sha1.c sha1.h md5.h
 	$(CC) $(CFLAGS) -DHAVE_STDINT_H -o sha1.o -c sha1.c
 
-install : mdadm mdmon install-man install-udev
-	$(INSTALL) -D $(STRIP) -m 755 mdadm $(DESTDIR)$(BINDIR)/mdadm
-	$(INSTALL) -D $(STRIP) -m 755 mdmon $(DESTDIR)$(BINDIR)/mdmon
+install : install-binaries install-man install-udev
 
 install-static : mdadm.static install-man
 	$(INSTALL) -D $(STRIP) -m 755 mdadm.static $(DESTDIR)$(BINDIR)/mdadm
@@ -297,6 +295,10 @@ install-systemd: systemd/mdmon@.service
 	done
 	if [ -f /etc/SuSE-release -o -n "$(SUSE)" ] ;then $(INSTALL) -D -m 755 systemd/SUSE-mdadm_env.sh $(DESTDIR)$(LIB_DIR)/mdadm_env.sh ;fi
 
+install-binaries: mdadm mdmon
+	$(INSTALL) -D $(STRIP) -m 755 mdadm $(DESTDIR)$(BINDIR)/mdadm
+	$(INSTALL) -D $(STRIP) -m 755 mdmon $(DESTDIR)$(BINDIR)/mdmon
+
 uninstall:
 	rm -f $(DESTDIR)$(MAN8DIR)/mdadm.8 $(DESTDIR)$(MAN8DIR)/mdmon.8 $(DESTDIR)$(MAN4DIR)/md.4 $(DESTDIR)$(MAN5DIR)/mdadm.conf.5 $(DESTDIR)$(BINDIR)/mdadm
 
-- 
2.16.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Make target to install binaries only
  2020-10-16  8:49 [PATCH] Make target to install binaries only Kinga Tanska
@ 2020-10-21  0:44 ` Nix
  0 siblings, 0 replies; 4+ messages in thread
From: Nix @ 2020-10-21  0:44 UTC (permalink / raw)
  To: Kinga Tanska; +Cc: linux-raid, jes.sorensen

On 16 Oct 2020, Kinga Tanska verbalised:

> Make install causes installation of binaries, udev and man.
> This commit contains new target make install-bin, which
> results in installation of binaries only.

... but the code says:

> +install : install-binaries install-man install-udev
[...]
> +install-binaries: mdadm mdmon

... which is not the same name.

(FWIW, install-bin is definitely the common name for this target.)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Make target to install binaries only
  2020-08-19  9:03 Kinga Tanska
@ 2020-08-25 18:29 ` Nix
  0 siblings, 0 replies; 4+ messages in thread
From: Nix @ 2020-08-25 18:29 UTC (permalink / raw)
  To: Kinga Tanska; +Cc: linux-raid, jes.sorensen

On 19 Aug 2020, Kinga Tanska spake thusly:

> Make install causes installation of binaries, udev and man.
> This commit contains new target make install-bin, which
> results in installation of binaries only.

That would be the conventional name for the target, but...

> +install : install-binaries install-man install-udev
[...]
> +install-binaries: mdadm mdmon

... that's not what you actually called the target.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Make target to install binaries only
@ 2020-08-19  9:03 Kinga Tanska
  2020-08-25 18:29 ` Nix
  0 siblings, 1 reply; 4+ messages in thread
From: Kinga Tanska @ 2020-08-19  9:03 UTC (permalink / raw)
  To: linux-raid; +Cc: jes.sorensen

Make install causes installation of binaries, udev and man.
This commit contains new target make install-bin, which
results in installation of binaries only.

Signed-off-by: Kinga Tanska <kinga.tanska@intel.com>
---
 Makefile | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 15d05d14..92150dbf 100644
--- a/Makefile
+++ b/Makefile
@@ -245,9 +245,7 @@ $(MON_OBJS) : $(INCL) mdmon.h
 sha1.o : sha1.c sha1.h md5.h
 	$(CC) $(CFLAGS) -DHAVE_STDINT_H -o sha1.o -c sha1.c
 
-install : mdadm mdmon install-man install-udev
-	$(INSTALL) -D $(STRIP) -m 755 mdadm $(DESTDIR)$(BINDIR)/mdadm
-	$(INSTALL) -D $(STRIP) -m 755 mdmon $(DESTDIR)$(BINDIR)/mdmon
+install : install-binaries install-man install-udev
 
 install-static : mdadm.static install-man
 	$(INSTALL) -D $(STRIP) -m 755 mdadm.static $(DESTDIR)$(BINDIR)/mdadm
@@ -297,6 +295,10 @@ install-systemd: systemd/mdmon@.service
 	done
 	if [ -f /etc/SuSE-release -o -n "$(SUSE)" ] ;then $(INSTALL) -D -m 755 systemd/SUSE-mdadm_env.sh $(DESTDIR)$(LIB_DIR)/mdadm_env.sh ;fi
 
+install-binaries: mdadm mdmon
+	$(INSTALL) -D $(STRIP) -m 755 mdadm $(DESTDIR)$(BINDIR)/mdadm
+	$(INSTALL) -D $(STRIP) -m 755 mdmon $(DESTDIR)$(BINDIR)/mdmon
+
 uninstall:
 	rm -f $(DESTDIR)$(MAN8DIR)/mdadm.8 $(DESTDIR)$(MAN8DIR)/mdmon.8 $(DESTDIR)$(MAN4DIR)/md.4 $(DESTDIR)$(MAN5DIR)/mdadm.conf.5 $(DESTDIR)$(BINDIR)/mdadm
 
-- 
2.16.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16  8:49 [PATCH] Make target to install binaries only Kinga Tanska
2020-10-21  0:44 ` Nix
  -- strict thread matches above, loose matches on Subject: below --
2020-08-19  9:03 Kinga Tanska
2020-08-25 18:29 ` Nix

Linux-Raid Archives on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-raid/0 linux-raid/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-raid linux-raid/ https://lore.kernel.org/linux-raid \
		linux-raid@vger.kernel.org
	public-inbox-index linux-raid

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-raid


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git