Linux-Raid Archives on lore.kernel.org
 help / color / Atom feed
* [PATCH AUTOSEL 5.4 03/26] dm integrity: select CRYPTO_SKCIPHER
       [not found] <20210120012704.770095-1-sashal@kernel.org>
@ 2021-01-20  1:26 ` Sasha Levin
  2021-01-20  5:47   ` [dm-devel] " Eric Biggers
  0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2021-01-20  1:26 UTC (permalink / raw)
  To: linux-kernel, stable
  Cc: Anthony Iliopoulos, Mike Snitzer, Sasha Levin, dm-devel, linux-raid

From: Anthony Iliopoulos <ailiop@suse.com>

[ Upstream commit f7b347acb5f6c29d9229bb64893d8b6a2c7949fb ]

The integrity target relies on skcipher for encryption/decryption, but
certain kernel configurations may not enable CRYPTO_SKCIPHER, leading to
compilation errors due to unresolved symbols. Explicitly select
CRYPTO_SKCIPHER for DM_INTEGRITY, since it is unconditionally dependent
on it.

Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/md/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
index aa98953f4462e..7dd6e98257c72 100644
--- a/drivers/md/Kconfig
+++ b/drivers/md/Kconfig
@@ -565,6 +565,7 @@ config DM_INTEGRITY
 	select BLK_DEV_INTEGRITY
 	select DM_BUFIO
 	select CRYPTO
+	select CRYPTO_SKCIPHER
 	select ASYNC_XOR
 	---help---
 	  This device-mapper target emulates a block device that has
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dm-devel] [PATCH AUTOSEL 5.4 03/26] dm integrity: select CRYPTO_SKCIPHER
  2021-01-20  1:26 ` [PATCH AUTOSEL 5.4 03/26] dm integrity: select CRYPTO_SKCIPHER Sasha Levin
@ 2021-01-20  5:47   ` Eric Biggers
  2021-02-05  0:28     ` Sasha Levin
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2021-01-20  5:47 UTC (permalink / raw)
  To: Sasha Levin
  Cc: linux-kernel, stable, Anthony Iliopoulos, dm-devel, linux-raid,
	Mike Snitzer

On Tue, Jan 19, 2021 at 08:26:40PM -0500, Sasha Levin wrote:
> From: Anthony Iliopoulos <ailiop@suse.com>
> 
> [ Upstream commit f7b347acb5f6c29d9229bb64893d8b6a2c7949fb ]
> 
> The integrity target relies on skcipher for encryption/decryption, but
> certain kernel configurations may not enable CRYPTO_SKCIPHER, leading to
> compilation errors due to unresolved symbols. Explicitly select
> CRYPTO_SKCIPHER for DM_INTEGRITY, since it is unconditionally dependent
> on it.
> 
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  drivers/md/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index aa98953f4462e..7dd6e98257c72 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -565,6 +565,7 @@ config DM_INTEGRITY
>  	select BLK_DEV_INTEGRITY
>  	select DM_BUFIO
>  	select CRYPTO
> +	select CRYPTO_SKCIPHER
>  	select ASYNC_XOR
>  	---help---
>  	  This device-mapper target emulates a block device that has

CRYPTO_SKCIPHER doesn't exist in 5.4 and earlier because it was renamed from
CRYPTO_BLKCIPHER in 5.5.  If this patch is really important enough to backport,
CRYPTO_SKCIPHER will need to be changed to CRYPTO_BLKCIPHER.

- Eric

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dm-devel] [PATCH AUTOSEL 5.4 03/26] dm integrity: select CRYPTO_SKCIPHER
  2021-01-20  5:47   ` [dm-devel] " Eric Biggers
@ 2021-02-05  0:28     ` Sasha Levin
  0 siblings, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2021-02-05  0:28 UTC (permalink / raw)
  To: Eric Biggers
  Cc: linux-kernel, stable, Anthony Iliopoulos, dm-devel, linux-raid,
	Mike Snitzer

On Tue, Jan 19, 2021 at 09:47:31PM -0800, Eric Biggers wrote:
>On Tue, Jan 19, 2021 at 08:26:40PM -0500, Sasha Levin wrote:
>> From: Anthony Iliopoulos <ailiop@suse.com>
>>
>> [ Upstream commit f7b347acb5f6c29d9229bb64893d8b6a2c7949fb ]
>>
>> The integrity target relies on skcipher for encryption/decryption, but
>> certain kernel configurations may not enable CRYPTO_SKCIPHER, leading to
>> compilation errors due to unresolved symbols. Explicitly select
>> CRYPTO_SKCIPHER for DM_INTEGRITY, since it is unconditionally dependent
>> on it.
>>
>> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
>> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>>  drivers/md/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
>> index aa98953f4462e..7dd6e98257c72 100644
>> --- a/drivers/md/Kconfig
>> +++ b/drivers/md/Kconfig
>> @@ -565,6 +565,7 @@ config DM_INTEGRITY
>>  	select BLK_DEV_INTEGRITY
>>  	select DM_BUFIO
>>  	select CRYPTO
>> +	select CRYPTO_SKCIPHER
>>  	select ASYNC_XOR
>>  	---help---
>>  	  This device-mapper target emulates a block device that has
>
>CRYPTO_SKCIPHER doesn't exist in 5.4 and earlier because it was renamed from
>CRYPTO_BLKCIPHER in 5.5.  If this patch is really important enough to backport,
>CRYPTO_SKCIPHER will need to be changed to CRYPTO_BLKCIPHER.

I'll just drop it, thanks!

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210120012704.770095-1-sashal@kernel.org>
2021-01-20  1:26 ` [PATCH AUTOSEL 5.4 03/26] dm integrity: select CRYPTO_SKCIPHER Sasha Levin
2021-01-20  5:47   ` [dm-devel] " Eric Biggers
2021-02-05  0:28     ` Sasha Levin

Linux-Raid Archives on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-raid/0 linux-raid/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-raid linux-raid/ https://lore.kernel.org/linux-raid \
		linux-raid@vger.kernel.org
	public-inbox-index linux-raid

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-raid


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git