From: Christoph Hellwig <hch@infradead.org>
To: Xiao Ni <xni@redhat.com>
Cc: songliubraving@fb.com, linux-raid@vger.kernel.org,
matthew.ruffell@canonical.com, colyli@suse.de,
guoqing.jiang@cloud.ionos.com, ncroxon@redhat.com
Subject: Re: [PATCH 1/5] md: add md_submit_discard_bio() for submitting discard bio
Date: Wed, 3 Feb 2021 15:44:25 +0000 [thread overview]
Message-ID: <20210203154425.GA4078626@infradead.org> (raw)
In-Reply-To: <1612359931-24209-2-git-send-email-xni@redhat.com>
On Wed, Feb 03, 2021 at 09:45:27PM +0800, Xiao Ni wrote:
> + if (__blkdev_issue_discard(rdev->bdev, start, size,
> + GFP_NOIO, 0, &discard_bio) || !discard_bio)
> + return;
Very odd indentation. Normally this would be:
if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, 0,
&discard_bio) || !discard_bio)
return;
> +
> + bio_chain(discard_bio, bio);
> + bio_clone_blkg_association(discard_bio, bio);
> + if (mddev->gendisk)
> + trace_block_bio_remap(discard_bio,
> + disk_devt(mddev->gendisk),
> + bio->bi_iter.bi_sector);
> + submit_bio_noacct(discard_bio);
> +}
> +EXPORT_SYMBOL(md_submit_discard_bio);
EXPORT_SYMBOL_GPL like all the other exports in md.c, please.
> +extern void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev,
> + struct bio *bio, sector_t start, sector_t size);
no need for the extern.
next prev parent reply other threads:[~2021-02-03 15:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 13:45 [PATCH 0/5] md/raid10: Improve handling raid10 discard request Xiao Ni
2021-02-03 13:45 ` [PATCH 1/5] md: add md_submit_discard_bio() for submitting discard bio Xiao Ni
2021-02-03 15:44 ` Christoph Hellwig [this message]
2021-02-04 1:51 ` Xiao Ni
2021-02-04 4:07 ` Xiao Ni
2021-02-04 7:19 ` Christoph Hellwig
2021-02-04 7:37 ` Xiao Ni
2021-02-03 13:45 ` [PATCH 2/5] md/raid10: extend r10bio devs to raid disks Xiao Ni
2021-02-03 15:44 ` Christoph Hellwig
2021-02-03 13:45 ` [PATCH 3/5] md/raid10: pull codes that wait for blocked dev into one function Xiao Ni
2021-02-03 15:46 ` Christoph Hellwig
2021-02-04 1:54 ` Xiao Ni
2021-02-03 13:45 ` [PATCH 4/5] md/raid10: improve raid10 discard request Xiao Ni
2021-02-03 15:50 ` Christoph Hellwig
2021-02-04 2:00 ` Xiao Ni
2021-02-03 13:45 ` [PATCH 5/5] md/raid10: improve discard request for far layout Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203154425.GA4078626@infradead.org \
--to=hch@infradead.org \
--cc=colyli@suse.de \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=linux-raid@vger.kernel.org \
--cc=matthew.ruffell@canonical.com \
--cc=ncroxon@redhat.com \
--cc=songliubraving@fb.com \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).