From: Coly Li <colyli@suse.de>
To: "Tkaczyk, Mariusz" <mariusz.tkaczyk@linux.intel.com>
Cc: George Gkioulis <ggkioulis@suse.com>,
Jes Sorensen <jsorensen@fb.com>,
linux-raid@vger.kernel.org
Subject: Re: [PATCH v2] Monitor: print message before quit for no array to monitor
Date: Thu, 2 Sep 2021 15:26:08 +0800 [thread overview]
Message-ID: <478fe598-5529-50ca-aefc-27ad0a4f1ef8@suse.de> (raw)
In-Reply-To: <59b40b04-399a-a0cd-f8be-ebdebe9a458c@linux.intel.com>
On 9/2/21 3:08 PM, Tkaczyk, Mariusz wrote:
> Hi Coly,
> On 02.09.2021 04:36, Coly Li wrote:
>> @@ -258,6 +258,7 @@ int Monitor(struct mddev_dev *devlist,
>> if (oneshot)
>> break;
>> else if (!anyredundant) {
>> + pr_err("Stop for no array to monitor\n");
>> break;
>
> IMO the message is not precise enough. See that if there is only raid0
> then it also stops. Something like:
> "No array with redundancy detected, stopping" is more detailed.
Copied. I will post v3 patch with your suggestion.
Thanks.
Coly Li
prev parent reply other threads:[~2021-09-02 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 2:36 [PATCH v2] Monitor: print message before quit for no array to monitor Coly Li
2021-09-02 7:08 ` Tkaczyk, Mariusz
2021-09-02 7:26 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478fe598-5529-50ca-aefc-27ad0a4f1ef8@suse.de \
--to=colyli@suse.de \
--cc=ggkioulis@suse.com \
--cc=jsorensen@fb.com \
--cc=linux-raid@vger.kernel.org \
--cc=mariusz.tkaczyk@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).