From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B70EAC28E83 for ; Fri, 4 Sep 2020 10:28:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CB2A20791 for ; Fri, 4 Sep 2020 10:28:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729961AbgIDK2h (ORCPT ); Fri, 4 Sep 2020 06:28:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:46696 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbgIDK2g (ORCPT ); Fri, 4 Sep 2020 06:28:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A59E9AF6D; Fri, 4 Sep 2020 10:28:35 +0000 (UTC) Subject: Re: [PATCH 15/19] amiflop: use separate gendisks for Amiga vs MS-DOS mode To: Christoph Hellwig , Jens Axboe Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Denis Efremov , "David S. Miller" , Song Liu , Al Viro , Finn Thain , Michael Schmitz , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, linux-m68k@lists.linux-m68k.org References: <20200903080119.441674-1-hch@lst.de> <20200903080119.441674-16-hch@lst.de> From: Hannes Reinecke Message-ID: <55a79fd2-aa85-a687-0f17-60fa05830cf2@suse.de> Date: Fri, 4 Sep 2020 12:28:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200903080119.441674-16-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-raid-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On 9/3/20 10:01 AM, Christoph Hellwig wrote: > Use separate gendisks (which share a tag_set) for the native Amgiga vs > the MS-DOS mode instead of redirecting the gendisk lookup using a probe > callback. This avoids potential problems with aliased block_device > instances and will eventually allow for removing the blk_register_region > framework. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/amiflop.c | 98 +++++++++++++++++++++++------------------ > 1 file changed, 55 insertions(+), 43 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer