linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Song Liu <song@kernel.org>, linux-raid@vger.kernel.org
Cc: yukuai1@huaweicloud.com, Dan Moulding <dan@danm.net>,
	stable@vger.kernel.org, Junxiao Bi <junxiao.bi@oracle.com>,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] Revert "Revert "md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d""
Date: Thu, 25 Jan 2024 19:49:10 +0800	[thread overview]
Message-ID: <626f3f93-7085-7bd4-2172-3f97fcf197c9@huaweicloud.com> (raw)
In-Reply-To: <20240125082131.788600-1-song@kernel.org>

在 2024/01/25 16:21, Song Liu 写道:
> This reverts commit bed9e27baf52a09b7ba2a3714f1e24e17ced386d.
> 
> The original set [1][2] was expected to undo a suboptimal fix in [2], and
> replace it with a better fix [1]. However, as reported by Dan Moulding [2]
> causes an issue with raid5 with journal device.
> 
> Revert [2] for now to close the issue. We will follow up on another issue
> reported by Juxiao Bi, as [2] is expected to fix it. We believe this is a
> good trade-off, because the latter issue happens less freqently.
> 
> In the meanwhile, we will NOT revert [1], as it contains the right logic.
> 
> Reported-by: Dan Moulding<dan@danm.net>
> Closes:https://lore.kernel.org/linux-raid/20240123005700.9302-1-dan@danm.net/
> Fixes: bed9e27baf52 ("Revert "md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d"")
> Cc:stable@vger.kernel.org  # v5.19+
> Cc: Junxiao Bi<junxiao.bi@oracle.com>
> Cc: Yu Kuai<yukuai3@huawei.com>
> Signed-off-by: Song Liu<song@kernel.org>
> 
> [1] commit d6e035aad6c0 ("md: bypass block throttle for superblock update")
> [2] commit bed9e27baf52 ("Revert "md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d"")

LGTM
Reviewed-by: Yu Kuai <yukuai3@huawei.com>


  reply	other threads:[~2024-01-25 11:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25  8:21 [PATCH] Revert "Revert "md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d"" Song Liu
2024-01-25 11:49 ` Yu Kuai [this message]
2024-01-25 15:48 ` Dan Moulding
2024-01-25 16:55 ` junxiao.bi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=626f3f93-7085-7bd4-2172-3f97fcf197c9@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=dan@danm.net \
    --cc=junxiao.bi@oracle.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).