From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 223D4C4742C for ; Wed, 11 Nov 2020 10:06:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A61ED20674 for ; Wed, 11 Nov 2020 10:06:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="EWvaurrQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727402AbgKKKG5 (ORCPT ); Wed, 11 Nov 2020 05:06:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727382AbgKKKGz (ORCPT ); Wed, 11 Nov 2020 05:06:55 -0500 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C4C5C0617A6 for ; Wed, 11 Nov 2020 02:06:55 -0800 (PST) Received: by mail-ej1-x642.google.com with SMTP id s25so1964714ejy.6 for ; Wed, 11 Nov 2020 02:06:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8BVYeCUTuKi3mlr+D1JejV3WQ4DReZqKao2un+osJdI=; b=EWvaurrQLE5Q4yXlmvtPWeVGE0dkpLilBhFACYcpJh5SLgD4k2LHFrfA3fg/phe+gw pOXsWhTko+6vmsPMUys1ydyafND8sfafc/BhJ0cLDqzJH5wv7CFdS4PBi4SJJirndEDo I3sopJwAoMSpcvKBGOBbJDfAHPo19nxrr5mYxmaUjZAtoeSEinoAPgcqf0tp4SGruWUm s+puyVNd/9QM59nJCHGxgwiF4Uhv/qkw3Bh4E6NoIJN/jPJN6bl5siKGHhBBHVdEhBTl i9cN1zoK+m/ZDFXKRJbDKDgS4Hb/xEaLU1cJNAhSo0nBcfuCpt/4xbdL/4qVB2KjPelC haxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8BVYeCUTuKi3mlr+D1JejV3WQ4DReZqKao2un+osJdI=; b=l3pAAYviN2j44tD684d9q/Cicv8skWm77sTgF4UlPQ9/TCwOZI9a0/PAWud7Sbx+w+ XM3ioLreo5B+v+Q9fxSXiDaZqEWuXmpNorzyeAqpM2jyX+mtdlhyCQ263URil4sjt3Fq VuBHE3IoFWjLUZtBT0XKp93uFElMy7PVtxiuQW3UNg3fMTMv0xOPatjEBvJE24EWaFVr e/LztRp4hlaHATQwQFv0S5wWcTge9t7GAHAJvPV27wIn+q+1V6n8xHnIc6aPe4GgCeHD 27UBopoHIjTcromuoyKPlFn5jsB3orREFGL0JqA8HPeTt5LEVkkPalVy1B/SiTmroN3h AFLg== X-Gm-Message-State: AOAM533PJzF1aEI4LQ5Z9QD20LgUU9519fuSsA6Wzegz4yhVv795qu87 M5VvV+TX0dkM27U+ARfxCgTCdawQf+YVDaxyGKViBQ== X-Google-Smtp-Source: ABdhPJzsSG4n+ejxAi7LIm+JtRF2XZ0Zmfdo/Dim1Bn2zjoT1vntwc6k1ciTHUd7GwTXoyYPdOeDF7UWMmfnel/IKPk= X-Received: by 2002:a17:907:c05:: with SMTP id ga5mr19170455ejc.212.1605089213881; Wed, 11 Nov 2020 02:06:53 -0800 (PST) MIME-Version: 1.0 References: <20201111082658.3401686-1-hch@lst.de> <20201111082658.3401686-18-hch@lst.de> In-Reply-To: From: Jinpu Wang Date: Wed, 11 Nov 2020 11:06:43 +0100 Message-ID: Subject: Re: [PATCH 17/24] rbd: use set_capacity_and_notify To: Ilya Dryomov Cc: Christoph Hellwig , Jens Axboe , Justin Sanders , Josef Bacik , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Minchan Kim , Mike Snitzer , Song Liu , "Martin K. Petersen" , device-mapper development , linux-block , Lars Ellenberg , nbd@other.debian.org, Ceph Development , xen-devel@lists.xenproject.org, linux-raid , linux-nvme@lists.infradead.org, Linux SCSI Mailinglist , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On Wed, Nov 11, 2020 at 10:55 AM Ilya Dryomov wrote: > > On Wed, Nov 11, 2020 at 9:27 AM Christoph Hellwig wrote: > > > > Use set_capacity_and_notify to set the size of both the disk and block > > device. This also gets the uevent notifications for the resize for free. > > > > Signed-off-by: Christoph Hellwig > > Acked-by: Jack Wang > > --- > > drivers/block/rbd.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > > index f84128abade319..b7a194ffda55b4 100644 > > --- a/drivers/block/rbd.c > > +++ b/drivers/block/rbd.c > > @@ -4920,8 +4920,7 @@ static void rbd_dev_update_size(struct rbd_device *rbd_dev) > > !test_bit(RBD_DEV_FLAG_REMOVING, &rbd_dev->flags)) { > > size = (sector_t)rbd_dev->mapping.size / SECTOR_SIZE; > > dout("setting size to %llu sectors", (unsigned long long)size); > > - set_capacity(rbd_dev->disk, size); > > - revalidate_disk_size(rbd_dev->disk, true); > > + set_capacity_and_notify(rbd_dev->disk, size); > > } > > } > > > > -- > > 2.28.0 > > > > Hi Christoph, > > The Acked-by is wrong here. I acked this patch (17/24, rbd), and Jack > acked the next one (18/24, rnbd). right. :) > > Thanks, > > Ilya