From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FD0AC5517A for ; Mon, 9 Nov 2020 06:56:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 274BC206E3 for ; Mon, 9 Nov 2020 06:56:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="OlOP6e+h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729391AbgKIG4p (ORCPT ); Mon, 9 Nov 2020 01:56:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728873AbgKIG4p (ORCPT ); Mon, 9 Nov 2020 01:56:45 -0500 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30204C0617A6 for ; Sun, 8 Nov 2020 22:56:45 -0800 (PST) Received: by mail-ed1-x543.google.com with SMTP id o20so7547028eds.3 for ; Sun, 08 Nov 2020 22:56:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lhEWojdnEETMpoDmZaKWZITR453k36pmv/sfAr6vN/Q=; b=OlOP6e+hTTnzcMIwdaF/T/hnfIBf/9oJMDqvqjYzplHIQ4xMgH25+911Ixq0B3+K58 5Dj/JmHZRD8Yi8zqOu+1rKF07XS2mrjA0Wv9PMukIV3uX40Qn/weu/uMdAMCHG7RU935 A8pgkbko6hNqb1nFuLU3A3PiBPYVj8XjATb55mVvvHvMOvvFHanlnCDmyhaMxkXN6DKS Bf5AgcB50gTwwmoZvVJaG5dtCbnwCB8M7N5x+uhcjSrbjJF9nKnn2cuHHSz7I/a4akR/ xE89AMdrexbc31NBbIF2vvHpBBUezGpS6XdWxnMo7c/NgKk9nHTIb/0D5wlGo0gz8gEr D1Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lhEWojdnEETMpoDmZaKWZITR453k36pmv/sfAr6vN/Q=; b=jnF+6vBIdkK1g0ZMdYyctkHQ0q7zBB9ICPe5eljtaWa0p8fmXtTdaINSsVL9pk6yKR fsNJgGlE0FSF1eO2AsagaoOMdT6SIY+0tjdTPhcpNENkQUobIpsC7PLYDD49pt5STZQD +ar3RBhgHxiV1UwYKzw81m+8FU6OR0XnpG9MBrJUMXJ4IoMT9pQl1zSqOa3ALdV2tcJ8 oDpxOh/2L2BIIF6U32xt+9P/+encdMMGXnyVpvxYMSMGdvjOlkl8vGTe09VhHbU5Vjdo MMGN/FU6rK3d1tJRBdfjklttyYUH+rVEQ5MqeBkf3m3UxhxjiNlvm0GQc44Z89scPX8p 7wFg== X-Gm-Message-State: AOAM530oqHxqi0aouZAW/OwMpherGlCWUPUqC/IU0Irnt43mKE1XaQf0 T8SOnBS3V5/+GugQuZWp2m1go7/8372DaYRJfsFfYA== X-Google-Smtp-Source: ABdhPJy5lMTAmAT8/Ewb7MyKs6V0kAUlIo1q9lM6dl2oB700nsAVEi6e4At1FesCFzDNwPnUu593st+zxY/BthW2KiM= X-Received: by 2002:a50:fc89:: with SMTP id f9mr14573990edq.89.1604905003672; Sun, 08 Nov 2020 22:56:43 -0800 (PST) MIME-Version: 1.0 References: <20201106190337.1973127-1-hch@lst.de> <20201106190337.1973127-19-hch@lst.de> In-Reply-To: <20201106190337.1973127-19-hch@lst.de> From: Jinpu Wang Date: Mon, 9 Nov 2020 07:56:32 +0100 Message-ID: Subject: Re: [PATCH 18/24] rnbd: use set_capacity_and_notify To: Christoph Hellwig Cc: Jens Axboe , Justin Sanders , Josef Bacik , Ilya Dryomov , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Minchan Kim , Mike Snitzer , Song Liu , "Martin K. Petersen" , device-mapper development , linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-raid , linux-nvme@lists.infradead.org, Linux SCSI Mailinglist , linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On Fri, Nov 6, 2020 at 8:04 PM Christoph Hellwig wrote: > > Use set_capacity_and_notify to set the size of both the disk and block > device. This also gets the uevent notifications for the resize for free. > > Signed-off-by: Christoph Hellwig Thanks, Christoph! Acked-by: Jack Wang > --- > drivers/block/rnbd/rnbd-clt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c > index 8b2411ccbda97c..bb13d7dd195a08 100644 > --- a/drivers/block/rnbd/rnbd-clt.c > +++ b/drivers/block/rnbd/rnbd-clt.c > @@ -100,8 +100,7 @@ static int rnbd_clt_change_capacity(struct rnbd_clt_dev *dev, > rnbd_clt_info(dev, "Device size changed from %zu to %zu sectors\n", > dev->nsectors, new_nsectors); > dev->nsectors = new_nsectors; > - set_capacity(dev->gd, dev->nsectors); > - revalidate_disk_size(dev->gd, true); > + set_capacity_and_notify(dev->gd, dev->nsectors); > return 0; > } > > -- > 2.28.0 >