From: Ilya Dryomov <idryomov@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Jens Axboe" <axboe@kernel.dk>,
"Justin Sanders" <justin@coraid.com>,
"Josef Bacik" <josef@toxicpanda.com>,
"Jack Wang" <jinpu.wang@cloud.ionos.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Minchan Kim" <minchan@kernel.org>,
"Mike Snitzer" <snitzer@redhat.com>, "Song Liu" <song@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
dm-devel@redhat.com, linux-block <linux-block@vger.kernel.org>,
"Lars Ellenberg" <drbd-dev@lists.linbit.com>,
nbd@other.debian.org,
"Ceph Development" <ceph-devel@vger.kernel.org>,
xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 17/24] rbd: use set_capacity_and_notify
Date: Wed, 11 Nov 2020 10:55:45 +0100 [thread overview]
Message-ID: <CAOi1vP-JjnNdAUqd9Gy6YdFgi8Ev4_Jt3zcB9DhAmdAvQhG7Eg@mail.gmail.com> (raw)
In-Reply-To: <20201111082658.3401686-18-hch@lst.de>
On Wed, Nov 11, 2020 at 9:27 AM Christoph Hellwig <hch@lst.de> wrote:
>
> Use set_capacity_and_notify to set the size of both the disk and block
> device. This also gets the uevent notifications for the resize for free.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
> ---
> drivers/block/rbd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index f84128abade319..b7a194ffda55b4 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -4920,8 +4920,7 @@ static void rbd_dev_update_size(struct rbd_device *rbd_dev)
> !test_bit(RBD_DEV_FLAG_REMOVING, &rbd_dev->flags)) {
> size = (sector_t)rbd_dev->mapping.size / SECTOR_SIZE;
> dout("setting size to %llu sectors", (unsigned long long)size);
> - set_capacity(rbd_dev->disk, size);
> - revalidate_disk_size(rbd_dev->disk, true);
> + set_capacity_and_notify(rbd_dev->disk, size);
> }
> }
>
> --
> 2.28.0
>
Hi Christoph,
The Acked-by is wrong here. I acked this patch (17/24, rbd), and Jack
acked the next one (18/24, rnbd).
Thanks,
Ilya
next prev parent reply other threads:[~2020-11-11 9:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 8:26 cleanup updating the size of block devices v2 Christoph Hellwig
2020-11-11 8:26 ` [PATCH 01/24] block: remove the call to __invalidate_device in check_disk_size_change Christoph Hellwig
2020-11-11 12:46 ` Hannes Reinecke
2020-11-11 8:26 ` [PATCH 02/24] loop: remove loop_set_size Christoph Hellwig
2020-11-11 12:47 ` Hannes Reinecke
2020-11-11 8:26 ` [PATCH 03/24] nvme: let set_capacity_revalidate_and_notify update the bdev size Christoph Hellwig
2020-11-11 13:06 ` Hannes Reinecke
2020-11-11 8:26 ` [PATCH 04/24] sd: update the bdev size in sd_revalidate_disk Christoph Hellwig
2020-11-11 13:07 ` Hannes Reinecke
2020-11-11 8:26 ` [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify Christoph Hellwig
2020-11-11 13:07 ` Hannes Reinecke
2020-11-12 19:22 ` Petr Vorel
2020-11-11 8:26 ` [PATCH 06/24] block: add a return value to set_capacity_and_notify Christoph Hellwig
2020-11-11 13:08 ` Hannes Reinecke
2020-11-11 8:26 ` [PATCH 07/24] nbd: remove the call to set_blocksize Christoph Hellwig
2020-11-11 8:26 ` [PATCH 08/24] nbd: move the task_recv check into nbd_size_update Christoph Hellwig
2020-11-11 8:26 ` [PATCH 09/24] nbd: refactor size updates Christoph Hellwig
2020-11-11 8:26 ` [PATCH 10/24] nbd: validate the block size in nbd_set_size Christoph Hellwig
2020-11-11 8:26 ` [PATCH 11/24] nbd: use set_capacity_and_notify Christoph Hellwig
2020-11-11 8:26 ` [PATCH 12/24] aoe: don't call set_capacity from irq context Christoph Hellwig
2020-11-11 8:26 ` [PATCH 13/24] dm: use set_capacity_and_notify Christoph Hellwig
2020-11-11 13:57 ` Hannes Reinecke
2020-11-11 8:26 ` [PATCH 14/24] pktcdvd: " Christoph Hellwig
2020-11-11 8:26 ` [PATCH 15/24] nvme: use set_capacity_and_notify in nvme_set_queue_dying Christoph Hellwig
2020-11-11 13:59 ` Hannes Reinecke
2020-11-11 8:26 ` [PATCH 16/24] drbd: use set_capacity_and_notify Christoph Hellwig
2020-11-11 8:26 ` [PATCH 17/24] rbd: " Christoph Hellwig
2020-11-11 9:55 ` Ilya Dryomov [this message]
2020-11-11 10:06 ` Jinpu Wang
2020-11-11 8:26 ` [PATCH 18/24] rnbd: " Christoph Hellwig
2020-11-11 8:26 ` [PATCH 19/24] zram: " Christoph Hellwig
2020-11-11 8:26 ` [PATCH 20/24] dm-raid: " Christoph Hellwig
2020-11-11 14:00 ` Hannes Reinecke
2020-11-11 8:26 ` [PATCH 21/24] md: " Christoph Hellwig
2020-11-11 8:26 ` [PATCH 22/24] md: remove a spurious call to revalidate_disk_size in update_size Christoph Hellwig
2020-11-11 8:26 ` [PATCH 23/24] virtio-blk: remove a spurious call to revalidate_disk_size Christoph Hellwig
2020-11-11 8:26 ` [PATCH 24/24] block: unexport revalidate_disk_size Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-11-06 19:03 cleanup updating the size of block devices Christoph Hellwig
2020-11-06 19:03 ` [PATCH 17/24] rbd: use set_capacity_and_notify Christoph Hellwig
2020-11-09 13:52 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOi1vP-JjnNdAUqd9Gy6YdFgi8Ev4_Jt3zcB9DhAmdAvQhG7Eg@mail.gmail.com \
--to=idryomov@gmail.com \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=josef@toxicpanda.com \
--cc=justin@coraid.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=minchan@kernel.org \
--cc=mst@redhat.com \
--cc=nbd@other.debian.org \
--cc=pbonzini@redhat.com \
--cc=roger.pau@citrix.com \
--cc=snitzer@redhat.com \
--cc=song@kernel.org \
--cc=stefanha@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).