From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EEF9C433E0 for ; Wed, 27 Jan 2021 07:26:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BA6320663 for ; Wed, 27 Jan 2021 07:26:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233678AbhA0HZl (ORCPT ); Wed, 27 Jan 2021 02:25:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:48704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233735AbhA0HXm (ORCPT ); Wed, 27 Jan 2021 02:23:42 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3B9EF2074B; Wed, 27 Jan 2021 07:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611732179; bh=wys3sZM3KFLi7kSDIT+8OH9R8Mzfn9WfVwnN3287ktM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Bec44/no8t56Z502LgnlM+Qg3a7iRfwb8LyhJ+o5g82IaOznb97Gk8xlDwtFm7y0Q 4B+/tC5K9lGgUBiHyhE00pi36rFGRQbfNmoExpX38MvaaIEiIlo5Xpl02zb3d2+c9I 6QT/NDPMg5Mj36lJBF9f+RFUcTIY2MmljvRbc0DiIULgDdoXmR4KXliM+gH3VlyPk6 mHWoOAExmkNvS6m/z6G7b4ZdKBJLDixAbo/Wzlpm3cgdfJxA927Fy/aSbJhFzA/wq4 2ciHhZnN+TzrdwTTB4DOYnCFwWnsw1IL4QMJJGrVzDQalyZsi3zFFnOCUMa/DMqtOX AkooKL+eqRW2g== Received: by mail-lj1-f174.google.com with SMTP id 3so909613ljc.4; Tue, 26 Jan 2021 23:22:59 -0800 (PST) X-Gm-Message-State: AOAM531YWoDEJpp8cDQgEYHd2BYi206VyMREUIK+5Ba7zozGspXdzCHp c+jh1CywFVUWO0gArFcLfSpkGUIVPc6m/ZhnXsY= X-Google-Smtp-Source: ABdhPJwT4SgEWFQYI+aGplxcgngrqXZ09YVZXq+be6TcwdS2L0sd+F5PxgqsedykGzzK3GAh/e6zF7ilKInCLGcj5r0= X-Received: by 2002:a2e:b8d3:: with SMTP id s19mr5116366ljp.97.1611732177533; Tue, 26 Jan 2021 23:22:57 -0800 (PST) MIME-Version: 1.0 References: <20210126145247.1964410-1-hch@lst.de> <20210126145247.1964410-14-hch@lst.de> In-Reply-To: <20210126145247.1964410-14-hch@lst.de> From: Song Liu Date: Tue, 26 Jan 2021 23:22:46 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 13/17] md: remove md_bio_alloc_sync To: Christoph Hellwig Cc: Jens Axboe , Jaegeuk Kim , Chao Yu , Philipp Reisner , Lars Ellenberg , Coly Li , Mike Snitzer , Josef Bacik , David Sterba , Damien Le Moal , Naohiro Aota , Andrew Morton , Ryusuke Konishi , linux-nilfs@vger.kernel.org, dm-devel@redhat.com, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid , Linux-Fsdevel , linux-btrfs@vger.kernel.org, linux-nfs@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On Tue, Jan 26, 2021 at 7:17 AM Christoph Hellwig wrote: > > md_bio_alloc_sync is never called with a NULL mddev, and ->sync_set is > initialized in md_run, so it always must be initialized as well. Just > open code the remaining call to bio_alloc_bioset. > > Signed-off-by: Christoph Hellwig Acked-by: Song Liu > --- > drivers/md/md.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/md/md.c b/drivers/md/md.c > index 6a27f52007c871..399c81bddc1ae1 100644 > --- a/drivers/md/md.c > +++ b/drivers/md/md.c > @@ -340,14 +340,6 @@ static int start_readonly; > */ > static bool create_on_open = true; > > -static struct bio *md_bio_alloc_sync(struct mddev *mddev) > -{ > - if (!mddev || !bioset_initialized(&mddev->sync_set)) > - return bio_alloc(GFP_NOIO, 1); > - > - return bio_alloc_bioset(GFP_NOIO, 1, &mddev->sync_set); > -} > - > /* > * We have a system wide 'event count' that is incremented > * on any 'interesting' event, and readers of /proc/mdstat > @@ -989,7 +981,7 @@ void md_super_write(struct mddev *mddev, struct md_rdev *rdev, > if (test_bit(Faulty, &rdev->flags)) > return; > > - bio = md_bio_alloc_sync(mddev); > + bio = bio_alloc_bioset(GFP_NOIO, 1, &mddev->sync_set); > > atomic_inc(&rdev->nr_pending); > > -- > 2.29.2 >