Linux-Raid Archives on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/1] md/raid10: Change the return type of raid10_handle_discard to int
@ 2020-09-22  5:58 Xiao Ni
  2020-09-24  3:26 ` Song Liu
  0 siblings, 1 reply; 2+ messages in thread
From: Xiao Ni @ 2020-09-22  5:58 UTC (permalink / raw)
  To: linux-raid, songliubraving; +Cc: lkp, ncroxon

Now the return type of raid10_handle_discard is bool. This is wrong.
Change the return type to int.

Reported-by: kernel test robot <lkp@intel.com>
fixes: 8f694215ae4c (md/raid10: improve raid10 discard request)
Signed-off-by: Xiao Ni <xni@redhat.com>
---
 drivers/md/raid10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 524344c..6401e6a 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -1591,7 +1591,7 @@ static void raid10_end_discard_request(struct bio *bio)
  * 2st, if the discard bio spans reshape progress, we use the old way to
  * handle discard bio
  */
-static bool raid10_handle_discard(struct mddev *mddev, struct bio *bio)
+static int raid10_handle_discard(struct mddev *mddev, struct bio *bio)
 {
 	struct r10conf *conf = mddev->private;
 	struct geom *geo = &conf->geo;
-- 
2.7.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] md/raid10: Change the return type of raid10_handle_discard to int
  2020-09-22  5:58 [PATCH 1/1] md/raid10: Change the return type of raid10_handle_discard to int Xiao Ni
@ 2020-09-24  3:26 ` Song Liu
  0 siblings, 0 replies; 2+ messages in thread
From: Song Liu @ 2020-09-24  3:26 UTC (permalink / raw)
  To: Xiao Ni; +Cc: linux-raid, Song Liu, kbuild test robot, Nigel Croxon

On Mon, Sep 21, 2020 at 10:58 PM Xiao Ni <xni@redhat.com> wrote:
>
> Now the return type of raid10_handle_discard is bool. This is wrong.
> Change the return type to int.
>
> Reported-by: kernel test robot <lkp@intel.com>
> fixes: 8f694215ae4c (md/raid10: improve raid10 discard request)
> Signed-off-by: Xiao Ni <xni@redhat.com>

Applied to md-next. Thanks for the fix!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22  5:58 [PATCH 1/1] md/raid10: Change the return type of raid10_handle_discard to int Xiao Ni
2020-09-24  3:26 ` Song Liu

Linux-Raid Archives on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-raid/0 linux-raid/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-raid linux-raid/ https://lore.kernel.org/linux-raid \
		linux-raid@vger.kernel.org
	public-inbox-index linux-raid

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-raid


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git