linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@trained-monkey.org>
To: Mariusz Tkaczyk <mariusz.tkaczyk@intel.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/4] Monitor: refresh mdstat fd after select
Date: Wed, 14 Oct 2020 11:34:03 -0400	[thread overview]
Message-ID: <b9cef77d-7069-89b5-225a-d1f8b5a91a3b@trained-monkey.org> (raw)
In-Reply-To: <20200909083120.10396-2-mariusz.tkaczyk@intel.com>

On 9/9/20 4:31 AM, Mariusz Tkaczyk wrote:
> After 52209d6ee118 ("Monitor: release /proc/mdstat fd when no arrays
> present") mdstat fd is closed if mdstat is empty or cannot be opened.
> It causes that monitor is not able to select on mdstat. Select
> doesn't fail because it gets valid descriptor to a different resource.
> As a result any new event will be unnoticed until timeout (delay).
> 
> Refresh mdstat after wake up, don't poll on wrong resource.
> 
> Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@intel.com>
> ---
>  Monitor.c | 6 +++---
>  mdstat.c  | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)

Applied!

Thanks,
Jes


  parent reply	other threads:[~2020-10-14 15:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09  8:31 [PATCH 0/4] mdmonitor improvements Mariusz Tkaczyk
2020-09-09  8:31 ` [PATCH 3/4] mdmonitor: set small delay once Mariusz Tkaczyk
2020-09-15 11:33   ` Nix
2020-10-14 15:35     ` Jes Sorensen
2020-09-09  8:31 ` [PATCH 4/4] Check if other Monitor instance running before fork Mariusz Tkaczyk
2020-10-14 15:38   ` Jes Sorensen
2020-09-29 14:34 ` [PATCH 0/4] mdmonitor improvements Tkaczyk, Mariusz
2020-10-14 15:30   ` Jes Sorensen
     [not found] ` <20200909083120.10396-2-mariusz.tkaczyk@intel.com>
2020-10-14 15:34   ` Jes Sorensen [this message]
     [not found] ` <20200909083120.10396-3-mariusz.tkaczyk@intel.com>
2020-10-14 15:34   ` [PATCH 2/4] Monitor: stop notifing about containers Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9cef77d-7069-89b5-225a-d1f8b5a91a3b@trained-monkey.org \
    --to=jes@trained-monkey.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mariusz.tkaczyk@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).