linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "heming.zhao@suse.com" <heming.zhao@suse.com>
To: linux-raid@vger.kernel.org, jes@trained-monkey.org
Cc: xni@redhat.com, lidong.zhong@suse.com
Subject: Re: resend: [PATCH v2 mdadm] super1.c: avoid useless sync when bitmap switches from clustered to none
Date: Tue, 2 Mar 2021 16:39:23 +0800	[thread overview]
Message-ID: <ba1f98c0-e332-173b-1aab-afdbbea1e604@suse.com> (raw)
In-Reply-To: <1304a391-532e-0c93-b3c1-58441e3c8200@suse.com>

On 3/2/21 4:35 PM, heming.zhao@suse.com wrote:
> With kernel commit 480523feae58 ("md: only call set_in_sync() when it
> is expected to succeed."), mddev->in_sync in clustered array is always
> zero. It makes metadata resync_offset to always zero.
> When assembling a clusterd array with "-U no-bitmap" option, kernel
> md layer "mddev->resync_offset == 0" and "mddev->bitmap == NULL" will
> trigger raid1 do sync on every bitmap chunk. the sync action is useless,
> ... ...
> ---
> v2: only set MaxSector on bitmap clean device
> 
> ---
>   super1.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/super1.c b/super1.c


Hello all,

more info:
This patch had been verified & run in SUSE customer env for some time.

Thanks,
Heming


  reply	other threads:[~2021-03-03  1:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03  0:22 [PATCH v2] super1.c: avoid useless sync when bitmap switches from clustered to none Zhao Heming
2021-03-02  8:35 ` resend: [PATCH v2 mdadm] " heming.zhao
2021-03-02  8:39   ` heming.zhao [this message]
2021-03-03 14:30 ` [PATCH v2] " Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba1f98c0-e332-173b-1aab-afdbbea1e604@suse.com \
    --to=heming.zhao@suse.com \
    --cc=jes@trained-monkey.org \
    --cc=lidong.zhong@suse.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=xni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).