From: Jes Sorensen <jes@trained-monkey.org>
To: Hannes Reinecke <hare@suse.de>, Xiao Ni <xni@redhat.com>
Cc: Coly Li <colyli@suse.de>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] mdadm: split off shared library
Date: Wed, 6 Oct 2021 06:58:03 -0400 [thread overview]
Message-ID: <c79d649d-a237-8d24-f05f-aa843831c9b7@trained-monkey.org> (raw)
In-Reply-To: <75fdd0fe-154b-f8eb-9ac3-bb948b432e39@suse.de>
On 9/14/21 3:26 AM, Hannes Reinecke wrote:
> On 9/14/21 9:08 AM, Xiao Ni wrote:
>> Hi Hannes
>>
>> Thanks for these patches. It's a good idea to make codes more clearly
>> that which codes belong to which file.
>> There are many efforts that move codes from mdadm.c and mdadm.h to
>> specific files. Is it better to put these
>> patches together? For example, the patches(6, 11, 12, 16, 19, 20, 27,
>> 28) try to clean mdadm.c. Could you put
>> similar patches together? And there are some rename patches too, they
>> are sporadic.
>>
> Sure. Wasn't sure how you'd like to handle it; some prefer smaller
> patches, some prefer less patches overall ...
Sorry I missed this mainly because it had PATCH in the title and I
didn't feel the shared library subject was an urgent issue. I am not
opposed to splitting things into a shared library, in fact I believe I
suggested this to Neil many years ago. I don't remember why it didn't
happen at the time.
That said, I don't think it's something that is appropriate for 4.2, but
rather something to target for 5.0.
For something like this I would prefer smaller patches so it's possible
to bisect our way back if something broke in the process. Jumbo patches
are always wrong.
Cheers,
Jes
prev parent reply other threads:[~2021-10-06 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 14:35 [PATCH] mdadm: split off shared library Hannes Reinecke
2021-08-26 16:28 ` Coly Li
2021-10-01 10:44 ` Tkaczyk, Mariusz
2021-10-05 9:24 ` Paul Menzel
2021-09-14 7:08 ` Xiao Ni
2021-09-14 7:26 ` Hannes Reinecke
2021-09-14 7:56 ` Xiao Ni
2021-10-06 10:58 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c79d649d-a237-8d24-f05f-aa843831c9b7@trained-monkey.org \
--to=jes@trained-monkey.org \
--cc=colyli@suse.de \
--cc=hare@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).