From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F59CC6379F for ; Fri, 20 Nov 2020 07:58:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1358A22404 for ; Fri, 20 Nov 2020 07:58:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726391AbgKTH6T (ORCPT ); Fri, 20 Nov 2020 02:58:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:46460 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725766AbgKTH6T (ORCPT ); Fri, 20 Nov 2020 02:58:19 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 75B07AC0C; Fri, 20 Nov 2020 07:58:17 +0000 (UTC) Subject: Re: [PATCH 70/78] block: replace bd_mutex with a per-gendisk mutex To: Christoph Hellwig , Jens Axboe Cc: Justin Sanders , Josef Bacik , Ilya Dryomov , Jack Wang , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Minchan Kim , Mike Snitzer , Song Liu , "Martin K. Petersen" , dm-devel@redhat.com, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20201116145809.410558-1-hch@lst.de> <20201116145809.410558-71-hch@lst.de> From: Hannes Reinecke Message-ID: Date: Fri, 20 Nov 2020 08:58:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201116145809.410558-71-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On 11/16/20 3:58 PM, Christoph Hellwig wrote: > bd_mutex is primarily used for synchronizing the block device open and > release path, which recurses from partitions to the whole disk device. > The fact that we have two locks makes life unnecessarily complex due > to lock order constrains. Replace the two levels of locking with a > single mutex in the gendisk structure. > > Signed-off-by: Christoph Hellwig > --- > block/genhd.c | 7 ++-- > block/ioctl.c | 4 +- > block/partitions/core.c | 22 +++++----- > drivers/block/loop.c | 14 +++---- > drivers/block/xen-blkfront.c | 8 ++-- > drivers/block/zram/zram_drv.c | 4 +- > drivers/block/zram/zram_drv.h | 2 +- > drivers/md/md.h | 7 +--- > drivers/s390/block/dasd_genhd.c | 8 ++-- > drivers/scsi/sd.c | 4 +- > fs/block_dev.c | 71 +++++++++++++++++---------------- > fs/btrfs/volumes.c | 2 +- > fs/super.c | 8 ++-- > include/linux/blk_types.h | 1 - > include/linux/genhd.h | 1 + > 15 files changed, 80 insertions(+), 83 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer