From: Gal Pressman <galpress@amazon.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Doug Ledford <dledford@redhat.com>,
Yossi Leybovich <sleybo@amazon.com>, <linux-rdma@vger.kernel.org>,
Alexander Matushevsky <matua@amazon.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Peter Xu <peterx@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH for-next v2] RDMA/nldev: Add copy-on-fork attribute to get sys command
Date: Wed, 7 Apr 2021 16:30:50 +0300 [thread overview]
Message-ID: <010c6b45-a9b0-67c7-82e3-78533a532225@amazon.com> (raw)
In-Reply-To: <YG2yY2PW2AJgA02J@unreal>
On 07/04/2021 16:23, Leon Romanovsky wrote:
> On Wed, Apr 07, 2021 at 04:14:46PM +0300, Gal Pressman wrote:
>> On 07/04/2021 15:39, Leon Romanovsky wrote:
>>>> @@ -1710,7 +1721,8 @@ static int nldev_set_sys_set_doit(struct sk_buff *skb, struct nlmsghdr *nlh,
>>>>
>>>> err = nlmsg_parse(nlh, 0, tb, RDMA_NLDEV_ATTR_MAX - 1,
>>>> nldev_policy, extack);
>>>> - if (err || !tb[RDMA_NLDEV_SYS_ATTR_NETNS_MODE])
>>>> + if (err || !tb[RDMA_NLDEV_SYS_ATTR_NETNS_MODE] ||
>>>> + tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK])
>>>
>>> Why do we fail if user supplies RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK?
>>
>> It's a read-only attribute, if someone tries to set its value I assume it's best
>> to return an error.
>
> Not in netlink world, you need to ignore the parameters that
> you don't "know how to handle" and check for must-to-be input only.
Not sure I understand.
So you expect the set function to remain unchanged in this patch? Isn't it bad
that a user can request to change the copy on fork value and get a success
return value although nothing happened?
next prev parent reply other threads:[~2021-04-07 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 10:16 [PATCH for-next v2] RDMA/nldev: Add copy-on-fork attribute to get sys command Gal Pressman
2021-04-07 12:39 ` Leon Romanovsky
2021-04-07 13:14 ` Gal Pressman
2021-04-07 13:23 ` Leon Romanovsky
2021-04-07 13:30 ` Gal Pressman [this message]
2021-04-07 13:40 ` Leon Romanovsky
2021-04-08 6:30 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010c6b45-a9b0-67c7-82e3-78533a532225@amazon.com \
--to=galpress@amazon.com \
--cc=akpm@linux-foundation.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).