From: Maor Gottlieb <maorg@mellanox.com>
To: Gal Pressman <galpress@amazon.com>
Cc: "j.vosburgh@gmail.com" <j.vosburgh@gmail.com>,
"vfalico@gmail.com" <vfalico@gmail.com>,
"andy@greyhouse.net" <andy@greyhouse.net>,
Jiri Pirko <jiri@mellanox.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@mellanox.com>,
Jason Gunthorpe <jgg@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>,
Alex Rosenbaum <alexr@mellanox.com>,
Mark Zhang <markz@mellanox.com>,
Parav Pandit <parav@mellanox.com>,
Eran Ben Elisha <eranbe@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [RFC PATCH 1/4] net/core: Introduce master_xmit_slave_get
Date: Thu, 30 Jan 2020 15:40:18 +0000 [thread overview]
Message-ID: <0c72c634-14ef-3e24-6f83-6a1783170b83@mellanox.com> (raw)
In-Reply-To: <f27d00e8-e6b5-51a2-fd70-5ed3e5f97610@amazon.com>
On 1/29/2020 11:57 AM, Gal Pressman wrote:
> On 26/01/2020 15:21, Maor Gottlieb wrote:
>> Add new ndo to get the xmit slave of master device.
>> When slave selection method is based on hash, then the user can ask to
>> get the xmit slave assume all the slaves can transmit by setting the
>> LAG_FLAGS_HASH_ALL_SLAVES bit in the flags argument.
>>
>> Signed-off-by: Maor Gottlieb <maorg@mellanox.com>
>> ---
>> include/linux/netdevice.h | 3 +++
>> include/net/lag.h | 19 +++++++++++++++++++
>> 2 files changed, 22 insertions(+)
>>
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index 11bdf6cb30bd..faba4aa094e5 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -1379,6 +1379,9 @@ struct net_device_ops {
>> struct netlink_ext_ack *extack);
>> int (*ndo_del_slave)(struct net_device *dev,
>> struct net_device *slave_dev);
>> + struct net_device* (*ndo_xmit_slave_get)(struct net_device *master_dev,
>> + struct sk_buff *skb,
>> + int lag);
> Hey Maor,
> Should lag be named flags?
> Also, better to use unsigned type for it.
Yeah, will change it.
next prev parent reply other threads:[~2020-01-30 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 13:21 [RFC PATCH 0/4] Introduce master_xmit_slave_get Maor Gottlieb
2020-01-26 13:21 ` [RFC PATCH 1/4] net/core: " Maor Gottlieb
2020-01-29 9:57 ` Gal Pressman
2020-01-30 15:40 ` Maor Gottlieb [this message]
2020-02-12 20:33 ` Saeed Mahameed
2020-01-26 13:21 ` [RFC PATCH 2/4] bonding: Rename slave_arr to active_slaves Maor Gottlieb
2020-01-26 13:21 ` [RFC PATCH 3/4] bonding: Add helpers to get xmit slave Maor Gottlieb
2020-01-26 13:21 ` [RFC PATCH 4/4] bonding: Implement ndo_xmit_slave_get Maor Gottlieb
2020-01-29 2:08 ` Jay Vosburgh
2020-01-30 15:44 ` Maor Gottlieb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c72c634-14ef-3e24-6f83-6a1783170b83@mellanox.com \
--to=maorg@mellanox.com \
--cc=alexr@mellanox.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=galpress@amazon.com \
--cc=j.vosburgh@gmail.com \
--cc=jgg@mellanox.com \
--cc=jiri@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=markz@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).