On Tue, 2019-12-03 at 08:25 -0800, Bart Van Assche wrote:
> On 12/2/19 6:03 PM, Steve Wise wrote:
> > If RoCE PDUs being sent or received contain pad bytes, then the iCRC
> > is miscalculated resulting PDUs being emitted by RXE with an
> > incorrect
> > iCRC, as well as ingress PDUs being dropped due to erroneously
> > detecting
> > a bad iCRC in the PDU.  The fix is to include the pad bytes, if any,
> > in iCRC computations.
> 
> Should this description mention that this patch breaks compatibility 
> with SoftRoCE drivers that do not include this fix? Do we need a
> kernel 
> module parameter that allows to select either the old or the new
> behavior?

No.  The original soft-RoCE driver was supposed to be compatible with
hardware devices.  Because of this bug, it obviously wasn't.  This is a
bug fix, and we do not need to do anything to be compatible with the
broken behavior.  Instead, it just needs noting that the soft-RoCE
implementation in prior kernels has a known wire format bug that impacts
communications with both fixed versions of the driver and real hardware
devices.

> > CC: bvanassche@acm.org,3100102071@zju.edu.cn,leon@kernel.org
> 
> Should this Cc-line perhaps be converted into three Cc-lines?
> 
> Otherwise this patch looks fine to me.
> 
> Thanks,
> 
> Bart.
> 

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD