linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Michal Kalderon
	<Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
	leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization
Date: Fri, 29 Sep 2017 11:22:39 -0400	[thread overview]
Message-ID: <1506698559.2919.16.camel@redhat.com> (raw)
In-Reply-To: <1506518845.82712.15.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Wed, 2017-09-27 at 09:27 -0400, Doug Ledford wrote:
> On Wed, 2017-09-20 at 08:39 +0300, Michal Kalderon wrote:
> > Initialize the rdma_type (iWARP or RoCE) which is set according to
> > device configuration in qed.
> > 
> > Fixes: e6a38c54faf ("RDMA/qedr: Add support for registering an
> > iWARP
> > device")
> > 
> > Signed-off-by: Michal Kalderon <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> > Signed-off-by: Ariel Elior <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> > 
> > ---
> > This patch applies cleanly on k.o/for-next-merged
> > 
> > Changes from V0:
> > - Added Fixes in commit comment.
> 
> Sorry, I was wrong in my email to the previous posting of this
> patch. 
> I had pulled this v1 patch from patchworks, not the original patch,
> and
> so the Fixes: line was yours.  Patchworks did not add the Fixes: line
> to the v0 patch when I downloaded it just now.
> 
> That being said, I still can't build with this patch ;-)

OK, the build failure was my fault.  As this was a minor patch, I had
lumped it into a bundle I labeled as "misc".  That by itself is fine,
but I then applied that to a clean for-next head of v4.14-rc2, without
the merge of the qedr branch, and so the build failed.  Putting this
into a branch with the qedr patches already merged resolves the issue. 
So, thanks, applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-09-29 15:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20  5:39 [PATCH v1 rdma-next] RDMA/qedr: Fix rdma_type initialization Michal Kalderon
     [not found] ` <1505885986-5873-1-git-send-email-Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-09-27 13:27   ` Doug Ledford
     [not found]     ` <1506518845.82712.15.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-09-27 16:18       ` Kalderon, Michal
     [not found]         ` <CY1PR0701MB20126E3E86A45619079DFCAC88780-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-09-27 16:53           ` Leon Romanovsky
     [not found]             ` <20170927165339.GI2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-27 16:56               ` Leon Romanovsky
     [not found]                 ` <20170927165610.GJ2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-27 20:33                   ` Kalderon, Michal
     [not found]                     ` <CY1PR0701MB2012A41A0744D17AD3CD10DB88780-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-09-28  3:27                       ` Leon Romanovsky
     [not found]                         ` <20170928032725.GO2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-28  6:22                           ` Kalderon, Michal
     [not found]                             ` <CY1PR0701MB20122CDD0A73BB963A43755288790-UpKza+2NMNLHMJvQ0dyT705OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-09-28  6:49                               ` Leon Romanovsky
     [not found]                                 ` <20170928064955.GP2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-28  6:51                                   ` Kalderon, Michal
2017-09-28 14:05                               ` Doug Ledford
2017-09-29 15:22       ` Doug Ledford [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506698559.2919.16.camel@redhat.com \
    --to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
    --cc=Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).