From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, sulrich@codeaurora.org, timur@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sinan Kaya <okaya@codeaurora.org>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
"open list:HFI1 DRIVER" <linux-rdma@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset
Date: Thu, 19 Apr 2018 15:56:23 -0400 [thread overview]
Message-ID: <1524167784-5911-1-git-send-email-okaya@codeaurora.org> (raw)
The infiniband adapter might be connected to a PCI hotplug slot. Performing
secondary bus reset on a hotplug slot causes PCI link up/down interrupts.
Hotplug driver removes the device from system when a link down interrupt
is observed and performs re-enumeration when link up interrupt is observed.
This conflicts with what this code is trying to do. Try secondary bus reset
only if pci_reset_slot() fails/unsupported.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/infiniband/hw/hfi1/pcie.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c
index 83d66e8..75f49e3 100644
--- a/drivers/infiniband/hw/hfi1/pcie.c
+++ b/drivers/infiniband/hw/hfi1/pcie.c
@@ -908,7 +908,8 @@ static int trigger_sbr(struct hfi1_devdata *dd)
* delay after a reset is required. Per spec requirements,
* the link is either working or not after that point.
*/
- pci_reset_bridge_secondary_bus(dev->bus->self);
+ if (pci_reset_slot(dev->slot))
+ pci_reset_bridge_secondary_bus(dev->bus->self);
return 0;
}
--
2.7.4
next reply other threads:[~2018-04-19 19:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 19:56 Sinan Kaya [this message]
2018-04-19 20:26 ` [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset Jason Gunthorpe
2018-04-19 20:35 ` Sinan Kaya
2018-04-19 21:47 ` Bjorn Helgaas
2018-04-19 22:11 ` Deucher, Alexander
2018-04-20 14:12 ` Dennis Dalessandro
2018-04-20 14:55 ` Jason Gunthorpe
2018-04-19 22:19 ` Sinan Kaya
2018-04-20 14:00 ` Bjorn Helgaas
2018-04-20 14:23 ` Sinan Kaya
2018-04-20 15:04 ` Alex Williamson
2018-04-23 17:28 ` Sinan Kaya
2018-04-23 19:10 ` Alex Williamson
2018-04-23 20:17 ` Sinan Kaya
2018-04-23 20:23 ` Bjorn Helgaas
2018-04-23 20:41 ` Alex Williamson
2018-04-25 14:13 ` Sinan Kaya
2018-04-20 14:54 ` Jason Gunthorpe
2018-06-19 21:43 ` Bjorn Helgaas
2018-06-19 22:21 ` Sinan Kaya
2018-06-22 14:01 ` Bjorn Helgaas
2018-06-22 16:04 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524167784-5911-1-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=sulrich@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).