From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F81ECA9EA0 for ; Mon, 4 Nov 2019 12:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC718222C5 for ; Mon, 4 Nov 2019 12:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728639AbfKDMZx (ORCPT ); Mon, 4 Nov 2019 07:25:53 -0500 Received: from stargate.chelsio.com ([12.32.117.8]:65110 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728562AbfKDMZx (ORCPT ); Mon, 4 Nov 2019 07:25:53 -0500 Received: from localhost (mehrangarh.blr.asicdesigners.com [10.193.185.169]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id xA4CPn4Q032285; Mon, 4 Nov 2019 04:25:50 -0800 From: Potnuri Bharat Teja To: jgg@ziepe.ca, dledford@redhat.com Cc: linux-rdma@vger.kernel.org, bharat@chelsio.com, nirranjan@chelsio.com Subject: [PATCH v2 rdma-core] cxgb4: free appropriate pointer in error case Date: Mon, 4 Nov 2019 17:55:45 +0530 Message-Id: <1572870345-8629-1-git-send-email-bharat@chelsio.com> X-Mailer: git-send-email 2.3.9 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org error unmap case wrongly frees only the cqid2ptr for qp/mmid2ptr. This patch frees the appropriate pointer. Fixes: 9b2d3af5735e ("Query device to get the max supported stags, qps, and cqs") Signed-off-by: Potnuri Bharat Teja --- v0 -> v1: - add missing description --- providers/cxgb4/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/providers/cxgb4/dev.c b/providers/cxgb4/dev.c index 7f5955449ca1..4d02c7a91892 100644 --- a/providers/cxgb4/dev.c +++ b/providers/cxgb4/dev.c @@ -203,9 +203,9 @@ err_free: if (rhp->cqid2ptr) free(rhp->cqid2ptr); if (rhp->qpid2ptr) - free(rhp->cqid2ptr); + free(rhp->qpid2ptr); if (rhp->mmid2ptr) - free(rhp->cqid2ptr); + free(rhp->mmid2ptr); verbs_uninit_context(&context->ibv_ctx); free(context); return NULL; -- 2.3.9