From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E0A4C5DF62 for ; Wed, 6 Nov 2019 06:39:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A96E9217D7 for ; Wed, 6 Nov 2019 06:39:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="faHvyNdh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729549AbfKFGjk (ORCPT ); Wed, 6 Nov 2019 01:39:40 -0500 Received: from mail-m973.mail.163.com ([123.126.97.3]:41070 "EHLO mail-m973.mail.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729470AbfKFGjk (ORCPT ); Wed, 6 Nov 2019 01:39:40 -0500 X-Greylist: delayed 907 seconds by postgrey-1.27 at vger.kernel.org; Wed, 06 Nov 2019 01:39:39 EST DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=ZW7ADXOpY7jtfDW7OG JksEYT6Hht/9ZWqeFWJehNnHY=; b=faHvyNdhd7HbjtZqDveFTPKZ6/7nMDwot0 h+rK3VdRd0Nctm7wLwWcCulsbK3FOo/YRIMw2+0E+r1ZfhS63ps9uC3HZHchprB3 792N0sCnIwhccWH0zZ1o6PZa7ivrhAFpYb0SoMrxUEOhBuc9erjxA4iyuAADB0cZ hZ5f9TeCw= Received: from localhost.localdomain (unknown [202.112.113.212]) by smtp3 (Coremail) with SMTP id G9xpCgAXbAsCZ8JdsYANHw--.188S3; Wed, 06 Nov 2019 14:24:24 +0800 (CST) From: Pan Bian To: Michal Kalderon , Ariel Elior , Doug Ledford , Jason Gunthorpe Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH] RDMA/qedr: fix potential use after free Date: Wed, 6 Nov 2019 14:23:54 +0800 Message-Id: <1573021434-18768-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: G9xpCgAXbAsCZ8JdsYANHw--.188S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrZFyfJrW5ur1ktw1rAw13urg_yoW3Gwb_Ca yq9w1xXw1UCF1Fk34UWr13ZFWIqayq9wn5Xwnxt3W3CryYyF9xJ3s5Zrn5u397J34kGFZx Jr4UK3s7Ar4rGjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU14xRPUUUUU== X-Originating-IP: [202.112.113.212] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/1tbiQBhlclSIdH7ERgAAsb Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Move the release operation after error log to avoid possible use after free. Signed-off-by: Pan Bian --- drivers/infiniband/hw/qedr/qedr_iw_cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qedr/qedr_iw_cm.c b/drivers/infiniband/hw/qedr/qedr_iw_cm.c index 22881d4442b9..eedc32b72ff2 100644 --- a/drivers/infiniband/hw/qedr/qedr_iw_cm.c +++ b/drivers/infiniband/hw/qedr/qedr_iw_cm.c @@ -451,10 +451,10 @@ qedr_addr6_resolve(struct qedr_dev *dev, if ((!dst) || dst->error) { if (dst) { - dst_release(dst); DP_ERR(dev, "ip6_route_output returned dst->error = %d\n", dst->error); + dst_release(dst); } return -EINVAL; } -- 2.7.4