From: Weihang Li <liweihang@hisilicon.com>
To: <jgg@ziepe.ca>, <leon@kernel.org>
Cc: <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
<linuxarm@huawei.com>
Subject: [PATCH rdma-core 3/7] libhns: Bugfix for assigning sl
Date: Thu, 21 Nov 2019 09:19:25 +0800 [thread overview]
Message-ID: <1574299169-31457-4-git-send-email-liweihang@hisilicon.com> (raw)
In-Reply-To: <1574299169-31457-1-git-send-email-liweihang@hisilicon.com>
From: Lijun Ou <oulijun@huawei.com>
Only the field that corresponding mask is set can be modified, or its
original value may be covered.
Fixes: c24583975044 ("libhns: Add verbs of qp support")
Signed-off-by: Lijun Ou <oulijun@huawei.com>
Signed-off-by: Weihang Li <liweihang@hisilicon.com>
---
providers/hns/hns_roce_u_hw_v2.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/providers/hns/hns_roce_u_hw_v2.c b/providers/hns/hns_roce_u_hw_v2.c
index 931f59d..b473f07 100644
--- a/providers/hns/hns_roce_u_hw_v2.c
+++ b/providers/hns/hns_roce_u_hw_v2.c
@@ -1103,8 +1103,10 @@ static int hns_roce_u_v2_modify_qp(struct ibv_qp *qp, struct ibv_qp_attr *attr,
pthread_spin_unlock(&hr_qp->sq.lock);
}
- if (!ret && (attr_mask & IBV_QP_STATE) &&
- attr->qp_state == IBV_QPS_RESET) {
+ if (ret)
+ return ret;
+
+ if ((attr_mask & IBV_QP_STATE) && attr->qp_state == IBV_QPS_RESET) {
hns_roce_v2_cq_clean(to_hr_cq(qp->recv_cq), qp->qp_num,
qp->srq ? to_hr_srq(qp->srq) : NULL);
if (qp->send_cq != qp->recv_cq)
@@ -1114,10 +1116,11 @@ static int hns_roce_u_v2_modify_qp(struct ibv_qp *qp, struct ibv_qp_attr *attr,
hns_roce_init_qp_indices(to_hr_qp(qp));
}
- if (!ret && (attr_mask & IBV_QP_PORT))
+ if (attr_mask & IBV_QP_PORT)
hr_qp->port_num = attr->port_num;
- hr_qp->sl = attr->ah_attr.sl;
+ if (attr_mask & IBV_QP_AV)
+ hr_qp->sl = attr->ah_attr.sl;
return ret;
}
--
2.8.1
next prev parent reply other threads:[~2019-11-21 1:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 1:19 [PATCH rdma-core 0/7] libhns: Bugfix for hip08 Weihang Li
2019-11-21 1:19 ` [PATCH rdma-core 1/7] libhns: Fix calculation errors with ilog32() Weihang Li
2019-11-22 2:58 ` Zengtao (B)
2019-11-22 6:16 ` Weihang Li
2019-11-22 18:09 ` Jason Gunthorpe
2019-11-23 2:43 ` Weihang Li
2019-11-21 1:19 ` [PATCH rdma-core 2/7] libhns: Optimize bind_mw for fixing null pointer access Weihang Li
2019-11-22 3:02 ` Zengtao (B)
2019-11-22 6:40 ` Weihang Li
2019-11-21 1:19 ` Weihang Li [this message]
2019-11-21 1:19 ` [PATCH rdma-core 4/7] libhns: Bugfix for cleaning cq Weihang Li
2019-11-21 1:19 ` [PATCH rdma-core 5/7] libhns: Bugfix for updating qp params Weihang Li
2019-11-21 1:19 ` [PATCH rdma-core 6/7] libhns: Avoid null pointer operation Weihang Li
2019-11-21 1:19 ` [PATCH rdma-core 7/7] libhns: Return correct value of cqe num when flushing cqe failed Weihang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574299169-31457-4-git-send-email-liweihang@hisilicon.com \
--to=liweihang@hisilicon.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).