From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 637FFC33CB3 for ; Thu, 16 Jan 2020 13:23:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39FD82081E for ; Thu, 16 Jan 2020 13:23:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VT6w9ZzP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727002AbgAPNWV (ORCPT ); Thu, 16 Jan 2020 08:22:21 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:34794 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726983AbgAPNWU (ORCPT ); Thu, 16 Jan 2020 08:22:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579180939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oVICxkwYE819T09jumS9b6kqZZVW9alGabNhw2Byv4c=; b=VT6w9ZzPdsyWIYjDinxoIw1lpo6pHnP9T4HVqfKC9kxy6rMCp0ekExAPnyEq70JjFJtyRz /4Bx2urewdYCxM2j50p6eeRdKDKXu9cxVUQ+XHUD8ENeQdHw/VkX6ceeydL5/CQTWqnbY2 LO7Q+2RGjnWR2KuWxfGapo162QJH+NI= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-110-XEZ_K_z_Orq4s2tDBp6E4w-1; Thu, 16 Jan 2020 08:22:15 -0500 X-MC-Unique: XEZ_K_z_Orq4s2tDBp6E4w-1 Received: by mail-lj1-f198.google.com with SMTP id j23so5149156lji.23 for ; Thu, 16 Jan 2020 05:22:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=oVICxkwYE819T09jumS9b6kqZZVW9alGabNhw2Byv4c=; b=ckkE7t26IlmfN/hC79q2NwA2EWr5EbuNCfDfhNQOhOtNhlRtFtxcWzqiLorYlxuJtf 3/+VhVyRLacBZkfdMSVkTBW1NXsafgSRIvfVM4f5YbRxY32SBPYVh8V/AJhHeeN7Lz8r GD9N/2PdzTpbt25Dsk4H97vZy+dfDE71fOWCIj6yHX2Ymv1PW3AVAvxHvwU0QE4tDvt7 76oCmhqFqkHIbbrCLvH3DVs9YT/DOf7ePVMTO1ElCeJ/eLAUH3KAEaQqt5EB5fNzdHeA QdsmW4YDAoIILcT2Jk+CNRnKyMhbhfHb1jMjQlChpRbCsDACFg55uXhR3xGPo5zofa2A Rg3w== X-Gm-Message-State: APjAAAW7fShlZ1b2K3jeIDTcEkQHcybFCWqIxvnQ/dP0UQHbzSHab4Ys +oK+QmDf1gyCvthdI9Fq4N3Ur4QoWPmixMj1qaQkP1UxiLoJIIVcfSn8nWt4b71VTuOYibIv8V2 CsP3HujqPmHi2jF4l2P2iKg== X-Received: by 2002:a2e:b007:: with SMTP id y7mr2286059ljk.215.1579180934267; Thu, 16 Jan 2020 05:22:14 -0800 (PST) X-Google-Smtp-Source: APXvYqwQWrcaU+nW1F4XoH997rZHaa169MNBHkP1drBFjaeoj4ZaAxptcEhRwkbakFT89vmLfrEkOg== X-Received: by 2002:a2e:b007:: with SMTP id y7mr2286032ljk.215.1579180934124; Thu, 16 Jan 2020 05:22:14 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id f16sm10703433ljn.17.2020.01.16.05.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 05:22:13 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id D9E2F1804D7; Thu, 16 Jan 2020 14:22:12 +0100 (CET) Subject: [PATCH bpf-next v3 01/11] samples/bpf: Don't try to remove user's homedir on clean From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Alexei Starovoitov Cc: Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Doug Ledford , Jason Gunthorpe , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Shuah Khan , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kselftest@vger.kernel.org, clang-built-linux@googlegroups.com Date: Thu, 16 Jan 2020 14:22:12 +0100 Message-ID: <157918093278.1357254.3453847369567754938.stgit@toke.dk> In-Reply-To: <157918093154.1357254.7616059374996162336.stgit@toke.dk> References: <157918093154.1357254.7616059374996162336.stgit@toke.dk> User-Agent: StGit/0.21 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Toke Høiland-Jørgensen The 'clean' rule in the samples/bpf Makefile tries to remove backup files (ending in ~). However, if no such files exist, it will instead try to remove the user's home directory. While the attempt is mostly harmless, it does lead to a somewhat scary warning like this: rm: cannot remove '~': Is a directory Fix this by using find instead of shell expansion to locate any actual backup files that need to be removed. Fixes: b62a796c109c ("samples/bpf: allow make to be run from samples/bpf/ directory") Acked-by: Jesper Dangaard Brouer Signed-off-by: Toke Høiland-Jørgensen --- samples/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile index 5b89c0370f33..f86d713a17a5 100644 --- a/samples/bpf/Makefile +++ b/samples/bpf/Makefile @@ -254,7 +254,7 @@ all: clean: $(MAKE) -C ../../ M=$(CURDIR) clean - @rm -f *~ + @find $(CURDIR) -type f -name '*~' -delete $(LIBBPF): FORCE # Fix up variables inherited from Kbuild that tools/ build system won't like