From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 792F0C352A3 for ; Mon, 10 Feb 2020 17:17:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CF3B20715 for ; Mon, 10 Feb 2020 17:17:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Eq7txFsN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728055AbgBJRR6 (ORCPT ); Mon, 10 Feb 2020 12:17:58 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:39341 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727121AbgBJRR6 (ORCPT ); Mon, 10 Feb 2020 12:17:58 -0500 Received: by mail-pj1-f68.google.com with SMTP id e9so15368pjr.4 for ; Mon, 10 Feb 2020 09:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id; bh=ivFXseolkTBsuvCab6VpkGn1cFohgqmaRLW8kIcvehQ=; b=Eq7txFsNBKU+Kf9C/eG0l3p5ibUO0jILqnWfRX68YpUaPHmjhS644pBUkMg6VrLvwW AzjHmoHxr6l0Manmcef0MY7TNDqjORykDHYM7NgJkXsnU8LG8p4B3fSyuuchZc0YshWw u6rZ9CY/7HzX2JkZ8sAxrwGIMqx0VHInSQAco= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ivFXseolkTBsuvCab6VpkGn1cFohgqmaRLW8kIcvehQ=; b=PXPN8PNthuqYQRNx3gIxjPQjfZwJFKkpwsntgCoxI823v/iZ+wR8wVcDF+BRZqXyQF 2Idz3WAMm4FEd618VuMF6n0Wk4DkG5msnsXfAnyogpD4i1zkPBxIDg9uTV6kW6oC3h5L lzON69mnkDHCstI2Ds7DKFtK3nF2lFYtvCMkTLNnzX2c1LbUnTzuOBjJFzYxHBwp/cRd p+wv7rViIXmtKEsG4G3r7g8EeskSrsV1VcGr2QijbQJSDwbCWJnKK+AYrPiivx5LaZal WlmVmZWVK/0YIURknRp6XZ6xxFJ/fIzZ98zvCsxLvh9zyW4ohwHykCHnv5DZeM1SQd3+ uJtw== X-Gm-Message-State: APjAAAW/W4Ct4z6KIXf0gVFYGXtPQrfxwthW8xkX0n4ZZu3iMRruA/q4 4XIkokejgj2mND2KNVCtpEdpmGQZoB8yYc5I7ZEEYhcZscSfY6uPHUKAuA8CUHZQPyrKn0Z/jek +Q4utuy+QiCTTHaVj8X4kOQmoldwM8By/N2+Txmtc1wZ+pljXA6KXafOC2Ln+o25Vq5PEHkBSeD igiMg= X-Google-Smtp-Source: APXvYqzJ67qNE3cke3aixOe+GGQdT0hBNWSB6LyWhi4mml84Z64N6L4NdKX0+pA04pFGjv38G6sJNA== X-Received: by 2002:a17:902:6ac2:: with SMTP id i2mr13692684plt.221.1581355076322; Mon, 10 Feb 2020 09:17:56 -0800 (PST) Received: from neo00-el73.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id k4sm996953pfg.40.2020.02.10.09.17.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Feb 2020 09:17:55 -0800 (PST) From: Devesh Sharma To: linux-rdma@vger.kernel.org Cc: jgg@mellanox.com, leon@kernel.org Subject: [PATCH v8] libibverbs: display gid type in ibv_devinfo Date: Mon, 10 Feb 2020 12:17:45 -0500 Message-Id: <1581355065-763-1-git-send-email-devesh.sharma@broadcom.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org It becomes difficult to make out from the output of ibv_devinfo if a particular gid index is RoCE v2 or not. Adding a string to the output of ibv_devinfo -v to display the gid type at the end of gid. The output would look something like below: $ ibv_devinfo -v -d bnxt_re2 hca_id: bnxt_re2 transport: InfiniBand (0) fw_ver: 216.0.220.0 node_guid: b226:28ff:fed3:b0f0 sys_image_guid: b226:28ff:fed3:b0f0 . . . . phys_state: LINK_UP (5) GID[ 0]: fe80:0000:0000:0000:b226:28ff:fed3:b0f0, RoCE v1 GID[ 1]: fe80::b226:28ff:fed3:b0f0, RoCE v2 GID[ 2]: 0000:0000:0000:0000:0000:ffff:c0aa:0165, RoCE v1 GID[ 3]: ::ffff:192.170.1.101, RoCE v2 $ $ $ Reviewed-by: Jason Gunthrope Reviewed-by: Gal Pressman Reviewed-by: Parav Pandit Signed-off-by: Devesh Sharma --- libibverbs/examples/devinfo.c | 61 ++++++++++++++++++++++++++++++++++--------- 1 file changed, 49 insertions(+), 12 deletions(-) diff --git a/libibverbs/examples/devinfo.c b/libibverbs/examples/devinfo.c index bf53eac..f10eb2d 100644 --- a/libibverbs/examples/devinfo.c +++ b/libibverbs/examples/devinfo.c @@ -40,6 +40,7 @@ #include #include #include +#include #include #include @@ -162,12 +163,50 @@ static const char *vl_str(uint8_t vl_num) } } -static int print_all_port_gids(struct ibv_context *ctx, uint8_t port_num, int tbl_len) +#define DEVINFO_INVALID_GID_TYPE 2 +static const char *gid_type_str(enum ibv_gid_type type) { + switch (type) { + case IBV_GID_TYPE_IB_ROCE_V1: return "RoCE v1"; + case IBV_GID_TYPE_ROCE_V2: return "RoCE v2"; + default: return "Invalid gid type"; + } +} + +static void print_formated_gid(union ibv_gid *gid, int i, + enum ibv_gid_type type, int ll) +{ + char gid_str[INET6_ADDRSTRLEN] = {}; + char str[20] = {}; + + if (ll == IBV_LINK_LAYER_ETHERNET) + sprintf(str, ", %s", gid_type_str(type)); + + if (type == IBV_GID_TYPE_IB_ROCE_V1) + printf("\t\t\tGID[%3d]:\t\t%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x%s\n", + i, gid->raw[0], gid->raw[1], gid->raw[2], + gid->raw[3], gid->raw[4], gid->raw[5], gid->raw[6], + gid->raw[7], gid->raw[8], gid->raw[9], gid->raw[10], + gid->raw[11], gid->raw[12], gid->raw[13], gid->raw[14], + gid->raw[15], str); + + if (type == IBV_GID_TYPE_ROCE_V2) { + inet_ntop(AF_INET6, gid->raw, gid_str, sizeof(gid_str)); + printf("\t\t\tGID[%3d]:\t\t%s%s\n", i, gid_str, str); + } +} + +static int print_all_port_gids(struct ibv_context *ctx, + struct ibv_port_attr *port_attr, + uint8_t port_num) +{ + enum ibv_gid_type type; union ibv_gid gid; + int tbl_len; int rc = 0; int i; + tbl_len = port_attr->gid_tbl_len; for (i = 0; i < tbl_len; i++) { rc = ibv_query_gid(ctx, port_num, i, &gid); if (rc) { @@ -175,17 +214,15 @@ static int print_all_port_gids(struct ibv_context *ctx, uint8_t port_num, int tb port_num, i); return rc; } + + rc = ibv_query_gid_type(ctx, port_num, i, &type); + if (rc) { + rc = 0; + type = DEVINFO_INVALID_GID_TYPE; + } if (!null_gid(&gid)) - printf("\t\t\tGID[%3d]:\t\t%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x\n", - i, - gid.raw[ 0], gid.raw[ 1], - gid.raw[ 2], gid.raw[ 3], - gid.raw[ 4], gid.raw[ 5], - gid.raw[ 6], gid.raw[ 7], - gid.raw[ 8], gid.raw[ 9], - gid.raw[10], gid.raw[11], - gid.raw[12], gid.raw[13], - gid.raw[14], gid.raw[15]); + print_formated_gid(&gid, i, type, + port_attr->link_layer); } return rc; } @@ -614,7 +651,7 @@ static int print_hca_cap(struct ibv_device *ib_dev, uint8_t ib_port) printf("\t\t\tphys_state:\t\t%s (%d)\n", port_phy_state_str(port_attr.phys_state), port_attr.phys_state); - if (print_all_port_gids(ctx, port, port_attr.gid_tbl_len)) + if (print_all_port_gids(ctx, &port_attr, port)) goto cleanup; } printf("\n"); -- 1.8.3.1