* [PATCH] IB/hfi1: make hist static
@ 2021-09-06 9:48 Jiapeng Chong
2021-09-08 11:44 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-09-06 9:48 UTC (permalink / raw)
To: mike.marciniszyn
Cc: dennis.dalessandro, dledford, jgg, linux-rdma, linux-kernel,
chongjiapeng
From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
This symbol is not used outside of trace.c, so marks it static.
Fix the following sparse warning:
drivers/infiniband/hw/hfi1/trace.c:491:23: warning: symbol 'hist' was
not declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
---
drivers/infiniband/hw/hfi1/trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hfi1/trace.c b/drivers/infiniband/hw/hfi1/trace.c
index d9b5bbb..8302469 100644
--- a/drivers/infiniband/hw/hfi1/trace.c
+++ b/drivers/infiniband/hw/hfi1/trace.c
@@ -488,7 +488,7 @@ struct hfi1_ctxt_hist {
atomic_t data[255];
};
-struct hfi1_ctxt_hist hist = {
+static struct hfi1_ctxt_hist hist = {
.count = ATOMIC_INIT(0)
};
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] IB/hfi1: make hist static
2021-09-06 9:48 [PATCH] IB/hfi1: make hist static Jiapeng Chong
@ 2021-09-08 11:44 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2021-09-08 11:44 UTC (permalink / raw)
To: Jiapeng Chong
Cc: mike.marciniszyn, dennis.dalessandro, dledford, linux-rdma, linux-kernel
On Mon, Sep 06, 2021 at 05:48:43PM +0800, Jiapeng Chong wrote:
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> This symbol is not used outside of trace.c, so marks it static.
>
> Fix the following sparse warning:
>
> drivers/infiniband/hw/hfi1/trace.c:491:23: warning: symbol 'hist' was
> not declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/infiniband/hw/hfi1/trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-08 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-06 9:48 [PATCH] IB/hfi1: make hist static Jiapeng Chong
2021-09-08 11:44 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).