From: Florian Fainelli <f.fainelli@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc: "David Miller" <davem@davemloft.net>,
"Jakub Kicinski" <jakub.kicinski@netronome.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Tal Gilboa" <talgi@mellanox.com>,
"Saeed Mahameed" <saeedm@mellanox.com>,
"Doug Ledford" <dledford@redhat.com>,
"Jason Gunthorpe" <jgg@mellanox.com>,
"Leon Romanovsky" <leonro@mellanox.com>,
"Or Gerlitz" <ogerlitz@mellanox.com>,
"Sagi Grimberg" <sagi@grimberg.me>
Subject: Re: [PATCH] net: ethernet: broadcom: have drivers select DIMLIB as needed
Date: Sun, 13 Oct 2019 12:21:23 -0700 [thread overview]
Message-ID: <198472c1-f584-8e17-6109-264af1328152@gmail.com> (raw)
In-Reply-To: <610f9277-adff-2f4b-1f44-8f41b6c3ccb5@infradead.org>
On 10/11/2019 9:03 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> NET_VENDOR_BROADCOM is intended to control a kconfig menu only.
> It should not have anything to do with code generation.
> As such, it should not select DIMLIB for all drivers under
> NET_VENDOR_BROADCOM. Instead each driver that needs DIMLIB should
> select it (being the symbols SYSTEMPORT, BNXT, and BCMGENET).
>
> Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1907021810220.13058@ramsan.of.borg/
>
> Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files")
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2019-10-13 19:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 4:03 [PATCH] net: ethernet: broadcom: have drivers select DIMLIB as needed Randy Dunlap
2019-10-13 19:21 ` Florian Fainelli [this message]
2019-10-15 7:22 ` Leon Romanovsky
2019-10-15 17:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=198472c1-f584-8e17-6109-264af1328152@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=geert@linux-m68k.org \
--cc=jakub.kicinski@netronome.com \
--cc=jgg@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=rdunlap@infradead.org \
--cc=saeedm@mellanox.com \
--cc=sagi@grimberg.me \
--cc=talgi@mellanox.com \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).