From: liweihang <liweihang@huawei.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"leon@kernel.org" <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH v2 for-next] RDMA/hns: Support owner mode doorbell
Date: Mon, 12 Oct 2020 11:56:17 +0000 [thread overview]
Message-ID: <1a828087e5ad4880941310afb6843958@huawei.com> (raw)
In-Reply-To: 20200929165356.GA757147@nvidia.com
On 2020/9/30 0:54, Jason Gunthorpe wrote:
> On Sun, Sep 27, 2020 at 05:45:01PM +0800, Weihang Li wrote:
>> @@ -517,7 +514,18 @@ static inline int set_ud_wqe(struct hns_roce_qp *qp,
>>
>> set_extend_sge(qp, wr, &curr_idx, valid_num_sge);
>>
>> + /*
>> + * The pipeline can sequentially post all valid WQEs into WQ buffer,
>> + * including new WQEs waiting for the doorbell to update the PI again.
>> + * Therefore, the owner bit of WQE MUST be updated after all fields
>> + * and extSGEs have been written into DDR instead of cache.
>> + */
>> + if (qp->en_flags & HNS_ROCE_QP_CAP_OWNER_DB)
>> + wmb();
>
> Should this be dma_wmb() ?
>
> Jason
>
Yes, dma_wmb() is better, thank you.
Weihang
prev parent reply other threads:[~2020-10-12 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 9:45 [PATCH v2 for-next] RDMA/hns: Support owner mode doorbell Weihang Li
2020-09-29 16:53 ` Jason Gunthorpe
2020-10-12 11:56 ` liweihang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a828087e5ad4880941310afb6843958@huawei.com \
--to=liweihang@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).