From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Cohen Subject: Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs Date: Tue, 1 Mar 2016 19:49:51 +0200 Message-ID: <20160301174951.GA19366@x-vnc01.mtx.labs.mlnx> References: <1456851143-138332-1-git-send-email-eli@mellanox.com> <1456851143-138332-2-git-send-email-eli@mellanox.com> <20160301173751.GA25176@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160301173751.GA25176-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Mar 01, 2016 at 10:37:51AM -0700, Jason Gunthorpe wrote: > > + return handle_infiniband_guid(dev, &ivt, IFLA_VF_IB_PORT_GUID); > > But is this emulation really necessary? It seems dangerous and > continues the bad practice of assuming IFLA_VF_MAC is fixed to 6 bytes > in size, and is not just LLADDR bytes. I'd rather see mac sets fail on > IB. > struct ifla_vf_mac already defines mac as 32 bytes but the idea here is that applications that configure six byte Ethernet MACs to VFs will continue to work without any change. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html