From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 0/8] use setup_timer() helper function. Date: Fri, 22 Sep 2017 11:00:09 -0600 Message-ID: <20170922170009.GB13235@obsidianresearch.com> References: <1506076036-16496-1-git-send-email-allen.lkml@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1506076036-16496-1-git-send-email-allen.lkml-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Allen Pais Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Fri, Sep 22, 2017 at 03:57:08PM +0530, Allen Pais wrote: > This series uses setup_timer() helper function. The series > addresses the files under drivers/infiniband/hw/*. Since every one of these cases uses 0 or a pointer, I wonder if it would make more sense to have a setup_timer_ptr() variant instead of sprinkling pointer casts everywhere? Maybe someday we could even have a timer callback signature that has a void * instead of long ? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html