From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-core 07/10] providers: Use the new common PCI matching infrastructure Date: Sun, 24 Sep 2017 09:58:45 -0600 Message-ID: <20170924155845.GB14796@obsidianresearch.com> References: <1505855931-4956-1-git-send-email-jgunthorpe@obsidianresearch.com> <1505855931-4956-8-git-send-email-jgunthorpe@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Amrani, Ram" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Devesh Sharma , Mike Marciniszyn , Dennis Dalessandro , Tatyana Nikolova , Yishai Hadas , Vladimir Sokolovsky , "Elior, Ariel" , Adit Ranadive , "pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Sun, Sep 24, 2017 at 01:29:09PM +0000, Amrani, Ram wrote: > > static struct verbs_device *qedr_device_alloc(struct verbs_sysfs_dev *sysfs_dev) > > { > > struct qelr_device *dev; > > @@ -269,7 +238,7 @@ static const struct verbs_device_ops qelr_dev_ops = { > > .name = "qelr", > > Should this be the driver name or the library name? > The driver name is qedr and the library name is libqedr. It is usually abbreviated to qelr. > I reckon that this should be the driver name (otherwise auto-load will fail?!). I will fix all the names, it is confusing as all the other drivers use their lib name as prefix.. The above string is only used for diagnostic prints. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html