linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	jgg-uk2M96/98Pc@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] IB/rxe: remove redudant parameter in function
Date: Tue, 30 Jan 2018 09:27:22 +0200	[thread overview]
Message-ID: <20180130072722.GC2055@mtr-leonro.local> (raw)
In-Reply-To: <1517296074-14459-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

On Tue, Jan 30, 2018 at 02:07:54AM -0500, Zhu Yanjun wrote:
> In the function rxe_av_from_attr, the parameter rxe
> is not used. So it is removed.
>
> CC: Srinivas Eeda <srinivas.eeda-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> CC: Junxiao Bi <junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/infiniband/sw/rxe/rxe_av.c    | 4 ++--
>  drivers/infiniband/sw/rxe/rxe_loc.h   | 4 ++--
>  drivers/infiniband/sw/rxe/rxe_qp.c    | 5 ++---
>  drivers/infiniband/sw/rxe/rxe_verbs.c | 2 +-
>  4 files changed, 7 insertions(+), 8 deletions(-)

Thanks, while you are doing that, can you please change the function
signature to be void? And do the same trick for rxe_av_fill_ip_info(),
it doesn't use rxe too.

Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2018-01-30  7:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30  7:07 [PATCH 1/1] IB/rxe: remove redudant parameter in function Zhu Yanjun
     [not found] ` <1517296074-14459-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-30  7:27   ` Leon Romanovsky [this message]
2018-01-30  7:30   ` Yuval Shaia
2018-01-31 11:06     ` [PATCH 0/6] Trivial patches for SoftRoCE Zhu Yanjun
     [not found]       ` <1517396819-29597-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-31 11:06         ` [PATCH 1/6] IB/rxe: remove redudant parameter in function Zhu Yanjun
     [not found]           ` <1517396819-29597-2-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-31 12:36             ` Leon Romanovsky
2018-01-31 11:06         ` [PATCH 2/6] IB/rxe: change the function to void from int Zhu Yanjun
     [not found]           ` <1517396819-29597-3-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-31 12:35             ` Leon Romanovsky
2018-01-31 11:06         ` [PATCH 3/6] IB/rxe: remove unnecessary parameter in rxe_av_to_attr Zhu Yanjun
     [not found]           ` <1517396819-29597-4-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-31 12:35             ` Leon Romanovsky
2018-01-31 11:06         ` [PATCH 4/6] IB/rxe: change the function to void from int Zhu Yanjun
2018-01-31 11:06         ` [PATCH 5/6] IB/rxe: change the function rxe_av_fill_ip_info to void Zhu Yanjun
2018-01-31 11:06         ` [PATCH 6/6] IB/rxe: remove redudant parameter in rxe_av_fill_ip_info Zhu Yanjun
     [not found]           ` <1517396819-29597-7-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-31 12:35             ` Leon Romanovsky
2018-01-31 12:39         ` [PATCH 0/6] Trivial patches for SoftRoCE Yuval Shaia
2018-01-31 21:34           ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180130072722.GC2055@mtr-leonro.local \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=jgg-uk2M96/98Pc@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).