From: Christoph Hellwig <hch@lst.de>
To: Don Dutile <ddutile@redhat.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
dledford@redhat.com, linux-rdma@vger.kernel.org,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Alex Estrin <alex.estrin@intel.com>,
stable@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH for-next 5/5] IB/isert: Fix for lib/dma_debug check_sync warning
Date: Fri, 18 May 2018 11:00:30 +0200 [thread overview]
Message-ID: <20180518090030.GA24436@lst.de> (raw)
In-Reply-To: <5372c148-a07c-64bb-5608-9ec64a90ef73@redhat.com>
On Thu, May 17, 2018 at 07:01:30PM -0400, Don Dutile wrote:
> Additionally, I believe dma-debug has a bug:
> -- doing a check on an op when there is no op in the dma-ops struct is not correct:
No, that is a feature.
> Note: above: debug_dma_sync is called indep of whether an op function exists.
> For hfi1 & qib & rxe -- which use dma-virt-ops for non-IOMMU-enabled configs,
> the sync_syngle_for_cpu ops does not exist, yet debug_dma_sync is still called.
Yes, if you call dma ops you better make sure you respect the invariants.
This is the only way to get the code right for the 90% case where people
develop on x86 with cache coherent DMA but do calls that only exist
on non-coherent implementations.
next prev parent reply other threads:[~2018-05-18 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 1:31 [PATCH for-next 0/5] IB/hfi1,isert: Updates for-next 5/15/2018 Dennis Dalessandro
2018-05-16 1:31 ` [PATCH for-next 5/5] IB/isert: Fix for lib/dma_debug check_sync warning Dennis Dalessandro
2018-05-16 20:04 ` Jason Gunthorpe
2018-05-16 21:03 ` Don Dutile
2018-05-17 15:03 ` Dennis Dalessandro
2018-05-17 15:10 ` Jason Gunthorpe
2018-05-17 23:01 ` Don Dutile
2018-05-18 9:00 ` Christoph Hellwig [this message]
2018-05-18 17:50 ` Don Dutile
2018-05-22 19:33 ` [PATCH for-next 0/5] IB/hfi1,isert: Updates for-next 5/15/2018 Doug Ledford
2018-05-23 0:54 ` Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518090030.GA24436@lst.de \
--to=hch@lst.de \
--cc=alex.estrin@intel.com \
--cc=ddutile@redhat.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).